From: Stefano Stabellini <sstabellini@kernel.org>
To: Jiandi An <anjiandi@codeaurora.org>
Cc: tim@xen.org, sstabellini@kernel.org, wei.liu2@citrix.com,
George.Dunlap@eu.citrix.com, andrew.cooper3@citrix.com,
ian.jackson@eu.citrix.com, xen-devel@lists.xen.org,
jbeulich@suse.com, shankerd@codeaurora.org
Subject: Re: [PATCH] xen/serial: Fix incorrect length of strncmp for dtuart
Date: Tue, 7 Jun 2016 11:11:59 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.2.10.1606071111520.14126@sstabellini-ThinkPad-X260> (raw)
In-Reply-To: <1465248548-28391-1-git-send-email-anjiandi@codeaurora.org>
On Mon, 6 Jun 2016, Jiandi An wrote:
> In serial_parse_handler(), length of strncmp for dtuart should have been
> 6, not 5.
>
> Signed-off-by: Jiandi An <anjiandi@codeaurora.org>
Acked-by: Stefano Stabellini <sstabellini@kernel.org>
> xen/drivers/char/serial.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/drivers/char/serial.c b/xen/drivers/char/serial.c
> index c583a48..0fc5ced 100644
> --- a/xen/drivers/char/serial.c
> +++ b/xen/drivers/char/serial.c
> @@ -310,7 +310,7 @@ int __init serial_parse_handle(char *conf)
> goto common;
> }
>
> - if ( !strncmp(conf, "dtuart", 5) )
> + if ( !strncmp(conf, "dtuart", 6) )
> {
> handle = SERHND_DTUART;
> goto common;
> --
> Jiandi An
> Qualcomm Innovation Center, Inc.
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-07 10:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 21:29 [PATCH] xen/serial: Fix incorrect length of strncmp for dtuart Jiandi An
2016-06-07 7:29 ` Jan Beulich
2016-06-07 7:58 ` Wei Liu
2016-06-07 10:11 ` Stefano Stabellini [this message]
2016-06-08 5:30 ` Philipp Hahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1606071111520.14126@sstabellini-ThinkPad-X260 \
--to=sstabellini@kernel.org \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=anjiandi@codeaurora.org \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=shankerd@codeaurora.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).