From: Stefano Stabellini <sstabellini@kernel.org>
To: George Dunlap <george.dunlap@citrix.com>
Cc: xen-devel@lists.xenproject.org,
Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH raisin v2 4/4] Update to 4.7, update qemu and qemu_traditional recipes
Date: Thu, 16 Jun 2016 10:51:17 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.2.10.1606161051050.18449@sstabellini-ThinkPad-X260> (raw)
In-Reply-To: <57618DDF.2050007@citrix.com>
On Wed, 15 Jun 2016, George Dunlap wrote:
> On 15/06/16 18:13, Stefano Stabellini wrote:
> > On Wed, 15 Jun 2016, George Dunlap wrote:
> >> Add a 4.7 config file, make it the default.
> >>
> >> Also update the qemu and qemu_traditional recipies after Ian Cambell's
> >> work to split off separate libraries.
> >>
> >> Signed-off-by: George Dunlap <george.dunlap@citrix.com>
> >> ---
> >> Changes in v2:
> >> - Only add the extra #defines when building 4.7 or master, and add an
> >> explanation of what they're for.
> >>
> >>
> >> CC: Stefano Stabellini <sstabellini@kernel.org>
> >> ---
> >> components/qemu | 30 ++++++++++++++++++++++--------
> >> components/qemu_traditional | 2 +-
> >> configs/config-4.7 | 8 ++++++++
> >> defconfig | 2 +-
> >> 4 files changed, 32 insertions(+), 10 deletions(-)
> >>
> >> diff --git a/components/qemu b/components/qemu
> >> index e0d92a5..23e112c 100644
> >> --- a/components/qemu
> >> +++ b/components/qemu
> >> @@ -20,18 +20,32 @@ function qemu_check_package() {
> >> }
> >>
> >> function qemu_build() {
> >> + local QEMU_EXTRA_CFLAGS
> >> cd "$BASEDIR"
> >> git-checkout $QEMU_URL $QEMU_REVISION qemu-dir
> >> cd qemu-dir
> >> - ./configure --enable-xen --target-list=i386-softmmu --prefix=$PREFIX \
> >> - --extra-cflags="-I$INST_DIR/$PREFIX/include" \
> >> - --extra-ldflags="-L$INST_DIR/$PREFIX/lib -Wl,-rpath-link=$INST_DIR/$PREFIX/lib \
> >> +
> >> + QEMU_EXTRA_CFLAGS="-I$INST_DIR/$PREFIX/include"
> >> +
> >> + if [[ "$XEN_RELEASE" == "4.7" || "$XEN_RELEASE" == "master" ]] ; then
> >> + # qemu-xen released with 4.7.0 doesn't use the new libxc api,
> >> + # nor properly detect it so as to use the old version; so we
> > ^ has to use ?
>
> No, but it is rather an unusual grammar construction so maybe it could
> be reworded. What about:
>
> "qemu-xen released with 4.7.0 doesn't use the new libxc api, nor does it
> know how to ask for the compat api, so we need to tell it to do so
> manually."
that's fine
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-06-16 9:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 16:21 [PATCH raisin v2 0/4] Raisin: Fixes for 4.6 and master, update to 4.7 George Dunlap
2016-06-15 16:21 ` [PATCH raisin v2 1/4] components/xen: Actually disable rombios George Dunlap
2016-06-15 16:21 ` [PATCH raisin v2 2/4] config: Separate config urls into a separate file George Dunlap
2016-06-15 16:21 ` [PATCH raisin v2 3/4] Update config-4.6 and config-4.5 to point to stable branches; fix config-master George Dunlap
2016-06-15 17:07 ` Stefano Stabellini
2016-06-15 16:21 ` [PATCH raisin v2 4/4] Update to 4.7, update qemu and qemu_traditional recipes George Dunlap
2016-06-15 17:13 ` Stefano Stabellini
2016-06-15 17:18 ` George Dunlap
2016-06-16 9:51 ` Stefano Stabellini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1606161051050.18449@sstabellini-ThinkPad-X260 \
--to=sstabellini@kernel.org \
--cc=george.dunlap@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).