xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Stefano Stabellini <sstabellini@kernel.org>
To: Juergen Gross <jgross@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	qemu-devel@nongnu.org, kraxel@redhat.com,
	Jan Beulich <JBeulich@suse.com>,
	anthony.perard@citrix.com,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix
Date: Fri, 17 Jun 2016 17:07:08 +0100 (BST)	[thread overview]
Message-ID: <alpine.DEB.2.10.1606171700590.18449@sstabellini-ThinkPad-X260> (raw)
In-Reply-To: <5762AE7B.4030402@suse.com>

On Thu, 16 Jun 2016, Juergen Gross wrote:
> On 16/06/16 15:07, Stefano Stabellini wrote:
> > On Thu, 16 Jun 2016, Juergen Gross wrote:
> >> On 16/06/16 12:54, Jan Beulich wrote:
> >>>>>> On 16.06.16 at 12:02, <JGross@suse.com> wrote:
> >>>> In case the word size of the domU and qemu running the qdisk backend
> >>>> differ BLKIF_OP_DISCARD will not work reliably, as the request
> >>>> structure in the ring have different layouts for different word size.
> >>>>
> >>>> Correct this by copying the request structure in case of different
> >>>> word size element by element in the BLKIF_OP_DISCARD case, too.
> >>>>
> >>>> Signed-off-by: Juergen Gross <jgross@suse.com>
> >>>
> >>> With the indentation (tabs vs blanks) fixed
> >>
> >> Hmm, qemu coding style is to use blanks. I could:
> >> a) leave the patch as is (changed lines indented with blanks)
> >> b) use tabs to indent (style of the modified file up to now)
> >> c) change the style of the file in this patch
> >> d) change the style of the file in a separate patch
> >>
> >> Any preferences?
> > 
> > I would go with d), fixing it to conform with QEMU coding style.
> 
> As I'm about to resync the header with the Linux one as Paul suggested
> it will be more like c). :-)
 
That's not a good idea, as you probably have noticed by now on the other
thread. This patch is OK, you just need to fix the intendation
separately.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  parent reply	other threads:[~2016-06-17 16:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-16 10:02 Juergen Gross
2016-06-16 10:54 ` Jan Beulich
     [not found] ` <5762A17B02000078000F59F3@suse.com>
2016-06-16 11:04   ` Juergen Gross
2016-06-16 11:17     ` Jan Beulich
2016-06-16 13:07     ` Stefano Stabellini
     [not found]     ` <alpine.DEB.2.10.1606161407240.18449@sstabellini-ThinkPad-X260>
2016-06-16 13:49       ` Juergen Gross
     [not found]       ` <5762AE7B.4030402@suse.com>
2016-06-17 16:07         ` Stefano Stabellini [this message]
2016-06-16 11:24 ` [Xen-devel] " Paul Durrant
2016-06-16 12:18   ` Juergen Gross
2016-06-16 12:23     ` Paul Durrant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.10.1606171700590.18449@sstabellini-ThinkPad-X260 \
    --to=sstabellini@kernel.org \
    --cc=JBeulich@suse.com \
    --cc=anthony.perard@citrix.com \
    --cc=jgross@suse.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=xen-devel@lists.xenproject.org \
    --subject='Re: [PATCH] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).