From: Stefano Stabellini <sstabellini@kernel.org>
To: Owen Smith <owen.smith@citrix.com>
Cc: anthony.perard@citrix.com, xen-devel@lists.xenproject.org,
sstabellini@kernel.org, qemu-devel@nongnu.org, kraxel@redhat.com
Subject: Re: [PATCH 2/4] xenfb: Activate mouse handler
Date: Thu, 8 Jun 2017 15:33:03 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.10.1706081532310.26108@sstabellini-ThinkPad-X260> (raw)
In-Reply-To: <1496927734-29174-3-git-send-email-owen.smith@citrix.com>
On Thu, 8 Jun 2017, Owen Smith wrote:
> Mouse events are only delivered to the first handler in the chain.
> Activating the xenfb mouse event handler so that mouse events can
> be passed over the shared ring protocol.
> Note: The keyboard handler is activated internally by the add
> call.
I am not sure I follow: why do we need this now? How is it working
today?
> Signed-off-by: Owen Smith <owen.smith@citrix.com>
> ---
> hw/display/xenfb.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c
> index 2ebc81b..b0a5726 100644
> --- a/hw/display/xenfb.c
> +++ b/hw/display/xenfb.c
> @@ -385,6 +385,7 @@ static void input_connected(struct XenDevice *xendev)
> in->qmouse = qemu_add_mouse_event_handler(xenfb_mouse_event, in,
> in->abs_pointer_wanted,
> "Xen PVFB Mouse");
> + qemu_activate_mouse_event_handler(in->qmouse);
> }
>
> static void input_disconnect(struct XenDevice *xendev)
> --
> 2.1.4
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-06-08 22:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-08 13:15 [PATCH 0/4] xenfb: Add vkbd-only option Owen Smith
2017-06-08 13:15 ` [PATCH 1/4] xenfb: Add feature-vkbd-standalone Owen Smith
2017-06-08 22:31 ` Stefano Stabellini
2017-06-08 13:15 ` [PATCH 2/4] xenfb: Activate mouse handler Owen Smith
2017-06-08 22:33 ` Stefano Stabellini [this message]
2017-06-08 13:15 ` [PATCH 3/4] ui/input: Add activate/remove for keyboard handlers Owen Smith
2017-06-08 13:39 ` Gerd Hoffmann
2017-06-13 15:01 ` Owen Smith
2017-06-08 13:15 ` [PATCH 4/4] xenfb: Fix leak by adding/removing keyboard handler Owen Smith
2017-06-08 22:24 ` [PATCH 0/4] xenfb: Add vkbd-only option Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1706081532310.26108@sstabellini-ThinkPad-X260 \
--to=sstabellini@kernel.org \
--cc=anthony.perard@citrix.com \
--cc=kraxel@redhat.com \
--cc=owen.smith@citrix.com \
--cc=qemu-devel@nongnu.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).