From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Stabellini Subject: Re: [PATCH for-4.12 v2 04/17] xen/arm: p2m: Introduce p2m_is_valid and use it Date: Tue, 4 Dec 2018 15:50:28 -0800 (PST) Message-ID: References: <20181204202651.8836-1-julien.grall@arm.com> <20181204202651.8836-5-julien.grall@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gUKT0-0001BF-SZ for xen-devel@lists.xenproject.org; Tue, 04 Dec 2018 23:51:02 +0000 In-Reply-To: <20181204202651.8836-5-julien.grall@arm.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Julien Grall Cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org List-Id: xen-devel@lists.xenproject.org T24gVHVlLCA0IERlYyAyMDE4LCBKdWxpZW4gR3JhbGwgd3JvdGU6Cj4gVGhlIExQQUUgZm9ybWF0 IGFsbG93cyB0byBzdG9yZSBpbmZvcm1hdGlvbiBpbiBhbiBlbnRyeSBldmVuIHdpdGggdGhlCj4g dmFsaWQgYml0IHVuc2V0LiBJbiBhIGZvbGxvdy11cCBwYXRjaCwgd2Ugd2lsbCB0YWtlIGFkdmFu dGFnZSBvZiB0aGlzCj4gZmVhdHVyZSB0byByZS1wdXJwb3NlIHRoZSB2YWxpZCBiaXQgZm9yIGdl bmVyYXRpbmcgYSB0cmFuc2xhdGlvbiBmYXVsdAo+IGV2ZW4gaWYgYW4gZW50cnkgY29udGFpbnMg dmFsaWQgaW5mb3JtYXRpb24uCj4gCj4gU28gd2UgbmVlZCBhIGRpZmZlcmVudCB3YXkgdG8ga25v dyB3aGV0aGVyIGFuIGVudHJ5IGNvbnRhaW5zIHZhbGlkCj4gaW5mb3JtYXRpb24uIEl0IGlzIHBv c3NpYmxlIHRvIHVzZSB0aGUgaW5mb3JtYXRpb24gaG9sZCBpbiB0aGUgcDJtX3R5cGUKPiB0byBr bm93IGZvciB0aGF0IHB1cnBvc2UuIEluZGVlZCBhbGwgZW50cmllcyBjb250YWluaW5nIHZhbGlk Cj4gaW5mb3JtYXRpb24gd2lsbCBoYXZlIGEgdmFsaWQgcDJtIHR5cGUgKGkuZSBwMm1fdHlwZSAh PSBwMm1faW52YWxpZCkuCj4gCj4gVGhpcyBwYXRjaCBpbnRyb2R1Y2VzIGEgbmV3IGhlbHBlciBw Mm1faXNfdmFsaWQsIHdoaWNoIGltcGxlbWVudHMgdGhhdAo+IGlkZWEsIGFuZCByZXBsYWNlIG1v c3Qgb2YgbHBhZV9pc192YWxpZCBjYWxsIHdpdGggdGhlIG5ldyBoZWxwZXIuIFRoZSBvbmVzCj4g cmVtYWluaW5nIGFyZSBmb3IgVExCcyBoYW5kbGluZyBhbmQgZW50cmllcyBhY2NvdW50aW5nLgo+ IAo+IFdpdGggdGhlIHJlbmFtaW5nIHRoZXJlIGFyZSAyIG90aGVycyBjaGFuZ2VzIHJlcXVpcmVk Ogo+ICAgICAtIEdlbmVyYXRlIHRhYmxlIGVudHJ5IHdpdGggYSB2YWxpZCBwMm0gdHlwZQo+ICAg ICAtIERldGVjdCBuZXcgbWFwcGluZyBmb3IgcHJvcGVyIHN0YXRzIGFjY291bnRpbmcKPiAKPiBT aWduZWQtb2ZmLWJ5OiBKdWxpZW4gR3JhbGwgPGp1bGllbi5ncmFsbEBhcm0uY29tPgoKUmV2aWV3 ZWQtYnk6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4KCihUaGlz IHBhdGNoIGRvZXNuJ3QgYXBwbHkgdG8gbWFzdGVyLCBwbGVhc2UgcmViYXNlKQoKCj4gLS0tCj4g ICAgIENoYW5nZXMgaW4gdjI6Cj4gICAgICAgICAtIERvbid0IG9wZW4tY29kZSBwMm1faXNfc3Vw ZXJwYWdlCj4gLS0tCj4gIHhlbi9hcmNoL2FybS9wMm0uYyB8IDMyICsrKysrKysrKysrKysrKysr KysrKystLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspLCAxMCBk ZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL3AybS5jIGIveGVuL2Fy Y2gvYXJtL3AybS5jCj4gaW5kZXggODFmMzEwN2RkMi4uNDdiNTRjNzkyZSAxMDA2NDQKPiAtLS0g YS94ZW4vYXJjaC9hcm0vcDJtLmMKPiArKysgYi94ZW4vYXJjaC9hcm0vcDJtLmMKPiBAQCAtMjEy LDE3ICsyMTIsMjYgQEAgc3RhdGljIHAybV9hY2Nlc3NfdCBwMm1fbWVtX2FjY2Vzc19yYWRpeF9n ZXQoc3RydWN0IHAybV9kb21haW4gKnAybSwgZ2ZuX3QgZ2ZuKQo+ICB9Cj4gIAo+ICAvKgo+ICsg KiBJbiB0aGUgY2FzZSBvZiB0aGUgUDJNLCB0aGUgdmFsaWQgYml0IGlzIHVzZWQgZm9yIG90aGVy IHB1cnBvc2UuIFVzZQo+ICsgKiB0aGUgdHlwZSB0byBjaGVjayB3aGV0aGVyIGFuIGVudHJ5IGlz IHZhbGlkLgo+ICsgKi8KPiArc3RhdGljIGlubGluZSBib29sIHAybV9pc192YWxpZChscGFlX3Qg cHRlKQo+ICt7Cj4gKyAgICByZXR1cm4gcHRlLnAybS50eXBlICE9IHAybV9pbnZhbGlkOwo+ICt9 Cj4gKwo+ICsvKgo+ICAgKiBscGFlX2lzXyogaGVscGVycyBkb24ndCBjaGVjayB3aGV0aGVyIHRo ZSB2YWxpZCBiaXQgaXMgc2V0IGluIHRoZQo+ICAgKiBQVEUuIFByb3ZpZGUgb3VyIG93biBvdmVy bGF5IHRvIGNoZWNrIHRoZSB2YWxpZCBiaXQuCj4gICAqLwo+ICBzdGF0aWMgaW5saW5lIGJvb2wg cDJtX2lzX21hcHBpbmcobHBhZV90IHB0ZSwgdW5zaWduZWQgaW50IGxldmVsKQo+ICB7Cj4gLSAg ICByZXR1cm4gbHBhZV9pc192YWxpZChwdGUpICYmIGxwYWVfaXNfbWFwcGluZyhwdGUsIGxldmVs KTsKPiArICAgIHJldHVybiBwMm1faXNfdmFsaWQocHRlKSAmJiBscGFlX2lzX21hcHBpbmcocHRl LCBsZXZlbCk7Cj4gIH0KPiAgCj4gIHN0YXRpYyBpbmxpbmUgYm9vbCBwMm1faXNfc3VwZXJwYWdl KGxwYWVfdCBwdGUsIHVuc2lnbmVkIGludCBsZXZlbCkKPiAgewo+IC0gICAgcmV0dXJuIGxwYWVf aXNfdmFsaWQocHRlKSAmJiBscGFlX2lzX3N1cGVycGFnZShwdGUsIGxldmVsKTsKPiArICAgIHJl dHVybiBwMm1faXNfdmFsaWQocHRlKSAmJiBscGFlX2lzX3N1cGVycGFnZShwdGUsIGxldmVsKTsK PiAgfQo+ICAKPiAgI2RlZmluZSBHVUVTVF9UQUJMRV9NQVBfRkFJTEVEIDAKPiBAQCAtMjU2LDcg KzI2NSw3IEBAIHN0YXRpYyBpbnQgcDJtX25leHRfbGV2ZWwoc3RydWN0IHAybV9kb21haW4gKnAy bSwgYm9vbCByZWFkX29ubHksCj4gIAo+ICAgICAgZW50cnkgPSAqdGFibGUgKyBvZmZzZXQ7Cj4g IAo+IC0gICAgaWYgKCAhbHBhZV9pc192YWxpZCgqZW50cnkpICkKPiArICAgIGlmICggIXAybV9p c192YWxpZCgqZW50cnkpICkKPiAgICAgIHsKPiAgICAgICAgICBpZiAoIHJlYWRfb25seSApCj4g ICAgICAgICAgICAgIHJldHVybiBHVUVTVF9UQUJMRV9NQVBfRkFJTEVEOwo+IEBAIC0zNDgsNyAr MzU3LDcgQEAgbWZuX3QgcDJtX2dldF9lbnRyeShzdHJ1Y3QgcDJtX2RvbWFpbiAqcDJtLCBnZm5f dCBnZm4sCj4gIAo+ICAgICAgZW50cnkgPSB0YWJsZVtvZmZzZXRzW2xldmVsXV07Cj4gIAo+IC0g ICAgaWYgKCBscGFlX2lzX3ZhbGlkKGVudHJ5KSApCj4gKyAgICBpZiAoIHAybV9pc192YWxpZChl bnRyeSkgKQo+ICAgICAgewo+ICAgICAgICAgICp0ID0gZW50cnkucDJtLnR5cGU7Cj4gIAo+IEBA IC01MzYsOCArNTQ1LDExIEBAIHN0YXRpYyBscGFlX3QgcGFnZV90b19wMm1fdGFibGUoc3RydWN0 IHBhZ2VfaW5mbyAqcGFnZSkKPiAgICAgIC8qCj4gICAgICAgKiBUaGUgYWNjZXNzIHZhbHVlIGRv ZXMgbm90IG1hdHRlciBiZWNhdXNlIHRoZSBoYXJkd2FyZSB3aWxsIGlnbm9yZQo+ICAgICAgICog dGhlIHBlcm1pc3Npb24gZmllbGRzIGZvciB0YWJsZSBlbnRyeS4KPiArICAgICAqCj4gKyAgICAg KiBXZSB1c2UgcDJtX3JhbV9ydyBzbyB0aGUgZW50cnkgaGFzIGEgdmFsaWQgdHlwZS4gVGhpcyBp cyBpbXBvcnRhbnQKPiArICAgICAqIGZvciBwMm1faXNfdmFsaWQoKSB0byByZXR1cm4gdmFsaWQg b24gdGFibGUgZW50cmllcy4KPiAgICAgICAqLwo+IC0gICAgcmV0dXJuIG1mbl90b19wMm1fZW50 cnkocGFnZV90b19tZm4ocGFnZSksIHAybV9pbnZhbGlkLCBwMm1fYWNjZXNzX3J3eCk7Cj4gKyAg ICByZXR1cm4gbWZuX3RvX3AybV9lbnRyeShwYWdlX3RvX21mbihwYWdlKSwgcDJtX3JhbV9ydywg cDJtX2FjY2Vzc19yd3gpOwo+ICB9Cj4gIAo+ICBzdGF0aWMgaW5saW5lIHZvaWQgcDJtX3dyaXRl X3B0ZShscGFlX3QgKnAsIGxwYWVfdCBwdGUsIGJvb2wgY2xlYW5fcHRlKQo+IEBAIC01NjEsNyAr NTczLDcgQEAgc3RhdGljIGludCBwMm1fY3JlYXRlX3RhYmxlKHN0cnVjdCBwMm1fZG9tYWluICpw Mm0sIGxwYWVfdCAqZW50cnkpCj4gICAgICBzdHJ1Y3QgcGFnZV9pbmZvICpwYWdlOwo+ICAgICAg bHBhZV90ICpwOwo+ICAKPiAtICAgIEFTU0VSVCghbHBhZV9pc192YWxpZCgqZW50cnkpKTsKPiAr ICAgIEFTU0VSVCghcDJtX2lzX3ZhbGlkKCplbnRyeSkpOwo+ICAKPiAgICAgIHBhZ2UgPSBhbGxv Y19kb21oZWFwX3BhZ2UoTlVMTCwgMCk7Cj4gICAgICBpZiAoIHBhZ2UgPT0gTlVMTCApCj4gQEAg LTYxOCw3ICs2MzAsNyBAQCBzdGF0aWMgaW50IHAybV9tZW1fYWNjZXNzX3JhZGl4X3NldChzdHJ1 Y3QgcDJtX2RvbWFpbiAqcDJtLCBnZm5fdCBnZm4sCj4gICAqLwo+ICBzdGF0aWMgdm9pZCBwMm1f cHV0X2wzX3BhZ2UoY29uc3QgbHBhZV90IHB0ZSkKPiAgewo+IC0gICAgQVNTRVJUKGxwYWVfaXNf dmFsaWQocHRlKSk7Cj4gKyAgICBBU1NFUlQocDJtX2lzX3ZhbGlkKHB0ZSkpOwo+ICAKPiAgICAg IC8qCj4gICAgICAgKiBUT0RPOiBIYW5kbGUgb3RoZXIgcDJtIHR5cGVzCj4gQEAgLTY0Niw3ICs2 NTgsNyBAQCBzdGF0aWMgdm9pZCBwMm1fZnJlZV9lbnRyeShzdHJ1Y3QgcDJtX2RvbWFpbiAqcDJt LAo+ICAgICAgc3RydWN0IHBhZ2VfaW5mbyAqcGc7Cj4gIAo+ICAgICAgLyogTm90aGluZyB0byBk byBpZiB0aGUgZW50cnkgaXMgaW52YWxpZC4gKi8KPiAtICAgIGlmICggIWxwYWVfaXNfdmFsaWQo ZW50cnkpICkKPiArICAgIGlmICggIXAybV9pc192YWxpZChlbnRyeSkgKQo+ICAgICAgICAgIHJl dHVybjsKPiAgCj4gICAgICAvKiBOb3RoaW5nIHRvIGRvIGJ1dCB1cGRhdGluZyB0aGUgc3RhdHMg aWYgdGhlIGVudHJ5IGlzIGEgc3VwZXItcGFnZS4gKi8KPiBAQCAtOTQzLDcgKzk1NSw3IEBAIHN0 YXRpYyBpbnQgX19wMm1fc2V0X2VudHJ5KHN0cnVjdCBwMm1fZG9tYWluICpwMm0sCj4gICAgICAg ICAgICAgIGVsc2UKPiAgICAgICAgICAgICAgICAgIHAybS0+bmVlZF9mbHVzaCA9IHRydWU7Cj4g ICAgICAgICAgfQo+IC0gICAgICAgIGVsc2UgLyogbmV3IG1hcHBpbmcgKi8KPiArICAgICAgICBl bHNlIGlmICggIXAybV9pc192YWxpZChvcmlnX3B0ZSkgKSAvKiBuZXcgbWFwcGluZyAqLwo+ICAg ICAgICAgICAgICBwMm0tPnN0YXRzLm1hcHBpbmdzW2xldmVsXSsrOwo+ICAKPiAgICAgICAgICBw Mm1fd3JpdGVfcHRlKGVudHJ5LCBwdGUsIHAybS0+Y2xlYW5fcHRlKTsKPiBAQCAtOTU3LDcgKzk2 OSw3IEBAIHN0YXRpYyBpbnQgX19wMm1fc2V0X2VudHJ5KHN0cnVjdCBwMm1fZG9tYWluICpwMm0s Cj4gICAgICAgKiBGcmVlIHRoZSBlbnRyeSBvbmx5IGlmIHRoZSBvcmlnaW5hbCBwdGUgd2FzIHZh bGlkIGFuZCB0aGUgYmFzZQo+ICAgICAgICogaXMgZGlmZmVyZW50ICh0byBhdm9pZCBmcmVlaW5n IHdoZW4gcGVybWlzc2lvbiBpcyBjaGFuZ2VkKS4KPiAgICAgICAqLwo+IC0gICAgaWYgKCBscGFl X2lzX3ZhbGlkKG9yaWdfcHRlKSAmJgo+ICsgICAgaWYgKCBwMm1faXNfdmFsaWQob3JpZ19wdGUp ICYmCj4gICAgICAgICAgICFtZm5fZXEobHBhZV9nZXRfbWZuKCplbnRyeSksIGxwYWVfZ2V0X21m bihvcmlnX3B0ZSkpICkKPiAgICAgICAgICBwMm1fZnJlZV9lbnRyeShwMm0sIG9yaWdfcHRlLCBs ZXZlbCk7Cj4gIAo+IC0tIAo+IDIuMTEuMAo+IAoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlz dHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xp c3RpbmZvL3hlbi1kZXZlbA==