From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Stabellini Subject: Re: [PATCH for-4.12 v2 05/17] xen/arm: p2m: Handle translation fault in get_page_from_gva Date: Fri, 7 Dec 2018 08:56:23 -0800 (PST) Message-ID: References: <20181204202651.8836-1-julien.grall@arm.com> <20181204202651.8836-6-julien.grall@arm.com> <9dd3ea36-0070-17c6-9133-09e1d7bc4cdd@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gVJQS-0000Ov-17 for xen-devel@lists.xenproject.org; Fri, 07 Dec 2018 16:56:28 +0000 In-Reply-To: <9dd3ea36-0070-17c6-9133-09e1d7bc4cdd@arm.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Julien Grall Cc: xen-devel@lists.xenproject.org, Stefano Stabellini List-Id: xen-devel@lists.xenproject.org T24gRnJpLCA3IERlYyAyMDE4LCBKdWxpZW4gR3JhbGwgd3JvdGU6Cj4gSGkgU3RlZmFubywKPiAK PiBPbiAwNi8xMi8yMDE4IDIyOjA0LCBTdGVmYW5vIFN0YWJlbGxpbmkgd3JvdGU6Cj4gPiBPbiBX ZWQsIDUgRGVjIDIwMTgsIEp1bGllbiBHcmFsbCB3cm90ZToKPiA+ID4gT24gMDQvMTIvMjAxOCAy Mzo1OSwgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOgo+ID4gPiA+IE9uIFR1ZSwgNCBEZWMgMjAx OCwgSnVsaWVuIEdyYWxsIHdyb3RlOgo+ID4gPiA+ID4gQSBmb2xsb3ctdXAgcGF0Y2ggd2lsbCBy ZS1wdXJwb3NlIHRoZSB2YWxpZCBiaXQgb2YgTFBBRSBlbnRyaWVzIHRvCj4gPiA+ID4gPiBnZW5l cmF0ZSBmYXVsdCBldmVuIG9uIGVudHJ5IGNvbnRhaW5pbmcgdmFsaWQgaW5mb3JtYXRpb24uCj4g PiA+ID4gPiAKPiA+ID4gPiA+IFRoaXMgbWVhbnMgdGhhdCB3aGVuIHRyYW5zbGF0aW5nIGEgZ3Vl c3QgVkEgdG8gZ3Vlc3QgUEEgKGUuZyBJUEEpIHdpbGwKPiA+ID4gPiA+IGZhaWwgaWYgdGhlIFN0 YWdlLTIgZW50cmllcyB1c2VkIGhhdmUgdGhlIHZhbGlkIGJpdCB1bnNldC4gQmVjYXVzZSBvZgo+ ID4gPiA+ID4gdGhhdCwgd2UgbmVlZCB0byBmYWxsYmFjayB0byB3YWxrIHRoZSBwYWdlLXRhYmxl IGluIHNvZnR3YXJlIHRvIGNoZWNrCj4gPiA+ID4gPiB3aGV0aGVyIHRoZSBmYXVsdCB3YXMgZXhw ZWN0ZWQuCj4gPiA+ID4gPiAKPiA+ID4gPiA+IFRoaXMgcGF0Y2ggYWRkcyB0aGUgc29mdHdhcmUg cGFnZS10YWJsZSB3YWxrIG9uIGFsbCB0aGUgdHJhbnNsYXRpb24KPiA+ID4gPiA+IGZhdWx0LiBJ dCB3b3VsZCBiZSBwb3NzaWJsZSBpbiB0aGUgZnV0dXJlIHRvIGF2b2lkIHBvaW50bGVzcyB3YWxr IHdoZW4KPiA+ID4gPiA+IHRoZSBmYXVsdCBpbiBQQVJfRUwxIGlzIG5vdCBhIHRyYW5zbGF0aW9u IGZhdWx0Lgo+ID4gPiA+ID4gCj4gPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBKdWxpZW4gR3JhbGwg PGp1bGllbi5ncmFsbEBhcm0uY29tPgo+ID4gPiA+ID4gCj4gPiA+ID4gPiAtLS0KPiA+ID4gPiA+ IAo+ID4gPiA+ID4gVGhlcmUgYXJlIGEgY291cGxlIG9mIFRPRE8gaW4gdGhlIGNvZGUuIFRoZXkg YXJlIGNsZWFuLXVwIGFuZAo+ID4gPiA+ID4gcGVyZm9ybWFuY2UKPiA+ID4gPiA+IGltcHJvdmVt ZW50IChlLmcgd2hlbiB0aGUgZmF1bHQgY2Fubm90IGJlIGhhbmRsZWQpIHRoYXQgY291bGQgYmUK PiA+ID4gPiA+IGRlbGF5ZWQKPiA+ID4gPiA+IGFmdGVyCj4gPiA+ID4gPiB0aGUgc2VyaWVzIGhh cyBiZWVuIG1lcmdlZC4KPiA+ID4gPiA+IAo+ID4gPiA+ID4gICAgICAgQ2hhbmdlcyBpbiB2MjoK PiA+ID4gPiA+ICAgICAgICAgICAtIENoZWNrIHN0YWdlLTIgcGVybWlzc2lvbiBkdXJpbmcgc29m dHdhcmUgbG9va3VwCj4gPiA+ID4gPiAgICAgICAgICAgLSBGaXggdHlwb2VzCj4gPiA+ID4gPiAt LS0KPiA+ID4gPiA+ICAgIHhlbi9hcmNoL2FybS9wMm0uYyB8IDY2Cj4gPiA+ID4gPiArKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0KPiA+ID4gPiA+ ICAgIDEgZmlsZSBjaGFuZ2VkLCA1OSBpbnNlcnRpb25zKCspLHNob3VsZCAgNyBkZWxldGlvbnMo LSkKPiA+ID4gPiA+IAo+ID4gPiA+ID4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9wMm0uYyBi L3hlbi9hcmNoL2FybS9wMm0uYwo+ID4gPiA+ID4gaW5kZXggNDdiNTRjNzkyZS4uMzk2ODBlZWI2 ZSAxMDA2NDQKPiA+ID4gPiA+IC0tLSBhL3hlbi9hcmNoL2FybS9wMm0uYwo+ID4gPiA+ID4gKysr IGIveGVuL2FyY2gvYXJtL3AybS5jCj4gPiA+ID4gPiBAQCAtNiw2ICs2LDcgQEAKPiA+ID4gPiA+ ICAgICAgI2luY2x1ZGUgPGFzbS9ldmVudC5oPgo+ID4gPiA+ID4gICAgI2luY2x1ZGUgPGFzbS9m bHVzaHRsYi5oPgo+ID4gPiA+ID4gKyNpbmNsdWRlIDxhc20vZ3Vlc3Rfd2Fsay5oPgo+ID4gPiA+ ID4gICAgI2luY2x1ZGUgPGFzbS9wYWdlLmg+Cj4gPiA+ID4gPiAgICAgICNkZWZpbmUgTUFYX1ZN SURfOF9CSVQgICgxVUwgPDwgOCkKPiA+ID4gPiA+IEBAIC0xNDMwLDYgKzE0MzEsOCBAQCBzdHJ1 Y3QgcGFnZV9pbmZvICpnZXRfcGFnZV9mcm9tX2d2YShzdHJ1Y3QgdmNwdQo+ID4gPiA+ID4gKnYs Cj4gPiA+ID4gPiB2YWRkcl90IHZhLAo+ID4gPiA+ID4gICAgICAgIHN0cnVjdCBwYWdlX2luZm8g KnBhZ2UgPSBOVUxMOwo+ID4gPiA+ID4gICAgICAgIHBhZGRyX3QgbWFkZHIgPSAwOwo+ID4gPiA+ ID4gICAgICAgIHVpbnQ2NF90IHBhcjsKPiA+ID4gPiA+ICsgICAgbWZuX3QgbWZuOwo+ID4gPiA+ ID4gKyAgICBwMm1fdHlwZV90IHQ7Cj4gPiA+ID4gPiAgICAgICAgICAvKgo+ID4gPiA+ID4gICAg ICAgICAqIFhYWDogVG8gc3VwcG9ydCBhIGRpZmZlcmVudCB2Q1BVLCB3ZSB3b3VsZCBuZWVkIHRv IGxvYWQgdGhlCj4gPiA+ID4gPiBAQCAtMTQ0Niw4ICsxNDQ5LDI5IEBAIHN0cnVjdCBwYWdlX2lu Zm8gKmdldF9wYWdlX2Zyb21fZ3ZhKHN0cnVjdCB2Y3B1Cj4gPiA+ID4gPiAqdiwKPiA+ID4gPiA+ IHZhZGRyX3QgdmEsCj4gPiA+ID4gPiAgICAgICAgcGFyID0gZ3ZpcnRfdG9fbWFkZHIodmEsICZt YWRkciwgZmxhZ3MpOwo+ID4gPiA+ID4gICAgICAgIHAybV9yZWFkX3VubG9jayhwMm0pOwo+ID4g PiA+ID4gICAgKyAgICAvKgo+ID4gPiA+ID4gKyAgICAgKiBndmlydF90b19tYWRkciBtYXkgZmFp bCBpZiB0aGUgZW50cnkgZG9lcyBub3QgaGF2ZSB0aGUgdmFsaWQKPiA+ID4gPiA+IGJpdAo+ID4g PiA+ID4gKyAgICAgKiBzZXQuIEZhbGxiYWNrIHRvIHRoZSBzZWNvbmQgbWV0aG9kOgo+ID4gPiA+ ID4gKyAgICAgKiAgMSkgVHJhbnNsYXRlIHRoZSBWQSB0byBJUEEgdXNpbmcgc29mdHdhcmUgbG9v a3VwIC0+IFN0YWdlLTEKPiA+ID4gPiA+IHBhZ2UtdGFibGUKPiA+ID4gPiA+ICsgICAgICogIG1h eSBub3QgYmUgYWNjZXNzaWJsZSBiZWNhdXNlIHRoZSBzdGFnZS0yIGVudHJpZXMgbWF5IGhhdmUK PiA+ID4gPiA+IHZhbGlkCj4gPiA+ID4gPiArICAgICAqICBiaXQgdW5zZXQuCj4gPiA+ID4gPiAr ICAgICAqICAyKSBTb2Z0d2FyZSBsb29rdXAgb2YgdGhlIE1GTgo+ID4gPiA+ID4gKyAgICAgKgo+ ID4gPiA+ID4gKyAgICAgKiBOb3RlIHRoYXQgd2hlbiBtZW1hY2Nlc3MgaXMgZW5hYmxlZCwgd2Ug aW5zdGVhZCBjYWxsIGRpcmVjdGx5Cj4gPiA+ID4gPiArICAgICAqIHAybV9tZW1fYWNjZXNzX2No ZWNrX2FuZF9nZXRfcGFnZSguLi4pLiBCZWNhdXNlIHRoZSBmdW5jdGlvbgo+ID4gPiA+ID4gaXMg YQo+ID4gPiA+ID4gKyAgICAgKiBhIHZhcmlhbnQgb2YgdGhlIG1ldGhvZHMgZGVzY3JpYmVkIGFi b3ZlLCBpdCB3aWxsIGJlIGFibGUgdG8KPiA+ID4gPiA+ICsgICAgICogaGFuZGxlIGVudHJpZXMg d2l0aCB2YWxpZCBiaXQgdW5zZXQuCj4gPiA+ID4gPiArICAgICAqCj4gPiA+ID4gPiArICAgICAq IFRPRE86IEludGVncmF0ZSBtb3JlIG5pY2VseSBtZW1hY2Nlc3Mgd2l0aCB0aGUgcmVzdCBvZiB0 aGUKPiA+ID4gPiA+ICsgICAgICogZnVuY3Rpb24uCj4gPiA+ID4gPiArICAgICAqIFRPRE86IFVz ZSB0aGUgZmF1bHQgZXJyb3IgaW4gUEFSX0VMMSB0byBhdm9pZCBwb2ludGxlc3MKPiA+ID4gPiA+ ICsgICAgICogIHRyYW5zbGF0aW9uLgo+ID4gPiA+ID4gKyAgICAgKi8KPiA+ID4gPiA+ICAgICAg ICBpZiAoIHBhciApCj4gPiA+ID4gPiAgICAgICAgewo+ID4gPiA+ID4gKyAgICAgICAgcGFkZHJf dCBpcGE7Cj4gPiA+ID4gPiArICAgICAgICB1bnNpZ25lZCBpbnQgczFfcGVybXM7Cj4gPiA+ID4g PiArCj4gPiA+ID4gPiAgICAgICAgICAgIC8qCj4gPiA+ID4gPiAgICAgICAgICAgICAqIFdoZW4g bWVtYWNjZXNzIGlzIGVuYWJsZWQsIHRoZSB0cmFuc2xhdGlvbiBHVkEgdG8gTUFERFIKPiA+ID4g PiA+IG1heQo+ID4gPiA+ID4gICAgICAgICAgICAgKiBoYXZlIGZhaWxlZCBiZWNhdXNlIG9mIGEg cGVybWlzc2lvbiBmYXVsdC4KPiA+ID4gPiA+IEBAIC0xNDU1LDIwICsxNDc5LDQ4IEBAIHN0cnVj dCBwYWdlX2luZm8gKmdldF9wYWdlX2Zyb21fZ3ZhKHN0cnVjdAo+ID4gPiA+ID4gdmNwdQo+ID4g PiA+ID4gKnYsIHZhZGRyX3QgdmEsCj4gPiA+ID4gPiAgICAgICAgICAgIGlmICggcDJtLT5tZW1f YWNjZXNzX2VuYWJsZWQgKQo+ID4gPiA+ID4gICAgICAgICAgICAgICAgcmV0dXJuIHAybV9tZW1f YWNjZXNzX2NoZWNrX2FuZF9nZXRfcGFnZSh2YSwgZmxhZ3MsIHYpOwo+ID4gPiA+ID4gICAgLSAg ICAgICAgZHByaW50ayhYRU5MT0dfR19ERUJVRywKPiA+ID4gPiA+IC0gICAgICAgICAgICAgICAg IiVwdjogZ3ZpcnRfdG9fbWFkZHIgZmFpbGVkIHZhPSUjIlBSSXZhZGRyIgo+ID4gPiA+ID4gZmxh Z3M9MHglbHgKPiA+ID4gPiA+IHBhcj0lIyJQUkl4NjQiXG4iLAo+ID4gPiA+ID4gLSAgICAgICAg ICAgICAgICB2LCB2YSwgZmxhZ3MsIHBhcik7Cj4gPiA+ID4gPiAtICAgICAgICByZXR1cm4gTlVM TDsKPiA+ID4gPiA+ICsgICAgICAgIC8qCj4gPiA+ID4gPiArICAgICAgICAgKiBUaGUgc29mdHdh cmUgc3RhZ2UtMSB0YWJsZSB3YWxrIGNhbiBzdGlsbCBmYWlsLCBlLmcsIGlmCj4gPiA+ID4gPiB0 aGUKPiA+ID4gPiA+ICsgICAgICAgICAqIEdWQSBpcyBub3QgbWFwcGVkLgo+ID4gPiA+ID4gKyAg ICAgICAgICovCj4gPiA+ID4gPiArICAgICAgICBpZiAoICFndWVzdF93YWxrX3RhYmxlcyh2LCB2 YSwgJmlwYSwgJnMxX3Blcm1zKSApCj4gPiA+ID4gPiArICAgICAgICB7Cj4gPiA+ID4gPiArICAg ICAgICAgICAgZHByaW50ayhYRU5MT0dfR19ERUJVRywKPiA+ID4gPiA+ICsgICAgICAgICAgICAg ICAgICAgICIlcHY6IEZhaWxlZCB0byB3YWxrIHBhZ2UtdGFibGUgdmEKPiA+ID4gPiA+ICUjIlBS SXZhZGRyIlxuIiwKPiA+ID4gPiA+IHYsIHZhKTsKPiA+ID4gPiA+ICsgICAgICAgICAgICByZXR1 cm4gTlVMTDsKPiA+ID4gPiA+ICsgICAgICAgIH0KPiA+ID4gPiA+ICsKPiA+ID4gPiA+ICsgICAg ICAgIG1mbiA9IHAybV9sb29rdXAoZCwgZ2FkZHJfdG9fZ2ZuKGlwYSksICZ0KTsKPiA+ID4gPiA+ ICsgICAgICAgIGlmICggbWZuX2VxKElOVkFMSURfTUZOLCBtZm4pIHx8ICFwMm1faXNfcmFtKHQp ICkKPiA+ID4gPiA+ICsgICAgICAgICAgICByZXR1cm4gTlVMTDsKPiA+ID4gPiA+ICsKPiA+ID4g PiA+ICsgICAgICAgIC8qCj4gPiA+ID4gPiArICAgICAgICAgKiBDaGVjayBwZXJtaXNzaW9uIHRo YXQgYXJlIGFzc3VtZWQgYnkgdGhlIGNhbGxlci4gRm9yCj4gPiA+ID4gPiBpbnN0YW5jZQo+ID4g PiA+ID4gKyAgICAgICAgICogaW4gY2FzZSBvZiBndWVzdGNvcHksIHRoZSBjYWxsZXIgYXNzdW1l cyB0aGF0IHRoZQo+ID4gPiA+ID4gdHJhbnNsYXRlZAo+ID4gPiA+ID4gKyAgICAgICAgICogcGFn ZSBjYW4gYmUgYWNjZXNzZWQgd2l0aCB0aGUgcmVxdWVzdGVkIHBlcm1pc3Npb25zLiBJZgo+ID4g PiA+ID4gdGhpcwo+ID4gPiA+ID4gKyAgICAgICAgICogaXMgbm90IHRoZSBjYXNlLCB3ZSBzaG91 bGQgZmFpbC4KPiA+ID4gPiA+ICsgICAgICAgICAqCj4gPiA+ID4gPiArICAgICAgICAgKiBQbGVh c2Ugbm90ZSB0aGF0IHdlIGRvIG5vdCBjaGVjayBmb3IgdGhlIEdWMk1fRVhFQwo+ID4gPiA+ID4g KyAgICAgICAgICogcGVybWlzc2lvbi4gVGhpcyBpcyBmaW5lIGJlY2F1c2UgdGhlIGhhcmR3YXJl LWJhc2VkCj4gPiA+ID4gPiB0cmFuc2xhdGlvbgo+ID4gPiA+ID4gKyAgICAgICAgICogaW5zdHJ1 Y3Rpb24gZG9lcyBub3QgdGVzdCBmb3IgZXhlY3V0ZSBwZXJtaXNzaW9ucy4KPiA+ID4gPiA+ICsg ICAgICAgICAqLwo+ID4gPiA+ID4gKyAgICAgICAgaWYgKCAoZmxhZ3MgJiBHVjJNX1dSSVRFKSAm JiAhKHMxX3Blcm1zICYgR1YyTV9XUklURSkgKQo+ID4gPiA+ID4gKyAgICAgICAgICAgIHJldHVy biBOVUxMOwo+ID4gPiA+ID4gKwo+ID4gPiA+ID4gKyAgICAgICAgaWYgKCAoZmxhZ3MgJiBHVjJN X1dSSVRFKSAmJiB0ICE9IHAybV9yYW1fcncgKQo+ID4gPiA+ID4gKyAgICAgICAgICAgIHJldHVy biBOVUxMOwo+ID4gPiA+IAo+ID4gPiA+IFRoZSBwYXRjaCBsb29rcyBnb29kIGVub3VnaCBub3cu IE9uZSBxdWVzdGlvbjogaXMgaXQgYSByZXF1aXJlbWVudCB0aGF0Cj4gPiA+ID4gdGhlIHBhZ2Ug d2UgYXJlIHRyeWluZyB0byB0cmFuc2xhdGUgaXMgb2YgdHlwZSBwMm1fcmFtXyo/IENvdWxkCj4g PiA+ID4gZ2V0X3BhZ2VfZnJvbV9ndmEgYmUgZ2VudWluZWx5IGNhbGxlZCBwYXNzaW5nIGEgcGFn ZSBvZiBhIGRpZmZlcmVudAo+ID4gPiA+IGtpbmQsIHN1Y2ggYXMgcDJtX21taW9fZGlyZWN0Xyog b3IgcDJtX21hcF9mb3JlaWduPyBUb2RheSwgaXQgaXMgbm90IHRoZQo+ID4gPiA+IGNhc2UsIGJ1 dCBJIHdvbmRlciBpZiBpdCBpcyBzb21ldGhpbmcgd2Ugd2FudCB0byBjb25zaWRlcj8KPiA+ID4g Cj4gPiA+IFRoaXMgZnVuY3Rpb24gY2FuIG9ubHkgcG9zc2libHkgd29yayB3aXRoIHAybV9yYW1f KiBiZWNhdXNlIG9mIHRoZQo+ID4gPiBnZXRfcGFnZSguLi4pIGJlbG93LCBpbmRlZWQgdGhlIHBh Z2Ugc2hvdWxkIGJlbG9uZyB0byB0aGUgZG9tYWluLgo+ID4gPiAKPiA+ID4gRWZmZWN0aXZlbHkg dGhpcyBmdW5jdGlvbiB3aWxsIG9ubHkgYmUgdXNlZCBmb3IgaHlwZXJjYWxsIGFzIHlvdSB1c2Ug YQo+ID4gPiB2aXJ0dWFsCj4gPiA+IGFkZHJlc3MuIEkgcXVlc3Rpb24gdGhlIHZhbHVlIG9mIGFs bG93aW5nIGEgZ3Vlc3QgdG8gZG8gYSBoeXBlcmNhbGwgd2l0aAo+ID4gPiB0aGUKPiA+ID4gZGF0 YSBiYWNrZWQgaW4gYW55IG90aGVyIG1lbW9yaWVzIHRoYW4gZ3Vlc3QgUkFNLiBGb3IgdGhlIGZv cmVpZ24gbWFwcGluZywKPiA+ID4gdGhpcyBjb3VsZCBwb3RlbnRpYWxseSBlbmQgdXAgd2l0aCBh IGxlYWthZ2UuCj4gPiAKPiA+IE9LLgo+IAo+IEkgY2FuIHByb2JhYmx5IGFkZCBhIGZldyBtb3Jl IGRwcmludGsgaW4gdGhlIGVycm9yIHBhdGhzIHRvIGhlbHAgdGhlIGRldmVsb3Blcgo+IHRvIGRp YWdub3N0aWNzIHRoZSBwcm9ibGVtIGlmIHRoYXQncyBldmVyIGhhcHBlbi4gV2hhdCBkbyB5b3Ug dGhpbms/CgpNYXliZSBhIHNob3J0IG9uZSBsaW5lIGNvbW1lbnQgb24gdG9wIHRvIHNheSAidGhp cyBmdW5jdGlvbiBvbmx5IHdvcmsKZm9yIGd1ZXN0IHJhbSBwYWdlcyAobm8gZm9yZWlnbiBtYXBw aW5ncyBvciBNTUlPIHJlZ2lvbnMuKSIganVzdCB0byBtYWtlCml0IHZlcnkgb2J2aW91cyBidXQg aXQgaXMgbm90IG5lY2Vzc2FyeSwgdXAgdG8geW91CgoKPiA+IAo+ID4gUmV2aWV3ZWQtYnk6IFN0 ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4KPiAKPiBUaGFuayB5b3Uh Cj4gCj4gQ2hlZXJzLAo+IAo+IC0tIAo+IEp1bGllbiBHcmFsbAo+IAoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApY ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==