xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Yanmin Zhang <yanmin_zhang@linux.intel.com>,
	Joerg Roedel <jroedel@suse.de>,
	Peter Zijlstra <peterz@infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@kernel.org>, Peter Anvin <hpa@zytor.com>,
	xen-devel <xen-devel@lists.xenproject.org>,
	Borislav Petkov <bp@suse.de>, xiao jin <jin.xiao@intel.com>
Subject: Re: [patch 1/4] hotplug: Prevent alloc/free of irq descriptors during cpu up/down
Date: Tue, 14 Jul 2015 19:32:02 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.11.1507141901460.18576__27947.7015756585$1436895232$gmane$org@nanos> (raw)
In-Reply-To: <55A532C2.4080306@oracle.com>

On Tue, 14 Jul 2015, Boris Ostrovsky wrote:
> On 07/14/2015 11:44 AM, Thomas Gleixner wrote:
> > On Tue, 14 Jul 2015, Boris Ostrovsky wrote:
> > > > Prevent allocation and freeing of interrupt descriptors accross cpu
> > > > hotplug.
> > > 
> > > This breaks Xen guests that allocate interrupt descriptors in .cpu_up().
> > And where exactly does XEN allocate those descriptors?
> 
> xen_cpu_up()
>     xen_setup_timer()
>         bind_virq_to_irqhandler()
>             bind_virq_to_irq()
>                 xen_allocate_irq_dynamic()
>                     xen_allocate_irqs_dynamic()
>                         irq_alloc_descs()
> 
> 
> There is also a similar pass via xen_cpu_up() -> xen_smp_intr_init()

Sigh.
 
> 
> >   
> > > Any chance this locking can be moved into arch code?
> > No.

The issue here is that all architectures need that protection and just
Xen does irq allocations in cpu_up.

So moving that protection into architecture code is not really an
option.

> > > Otherwise we will need to have something like arch_post_cpu_up()
> > > after the lock is released.

I'm not sure, that this will work. You probably want to do this in the
cpu prepare stage, i.e. before calling __cpu_up().

I have to walk the dogs now. Will look into it later tonight.

> > > (The patch doesn't appear to have any side effects for the down path since
> > > Xen
> > > guests deallocate descriptors in __cpu_die()).
> >   Exact place please.
> 
> Whose place? Where descriptors are deallocated?
> 
> __cpu_die()
>     xen_cpu_die()
>         xen_teardown_timer()
>             unbind_from_irqhandler()
>                 unbind_from_irq()
>                     __unbind_from_irq()
>                         xen_free_irq()
>                             irq_free_descs()
>                                 free_desc()

Right, that's outside the lock held region.

Thanks,

	tglx

  parent reply	other threads:[~2015-07-14 17:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20150705170530.849428850@linutronix.de>
     [not found] ` <20150705171102.063519515@linutronix.de>
2015-07-14 14:39   ` [patch 1/4] hotplug: Prevent alloc/free of irq descriptors during cpu up/down Boris Ostrovsky
     [not found]   ` <55A51F10.7010407@oracle.com>
2015-07-14 15:44     ` Thomas Gleixner
     [not found]     ` <alpine.DEB.2.11.1507141743150.18576@nanos>
2015-07-14 16:03       ` Boris Ostrovsky
     [not found]       ` <55A532C2.4080306@oracle.com>
2015-07-14 17:32         ` Thomas Gleixner [this message]
     [not found]         ` <alpine.DEB.2.11.1507141901460.18576@nanos>
2015-07-14 20:04           ` Boris Ostrovsky
     [not found]           ` <55A56B48.4060605@oracle.com>
2015-07-14 20:15             ` Thomas Gleixner
     [not found]             ` <alpine.DEB.2.11.1507142211390.18576@nanos>
2015-07-14 21:07               ` Boris Ostrovsky
     [not found]               ` <55A579FD.6030000@oracle.com>
2016-03-12  9:19                 ` Thomas Gleixner
     [not found]                 ` <alpine.DEB.2.11.1603121017500.3657@nanos>
2016-03-14 13:12                   ` Boris Ostrovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='alpine.DEB.2.11.1507141901460.18576__27947.7015756585$1436895232$gmane$org@nanos' \
    --to=tglx@linutronix.de \
    --cc=boris.ostrovsky@oracle.com \
    --cc=bp@suse.de \
    --cc=hpa@zytor.com \
    --cc=jin.xiao@intel.com \
    --cc=jroedel@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=xen-devel@lists.xenproject.org \
    --cc=yanmin_zhang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).