From: Anna-Maria Gleixner <anna-maria@linutronix.de>
To: David Vrabel <david.vrabel@citrix.com>
Cc: xen-devel@lists.xenproject.org,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
linux-kernel@vger.kernel.org, rt@linutronix.de
Subject: Re: [PATCH] xen/events/fifo: Add missing hotplug notifier transition
Date: Fri, 11 Mar 2016 12:26:08 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.11.1603111219450.5298__10537.9609893591$1457695667$gmane$org@hypnos> (raw)
In-Reply-To: <56E2A3B6.2060208@citrix.com>
On Fri, 11 Mar 2016, David Vrabel wrote:
> On 11/03/16 09:00, Anna-Maria Gleixner wrote:
> > The evtchn_fifo_cpu_notification() hotplug callback lacks handling of
> > the CPU_UP_CANCELED case. That means, if CPU_UP_PREPARE fails, the
> > handle of the fifo events is not dropped.
> >
> > Add handling for CPU_UP_CANCELED transition to drop the fifo events
> > handle.
>
> __evtchn_fifo_handle_events() does not releases resources, it processes
> any pending events for this CPU.
>
> This patch would only be necessary if a CPU in CPU_UP_CANCELED state may
> have had unmasked interrupts. If so you would need:
Thanks for the explanation
> case CPU_UP_CANCELED:
> if (per_cpu(cpu_control_block, cpu))
> __evtchn_fifo_handle_events(cpu, true);
> break;
>
> To handle the case where the control block allocation or initialization
> failed during CPU_UP_PREPARE.
This would not be necessary, because if the CPU_UP_PREPARE of this
notifier fails, the CPU_UP_CANCELLED of this notifier will not be
invoked.
Anna-Maria
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-11 11:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1457686822-39117-1-git-send-email-anna-maria@linutronix.de>
2016-03-11 10:53 ` [PATCH] xen/events/fifo: Add missing hotplug notifier transition David Vrabel
[not found] ` <56E2A3B6.2060208@citrix.com>
2016-03-11 11:26 ` Anna-Maria Gleixner [this message]
2016-03-11 9:00 Anna-Maria Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='alpine.DEB.2.11.1603111219450.5298__10537.9609893591$1457695667$gmane$org@hypnos' \
--to=anna-maria@linutronix.de \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rt@linutronix.de \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).