From: Stefano Stabellini <sstabellini@kernel.org>
To: Julien Grall <julien.grall@arm.com>
Cc: xen-devel@lists.xenproject.org,
Stefano Stabellini <sstabellini@kernel.org>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [Xen-devel] [PATCH] xen/arm: setup: Add Xen as boot module before printing all boot modules
Date: Mon, 12 Aug 2019 12:31:16 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.1908121230570.7788@sstabellini-ThinkPad-T480s> (raw)
In-Reply-To: <20190812112343.26858-1-julien.grall@arm.com>
On Mon, 12 Aug 2019, Julien Grall wrote:
> Since commit f60658c6ae "xen/arm: Stop relocating Xen", the position of
> Xen in memory is not printed anymore. This can make difficult to debug
> early code.
>
> As Xen is not relocated anymore, we can add Xen as boot module before
> calling boot_fdt_info(). With that, the function will print Xen module
> information along with all the other modules.
>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
Acked-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> xen/arch/arm/setup.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
> index d047ff8e31..7509d76dd4 100644
> --- a/xen/arch/arm/setup.c
> +++ b/xen/arch/arm/setup.c
> @@ -779,18 +779,18 @@ void __init start_xen(unsigned long boot_phys_offset,
> "Please check your bootloader.\n",
> fdt_paddr);
>
> - fdt_size = boot_fdt_info(device_tree_flattened, fdt_paddr);
> -
> - cmdline = boot_fdt_cmdline(device_tree_flattened);
> - printk("Command line: %s\n", cmdline);
> - cmdline_parse(cmdline);
> -
> /* Register Xen's load address as a boot module. */
> xen_bootmodule = add_boot_module(BOOTMOD_XEN,
> (paddr_t)(uintptr_t)(_start + boot_phys_offset),
> (paddr_t)(uintptr_t)(_end - _start + 1), false);
> BUG_ON(!xen_bootmodule);
>
> + fdt_size = boot_fdt_info(device_tree_flattened, fdt_paddr);
> +
> + cmdline = boot_fdt_cmdline(device_tree_flattened);
> + printk("Command line: %s\n", cmdline);
> + cmdline_parse(cmdline);
> +
> setup_mm(fdt_paddr, fdt_size);
>
> /* Parse the ACPI tables for possible boot-time configuration */
> --
> 2.11.0
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2019-08-13 6:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 11:23 [Xen-devel] [PATCH] xen/arm: setup: Add Xen as boot module before printing all boot modules Julien Grall
2019-08-12 19:31 ` Stefano Stabellini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1908121230570.7788@sstabellini-ThinkPad-T480s \
--to=sstabellini@kernel.org \
--cc=Volodymyr_Babchuk@epam.com \
--cc=julien.grall@arm.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).