From: Stefano Stabellini <sstabellini@kernel.org>
To: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Julien Grall <julien.grall@arm.com>,
Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [Xen-devel] [PATCH] xen/arm: traps: Remove all zero padding before PRIregister format
Date: Tue, 27 Aug 2019 13:16:13 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.1908271316060.25361@sstabellini-ThinkPad-T480s> (raw)
In-Reply-To: <877e7ggfls.fsf@epam.com>
On Wed, 14 Aug 2019, Volodymyr Babchuk wrote:
> Hi Julien,
>
> Julien Grall writes:
>
> > Commit af156ff085 "xen/arm: types: Specify the zero padding in the
> > definition of PRIregister" moved the zero padding within the definition
> > of PRIregister.
> >
> > However, some of the users still had zero padding before which result
> > to print tens of zero when dumping the CPU state.
> >
> > To prevent this, remove the last users of zero padding before
> > PRIregister.
> >
> > Signed-off-by: Julien Grall <julien.grall@arm.com>
> Reviewed-by: Volodymyr Babchuk <volodymyr.babchuk@epam.com>
Thanks, committed
> > ---
> > xen/arch/arm/traps.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
> > index f062ae6f6a..a3b961bd06 100644
> > --- a/xen/arch/arm/traps.c
> > +++ b/xen/arch/arm/traps.c
> > @@ -938,7 +938,7 @@ static void _show_registers(const struct cpu_user_regs *regs,
> > printk(" TTBR0_EL2: %016"PRIx64"\n", READ_SYSREG64(TTBR0_EL2));
> > printk("\n");
> > printk(" ESR_EL2: %08"PRIx32"\n", regs->hsr);
> > - printk(" HPFAR_EL2: %016"PRIregister"\n", READ_SYSREG(HPFAR_EL2));
> > + printk(" HPFAR_EL2: %"PRIregister"\n", READ_SYSREG(HPFAR_EL2));
> >
> > #ifdef CONFIG_ARM_32
> > printk(" HDFAR: %08"PRIx32"\n", READ_CP32(HDFAR));
> > @@ -1759,7 +1759,7 @@ void dump_guest_s1_walk(struct domain *d, vaddr_t addr)
> > mfn = gfn_to_mfn(d, gaddr_to_gfn(ttbr0));
> >
> > printk("dom%d VA 0x%08"PRIvaddr"\n", d->domain_id, addr);
> > - printk(" TTBCR: 0x%08"PRIregister"\n", ttbcr);
> > + printk(" TTBCR: 0x%"PRIregister"\n", ttbcr);
> > printk(" TTBR0: 0x%016"PRIx64" = 0x%"PRIpaddr"\n",
> > ttbr0, mfn_to_maddr(mfn));
>
>
> --
> Volodymyr Babchuk at EPAM
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2019-08-27 20:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 9:36 [Xen-devel] [PATCH] xen/arm: traps: Remove all zero padding before PRIregister format Julien Grall
2019-08-14 11:18 ` Volodymyr Babchuk
2019-08-27 20:16 ` Stefano Stabellini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1908271316060.25361@sstabellini-ThinkPad-T480s \
--to=sstabellini@kernel.org \
--cc=Volodymyr_Babchuk@epam.com \
--cc=julien.grall@arm.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).