* [Xen-devel] [PATCH] xen/arm: bootfd: Fix indentation in process_multiboot_node()
@ 2019-09-11 15:19 Julien Grall
2019-09-11 17:33 ` Volodymyr Babchuk
0 siblings, 1 reply; 4+ messages in thread
From: Julien Grall @ 2019-09-11 15:19 UTC (permalink / raw)
To: xen-devel; +Cc: Julien Grall, Stefano Stabellini, Volodymyr Babchuk
One line in process_multiboot_node() is using hard tab rather than soft
tab. So fix it!
Signed-off-by: Julien Grall <julien.grall@arm.com>
---
xen/arch/arm/bootfdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
index 258b057f00..623173bc7f 100644
--- a/xen/arch/arm/bootfdt.c
+++ b/xen/arch/arm/bootfdt.c
@@ -264,7 +264,7 @@ static void __init process_multiboot_node(const void *fdt, int node,
case 1: kind = BOOTMOD_RAMDISK; break;
default: break;
}
- if ( kind_guess > 1 && has_xsm_magic(start) )
+ if ( kind_guess > 1 && has_xsm_magic(start) )
kind = BOOTMOD_XSM;
}
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Xen-devel] [PATCH] xen/arm: bootfd: Fix indentation in process_multiboot_node()
2019-09-11 15:19 [Xen-devel] [PATCH] xen/arm: bootfd: Fix indentation in process_multiboot_node() Julien Grall
@ 2019-09-11 17:33 ` Volodymyr Babchuk
2019-09-11 17:58 ` Julien Grall
2019-09-12 17:06 ` Stefano Stabellini
0 siblings, 2 replies; 4+ messages in thread
From: Volodymyr Babchuk @ 2019-09-11 17:33 UTC (permalink / raw)
To: Julien Grall; +Cc: xen-devel, Stefano Stabellini, Volodymyr Babchuk
Julien Grall writes:
> One line in process_multiboot_node() is using hard tab rather than soft
> tab. So fix it!
>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
So, hunting them one-by-one is the preferred way? I'm asking this
because there are more of them:
% find xen/arch/arm -type f -name "*.[ch]" -exec grep -lP "\t" {} \;
xen/arch/arm/traps.c
xen/arch/arm/acpi/boot.c
xen/arch/arm/arm32/lib/assembler.h
xen/arch/arm/arm64/livepatch.c
xen/arch/arm/arm64/lib/find_next_bit.c
xen/arch/arm/arm64/insn.c
xen/arch/arm/alternative.c
xen/arch/arm/bootfdt.c (apparently, I don't have this patch applied)
> ---
> xen/arch/arm/bootfdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
> index 258b057f00..623173bc7f 100644
> --- a/xen/arch/arm/bootfdt.c
> +++ b/xen/arch/arm/bootfdt.c
> @@ -264,7 +264,7 @@ static void __init process_multiboot_node(const void *fdt, int node,
> case 1: kind = BOOTMOD_RAMDISK; break;
> default: break;
> }
> - if ( kind_guess > 1 && has_xsm_magic(start) )
> + if ( kind_guess > 1 && has_xsm_magic(start) )
> kind = BOOTMOD_XSM;
> }
--
Volodymyr Babchuk at EPAM
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Xen-devel] [PATCH] xen/arm: bootfd: Fix indentation in process_multiboot_node()
2019-09-11 17:33 ` Volodymyr Babchuk
@ 2019-09-11 17:58 ` Julien Grall
2019-09-12 17:06 ` Stefano Stabellini
1 sibling, 0 replies; 4+ messages in thread
From: Julien Grall @ 2019-09-11 17:58 UTC (permalink / raw)
To: Volodymyr Babchuk; +Cc: xen-devel, Julien Grall, Stefano Stabellini
[-- Attachment #1.1: Type: text/plain, Size: 926 bytes --]
On Wed, 11 Sep 2019, 18:36 Volodymyr Babchuk, <Volodymyr_Babchuk@epam.com>
wrote:
>
> Julien Grall writes:
>
> > One line in process_multiboot_node() is using hard tab rather than soft
> > tab. So fix it!
> >
> > Signed-off-by: Julien Grall <julien.grall@arm.com>
> Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
>
> So, hunting them one-by-one is the preferred way?
I usually do it while I touch code around. I found this one when debugging
a boot regression today. You are welcome to fix the rest although...
I'm asking this
> because there are more of them:
>
> % find xen/arch/arm -type f -name "*.[ch]" -exec grep -lP "\t" {} \;
> xen/arch/arm/traps.c
> xen/arch/arm/acpi/boot.c
> xen/arch/arm/arm32/lib/assembler.h
> xen/arch/arm/arm64/livepatch.c
> xen/arch/arm/arm64/lib/find_next_bit.c
> xen/arch/arm/arm64/insn.c
>
The 4 above are a copy from Linux and therefore hard tab should stay.
Cheers,
>
[-- Attachment #1.2: Type: text/html, Size: 1996 bytes --]
[-- Attachment #2: Type: text/plain, Size: 157 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Xen-devel] [PATCH] xen/arm: bootfd: Fix indentation in process_multiboot_node()
2019-09-11 17:33 ` Volodymyr Babchuk
2019-09-11 17:58 ` Julien Grall
@ 2019-09-12 17:06 ` Stefano Stabellini
1 sibling, 0 replies; 4+ messages in thread
From: Stefano Stabellini @ 2019-09-12 17:06 UTC (permalink / raw)
To: Volodymyr Babchuk; +Cc: xen-devel, Julien Grall, Stefano Stabellini
On Wed, 11 Sep 2019, Volodymyr Babchuk wrote:
>
> Julien Grall writes:
>
> > One line in process_multiboot_node() is using hard tab rather than soft
> > tab. So fix it!
> >
> > Signed-off-by: Julien Grall <julien.grall@arm.com>
> Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
Acked-by: Stefano Stabellini <sstabellini@kernel.org>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-12 17:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-11 15:19 [Xen-devel] [PATCH] xen/arm: bootfd: Fix indentation in process_multiboot_node() Julien Grall
2019-09-11 17:33 ` Volodymyr Babchuk
2019-09-11 17:58 ` Julien Grall
2019-09-12 17:06 ` Stefano Stabellini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).