From: Stefano Stabellini <sstabellini@kernel.org>
To: Julien Grall <julien.grall@arm.com>
Cc: xen-devel@lists.xenproject.org,
Stefano Stabellini <sstabellini@kernel.org>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
viktor_mitin@epam.com
Subject: Re: [Xen-devel] [PATCH] xen/docs: arm: Update dom0less binding and example
Date: Wed, 2 Oct 2019 15:27:06 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.1910021508370.2691@sstabellini-ThinkPad-T480s> (raw)
In-Reply-To: <20190813213237.4819-1-julien.grall@arm.com>
On Tue, 13 Aug 2019, Julien Grall wrote:
> The binding for the dom0less module does not match Xen implementation.
> Any module should contain the compatible "multiboot,module" to be
> recognized.
>
> This was clearly an oversight as other examples with Xen code base
> provide the compatible "multiboot,module".
>
> So fix the binding and the example associated to it.
>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
Yes!
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
>
> Cc: viktor_mitin@epam.com
>
> We probably want to consolidate all the dom0less documentation in
> one place rather than having to fix documation issues in a multiple
> places one by one.
> ---
> docs/misc/arm/device-tree/booting.txt | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt
> index 317a9e962a..0fafa01b5d 100644
> --- a/docs/misc/arm/device-tree/booting.txt
> +++ b/docs/misc/arm/device-tree/booting.txt
> @@ -160,7 +160,7 @@ The kernel sub-node has the following properties:
>
> - compatible
>
> - "multiboot,kernel"
> + "multiboot,kernel", "multiboot,module"
>
> - reg
>
> @@ -175,7 +175,7 @@ The ramdisk sub-node has the following properties:
>
> - compatible
>
> - "multiboot,ramdisk"
> + "multiboot,ramdisk", "multiboot,module"
>
> - reg
>
> @@ -196,13 +196,13 @@ chosen {
> vpl011;
>
> module@0x4a000000 {
> - compatible = "multiboot,kernel";
> + compatible = "multiboot,kernel", "multiboot,module";
> reg = <0x0 0x4a000000 0xffffff>;
> bootargs = "console=ttyAMA0 init=/bin/sh";
> };
>
> module@0x4b000000 {
> - compatible = "multiboot,ramdisk";
> + compatible = "multiboot,ramdisk", "multiboot,module";
> reg = <0x0 0x4b000000 0xffffff>;
> };
> };
> @@ -215,13 +215,13 @@ chosen {
> cpus = <1>;
>
> module@0x4c000000 {
> - compatible = "multiboot,kernel";
> + compatible = "multiboot,kernel", "multiboot,module";
> reg = <0x0 0x4c000000 0xffffff>;
> bootargs = "console=ttyAMA0 init=/bin/sh";
> };
>
> module@0x4d000000 {
> - compatible = "multiboot,ramdisk";
> + compatible = "multiboot,ramdisk", "multiboot,module";
> reg = <0x0 0x4d000000 0xffffff>;
> };
> };
> --
> 2.11.0
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-10-02 22:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 21:32 [Xen-devel] [PATCH] xen/docs: arm: Update dom0less binding and example Julien Grall
2019-10-02 17:46 ` Julien Grall
2019-10-02 22:27 ` Stefano Stabellini [this message]
2019-10-10 14:45 ` Julien Grall
2019-10-10 14:47 ` Jürgen Groß
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1910021508370.2691@sstabellini-ThinkPad-T480s \
--to=sstabellini@kernel.org \
--cc=Volodymyr_Babchuk@epam.com \
--cc=julien.grall@arm.com \
--cc=viktor_mitin@epam.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).