From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5561AC83000 for ; Thu, 30 Apr 2020 00:34:48 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 244F620731 for ; Thu, 30 Apr 2020 00:34:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="osh6jMnh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 244F620731 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jTx9p-0002AL-TJ; Thu, 30 Apr 2020 00:34:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jTx9o-0002AG-Ld for xen-devel@lists.xenproject.org; Thu, 30 Apr 2020 00:34:28 +0000 X-Inumbo-ID: 5976da0a-8a7a-11ea-9887-bc764e2007e4 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5976da0a-8a7a-11ea-9887-bc764e2007e4; Thu, 30 Apr 2020 00:34:28 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5F71120731; Thu, 30 Apr 2020 00:34:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588206867; bh=XInN9WD+q3mgzx+OHQrHGVwTAvRCMnc5MpQJ2vldbY4=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=osh6jMnhqZJ8WvNP0G/J9F0GTph3J+dT9FOwp4SV6WvoUQhLY4LUeujQEENvrkZbw iYPhrsSL0sCpb1QC/JZ7gfeVtinBDsjWb3/dqr/HXDc4gLB9zesZBOvX8L9OCtyXld TJSXfm5mN7FN3qYVacfzMhia+AvVAJijX89A/P/Q= Date: Wed, 29 Apr 2020 17:34:26 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Jan Beulich Subject: Re: [PATCH 02/12] xen/arm: introduce arch_xen_dom_flags and direct_map In-Reply-To: <4130f640-a664-a9e7-fcd7-85bbd58287e4@suse.com> Message-ID: References: <20200415010255.10081-2-sstabellini@kernel.org> <4130f640-a664-a9e7-fcd7-85bbd58287e4@suse.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , julien@xen.org, Wei Liu , George Dunlap , andrew.cooper3@citrix.com, Ian Jackson , xen-devel@lists.xenproject.org, Stefano Stabellini , Volodymyr_Babchuk@epam.com, =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Wed, 15 Apr 2020, Jan Beulich wrote: > > --- a/xen/arch/arm/domain_build.c > > +++ b/xen/arch/arm/domain_build.c > > @@ -2527,6 +2527,7 @@ int __init construct_dom0(struct domain *d) > > > > iommu_hwdom_init(d); > > > > + d->arch.direct_map = true; > > Shouldn't this get set via arch_domain_create() instead? Yes you are right, this is unnecessary and I can remove it.