From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E279EC388F9 for ; Fri, 20 Nov 2020 00:41:49 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5B8F622240 for ; Fri, 20 Nov 2020 00:41:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="bdC78CeO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B8F622240 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.31499.61913 (Exim 4.92) (envelope-from ) id 1kfuUO-0002MD-Pa; Fri, 20 Nov 2020 00:41:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 31499.61913; Fri, 20 Nov 2020 00:41:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kfuUO-0002M6-MW; Fri, 20 Nov 2020 00:41:24 +0000 Received: by outflank-mailman (input) for mailman id 31499; Fri, 20 Nov 2020 00:41:23 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kfuUN-0002M1-97 for xen-devel@lists.xenproject.org; Fri, 20 Nov 2020 00:41:23 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ee2ecc27-d0f6-4e78-8d2b-1fa6c64a921c; Fri, 20 Nov 2020 00:41:22 +0000 (UTC) Received: from sstabellini-ThinkPad-T480s (c-24-130-65-46.hsd1.ca.comcast.net [24.130.65.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1D66F22244; Fri, 20 Nov 2020 00:41:21 +0000 (UTC) Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kfuUN-0002M1-97 for xen-devel@lists.xenproject.org; Fri, 20 Nov 2020 00:41:23 +0000 X-Inumbo-ID: ee2ecc27-d0f6-4e78-8d2b-1fa6c64a921c Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ee2ecc27-d0f6-4e78-8d2b-1fa6c64a921c; Fri, 20 Nov 2020 00:41:22 +0000 (UTC) Received: from sstabellini-ThinkPad-T480s (c-24-130-65-46.hsd1.ca.comcast.net [24.130.65.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1D66F22244; Fri, 20 Nov 2020 00:41:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605832881; bh=GavnnliBtrzqeKWl7EDe8YQ9zUGuVT+EuXBe3yvCsYM=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=bdC78CeOzGxNqd+CTmurgBmyVlGmtoXT0yOSXVvOp28KDY8cnsgLp7Rv1+jfng5Pt WpH9TK70S4YfGsvgTmJwglRhgCMthTRRrzmwqmmwJ2+RXPf4OSyaKDc6HE7knQfOd7 HzTHHDDdbOANr4btC8E59AE5h03G7b6UWlgNm1dA= Date: Thu, 19 Nov 2020 16:41:20 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Julien Grall cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, Julien Grall , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH RFC 2/6] xen/arm: mm: Remove ; at the end of mm_printk() In-Reply-To: <20201119190751.22345-3-julien@xen.org> Message-ID: References: <20201119190751.22345-1-julien@xen.org> <20201119190751.22345-3-julien@xen.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 19 Nov 2020, Julien Grall wrote: > From: Julien Grall > > The ; at the end of mm_printk() means the following code will not build > correctly: > > if ( ... ) > mm_printk(...); > else > ... > > As we treat the macro as a function, we want to remove the ; at the end > of it. > > Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini > --- > xen/arch/arm/mm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c > index 4dd886f7c80d..59f8a3f15fd1 100644 > --- a/xen/arch/arm/mm.c > +++ b/xen/arch/arm/mm.c > @@ -59,7 +59,7 @@ mm_printk(const char *fmt, ...) {} > { \ > dprintk(XENLOG_ERR, fmt, ## args); \ > WARN(); \ > - } while (0); > + } while (0) > #endif > > /* > -- > 2.17.1 >