From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD5A7C433DB for ; Wed, 20 Jan 2021 19:57:03 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 48F2C2343E for ; Wed, 20 Jan 2021 19:57:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 48F2C2343E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.71732.128697 (Exim 4.92) (envelope-from ) id 1l2Jb3-00027L-2i; Wed, 20 Jan 2021 19:56:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 71732.128697; Wed, 20 Jan 2021 19:56:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l2Jb2-00027E-UR; Wed, 20 Jan 2021 19:56:52 +0000 Received: by outflank-mailman (input) for mailman id 71732; Wed, 20 Jan 2021 19:56:51 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l2Jb1-000279-Lx for xen-devel@lists.xenproject.org; Wed, 20 Jan 2021 19:56:51 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e0682eff-c1f9-4764-8d31-a236027004ec; Wed, 20 Jan 2021 19:56:50 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id A73012343E; Wed, 20 Jan 2021 19:56:49 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e0682eff-c1f9-4764-8d31-a236027004ec DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611172610; bh=PPsE1PNc6ro+lfHP+Fy8znBu6Qo9KnM1gYSYJbNdlog=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Zp3x2J4L3eP8BgtVsgKg4qH7XO5lxinNHbbO6+8kE+T7X8RF25PCdW1uBQ9WSWlNP IrD+rwzdwP3BCgrhYRzoPThMtFoMX1m8Ta8sYLxeAwfqJMVJdgHZlasHacwNfNYvg5 zV+xLFj+kaD8xjaQGajjMUWsuP+xb1b5nx22T5mkuqvZeP/ftKFxVOzyiMGgy4t7of rP+PG0RwfY73k3XAzJIeUcENACinKY+0H7K8uCQ2aw48Hgf94cTIG/YoUdv1rTuzUg BDbawiPT1CYURlfJDntBuEuGjpErywn4f05YfWYOhygxsFzNpvJrjjOlWuwHfkiTtS H/ciNrpuQvV3g== Date: Wed, 20 Jan 2021 11:56:48 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Rahul Singh cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH v5 08/10] xen/arm: smmuv3: Use fallthrough pseudo-keyword In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 20 Jan 2021, Rahul Singh wrote: > Backport commit df561f6688fef775baa341a0f5d960becd248b11 > "treewide: Use fallthrough pseudo-keyword" from Linux kernel. > > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary > fall-through markings when it is the case. > > Signed-off-by: Rahul Singh Reviewed-by: Stefano Stabellini > --- > Changes since v3: > - This patch is introduce in this version. > Changes since v4: > - Add more information about the merged patch in commit message. > --- > --- > xen/drivers/passthrough/arm/smmu-v3.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c > index 5ce14850b4..f5f8b4c981 100644 > --- a/xen/drivers/passthrough/arm/smmu-v3.c > +++ b/xen/drivers/passthrough/arm/smmu-v3.c > @@ -932,7 +932,6 @@ static void arm_smmu_cmdq_skip_err(struct arm_smmu_device *smmu) > */ > return; > case CMDQ_ERR_CERROR_ILL_IDX: > - /* Fallthrough */ > default: > break; > } > @@ -2488,7 +2487,7 @@ static int arm_smmu_device_hw_probe(struct arm_smmu_device *smmu) > switch (FIELD_GET(IDR0_STALL_MODEL, reg)) { > case IDR0_STALL_MODEL_FORCE: > smmu->features |= ARM_SMMU_FEAT_STALL_FORCE; > - /* Fallthrough */ > + fallthrough; > case IDR0_STALL_MODEL_STALL: > smmu->features |= ARM_SMMU_FEAT_STALLS; > } > @@ -2505,7 +2504,7 @@ static int arm_smmu_device_hw_probe(struct arm_smmu_device *smmu) > switch (FIELD_GET(IDR0_TTF, reg)) { > case IDR0_TTF_AARCH32_64: > smmu->ias = 40; > - /* Fallthrough */ > + fallthrough; > case IDR0_TTF_AARCH64: > break; > default: > @@ -2589,7 +2588,7 @@ static int arm_smmu_device_hw_probe(struct arm_smmu_device *smmu) > default: > dev_info(smmu->dev, > "unknown output address size. Truncating to 48-bit\n"); > - /* Fallthrough */ > + fallthrough; > case IDR5_OAS_48_BIT: > smmu->oas = 48; > } > -- > 2.17.1 >