From: Stefano Stabellini <sstabellini@kernel.org>
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: Rahul Singh <Rahul.Singh@arm.com>,
Xen-devel <xen-devel@lists.xenproject.org>,
Stefano Stabellini <sstabellini@kernel.org>,
Julien Grall <julien@xen.org>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
iwj@xenproject.org
Subject: Re: [PATCH] xen/arm : smmuv3: Fix to handle multiple StreamIds per device.
Date: Wed, 17 Feb 2021 15:23:43 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.21.2102171522420.3234@sstabellini-ThinkPad-T480s> (raw)
In-Reply-To: <5145C563-A8AA-41B1-8EBB-B32D1FFC2219@arm.com>
+IanJ
On Wed, 17 Feb 2021, Bertrand Marquis wrote:
> Hi Rahul,
>
>
> > On 17 Feb 2021, at 10:05, Rahul Singh <Rahul.Singh@arm.com> wrote:
> >
> > SMMUv3 driver does not handle multiple StreamId if the master device
> > supports more than one StreamID.
> >
> > This bug was introduced when the driver was ported from Linux to XEN.
> > dt_device_set_protected(..) should be called from add_device(..) not
> > from the dt_xlate(..).
> >
> > Move dt_device_set_protected(..) from dt_xlate(..) to add_device().
> >
> > Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
>
> Thanks a lot, this is fixing issues with multiple stream ids for one device :-)
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> > ---
> > This patch is a candidate for 4.15 as without this patch it is not possible to
> > assign multiple StreamIds to the same device when device is protected behind
> > SMMUv3.
I agree especially considering that the impact is limited to smmu-v3.c.
> > ---
> > xen/drivers/passthrough/arm/smmu-v3.c | 29 ++++++++++-----------------
> > 1 file changed, 11 insertions(+), 18 deletions(-)
> >
> > diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c
> > index 914cdc1cf4..53d150cdb6 100644
> > --- a/xen/drivers/passthrough/arm/smmu-v3.c
> > +++ b/xen/drivers/passthrough/arm/smmu-v3.c
> > @@ -2207,24 +2207,6 @@ static int arm_smmu_add_device(u8 devfn, struct device *dev)
> > */
> > arm_smmu_enable_pasid(master);
> >
> > - return 0;
> > -
> > -err_free_master:
> > - xfree(master);
> > - dev_iommu_priv_set(dev, NULL);
> > - return ret;
> > -}
> > -
> > -static int arm_smmu_dt_xlate(struct device *dev,
> > - const struct dt_phandle_args *args)
> > -{
> > - int ret;
> > - struct iommu_fwspec *fwspec = dev_iommu_fwspec_get(dev);
> > -
> > - ret = iommu_fwspec_add_ids(dev, args->args, 1);
> > - if (ret)
> > - return ret;
> > -
> > if (dt_device_is_protected(dev_to_dt(dev))) {
> > dev_err(dev, "Already added to SMMUv3\n");
> > return -EEXIST;
> > @@ -2237,6 +2219,17 @@ static int arm_smmu_dt_xlate(struct device *dev,
> > dev_name(fwspec->iommu_dev), fwspec->num_ids);
> >
> > return 0;
> > +
> > +err_free_master:
> > + xfree(master);
> > + dev_iommu_priv_set(dev, NULL);
> > + return ret;
> > +}
> > +
> > +static int arm_smmu_dt_xlate(struct device *dev,
> > + const struct dt_phandle_args *args)
> > +{
> > + return iommu_fwspec_add_ids(dev, args->args, 1);
> > }
> >
> > /* Probing and initialisation functions */
> > --
> > 2.17.1
> >
>
next prev parent reply other threads:[~2021-02-17 23:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 10:05 [PATCH] xen/arm : smmuv3: Fix to handle multiple StreamIds per device Rahul Singh
2021-02-17 11:37 ` Bertrand Marquis
2021-02-17 23:23 ` Stefano Stabellini [this message]
2021-02-19 14:46 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2102171522420.3234@sstabellini-ThinkPad-T480s \
--to=sstabellini@kernel.org \
--cc=Bertrand.Marquis@arm.com \
--cc=Rahul.Singh@arm.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=iwj@xenproject.org \
--cc=julien@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).