From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7827FC433E5 for ; Fri, 19 Mar 2021 17:54:26 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 39B866197E for ; Fri, 19 Mar 2021 17:54:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 39B866197E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.99357.188919 (Exim 4.92) (envelope-from ) id 1lNJJq-0001gs-Gj; Fri, 19 Mar 2021 17:53:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 99357.188919; Fri, 19 Mar 2021 17:53:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNJJq-0001gl-Cx; Fri, 19 Mar 2021 17:53:54 +0000 Received: by outflank-mailman (input) for mailman id 99357; Fri, 19 Mar 2021 17:53:52 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lNJJo-0001gg-Oi for xen-devel@lists.xenproject.org; Fri, 19 Mar 2021 17:53:52 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b5ccc73d-eff0-4bd8-a522-da24adbc0ade; Fri, 19 Mar 2021 17:53:51 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 89AF661940; Fri, 19 Mar 2021 17:53:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b5ccc73d-eff0-4bd8-a522-da24adbc0ade DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616176430; bh=BEJ9RkjzI1WOzBgPTlN0SlBzqS9pkrrm/I4Zj4Xc4NQ=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=P5JMoiWykU6EzK9XYK5IDb80VfXP71S9Pz8byPp/It9vQfXmFRKLi/CuafX0HoUwk /CGv/cmF2n/4WVBKpGGdUjisXfzCRa5EuOiQab96RkjeTt+O78kU5oHjJYIhzD+Djt ezABY1BoTBvc7vYyUIF3Pk51ueODqq8Ej21ComrLRUslWVU11KFb78FnduNBy9b4mf 79o9PmKczGojp+VT836U450mNCwXK0dTLlWv0O+Uky5BfQNu50LJ9zXLvi6J7jHZe4 EaA6NBX/skSLbLs7aCwoI6B1TM9He/5iUpchZ4A/2Gc8kLxahI66mjWv03DhkIrQGq OCvoaaXdRCjbA== Date: Fri, 19 Mar 2021 10:53:49 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Boris Ostrovsky cc: Stefano Stabellini , jgross@suse.com, xen-devel@lists.xenproject.org, Stefano Stabellini Subject: Re: [PATCH] xen/arm: introduce XENFEAT_direct_mapped and XENFEAT_not_direct_mapped In-Reply-To: <47d6b423-5414-f14a-2730-74834bfa18f5@oracle.com> Message-ID: References: <20210225235158.24001-1-sstabellini@kernel.org> <4707b219-eee1-22e8-8dd3-6b7d821de333@oracle.com> <47d6b423-5414-f14a-2730-74834bfa18f5@oracle.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 19 Mar 2021, Boris Ostrovsky wrote: > On 3/18/21 7:28 PM, Stefano Stabellini wrote: > > > > So, I'll follow you suggestion, keep the x86 side named as it is today, > > and provide a tiny wrapper so that we can still have an arch-neutral > > xen_swiotlb_detect function (on x86 just calls pci_xen_swiotlb_detect.) > > > But now on x86 side we end up with a routine that noone calls. And pci_xen_swiotlb_detect() becomes not __init and so it will have to stick around after boot for no good reason. (You could have made it __ref btw). > > > I think we should leave x86 alone. And if there is a declaration in include/xen/swiotlb-xen.h that's only relevant to ARM --- well, so be it. Or perhaps you can create arch/arm/include/asm/xen/swiotlb-xen.h Yeah I wanted to avoid creating arch/arm/include/asm/xen/swiotlb-xen.h because I would have to do one of the following: 1) add one more #include to arch/arm64/mm/dma-mapping.c (#include is there already) 2) add #include to include/xen/swiotlb-xen.h What's your preference? If I have to create arch/arm/include/asm/xen/swiotlb-xen.h, I would go with 2).