On Fri, 2 Jul 2021, Luca Fancellu wrote: > > On 1 Jul 2021, at 18:44, Stefano Stabellini wrote: > > > > On Thu, 1 Jul 2021, Luca Fancellu wrote: > >> Hi Stefano, > >> > >>> On 24 Jun 2021, at 00:34, Stefano Stabellini wrote: > >>> > >>> On Mon, 10 May 2021, Luca Fancellu wrote: > >>>> Modification to include/public/grant_table.h: > >>>> > >>>> 1) Add doxygen tags to: > >>>> - Create Grant tables section > >>>> - include variables in the generated documentation > >>>> - Used @keepindent/@endkeepindent to enclose comment > >>>> section that are indented using spaces, to keep > >>>> the indentation. > >>>> 2) Add .rst file for grant table for Arm64 > >>> > >>> Why only arm64? > >> > >> This is a mistake, it should be just “Add .rst file for grant table" > >> > >>> > >>> > >>>> Signed-off-by: Luca Fancellu > >>>> --- > >>>> v6 changes: > >>>> - Fix misaligned comment > >>>> - Moved comments to make them display in the docs > >>>> - Included more documentation in the docs > >>>> (see output here: https://luca.fancellu.gitlab.io/xen-docs/hypercall-interfaces/common/grant_tables.html) > >>> > >>> It looks much much better. All the info we care about seems to be there. > >>> The only things that I noticed missing and might be good to keep is the > >>> small comment about HYPERVISOR_grant_table_op: > >>> > >>> /* ` enum neg_errnoval > >>> * ` HYPERVISOR_grant_table_op(enum grant_table_op cmd, > >>> * ` void *args, > >>> * ` unsigned int count) > >>> * ` > >>> * > >>> * @args points to an array of a per-command data structure. The array > >>> * has @count members > >> > >> Where do you want me to put this comment in the html page? In the end of the description in the top of the page? > > > > Yeah, that looks like a good place > > Great, for a preview, have a look on this: https://luca.fancellu.gitlab.io/xen-docs/hypercall-interfaces/common/grant_tables.html Looks good!