From: Stefano Stabellini <sstabellini@kernel.org>
To: Rahul Singh <rahul.singh@arm.com>
Cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com,
Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Julien Grall <julien@xen.org>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v1 07/14] xen/arm: Add support for Xilinx ZynqMP PCI host controller
Date: Thu, 9 Sep 2021 16:34:28 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.2109091629020.10523@sstabellini-ThinkPad-T480s> (raw)
In-Reply-To: <a3318d9459ace64224a14e4424eef657e2ed5b69.1629366665.git.rahul.singh@arm.com>
On Thu, 19 Aug 2021, Rahul Singh wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>
> Add support for Xilinx ZynqMP PCI host controller to map the PCI config
> space to the XEN memory.
>
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> ---
> xen/arch/arm/pci/Makefile | 1 +
> xen/arch/arm/pci/pci-host-zynqmp.c | 59 ++++++++++++++++++++++++++++++
> 2 files changed, 60 insertions(+)
> create mode 100644 xen/arch/arm/pci/pci-host-zynqmp.c
>
> diff --git a/xen/arch/arm/pci/Makefile b/xen/arch/arm/pci/Makefile
> index 6f32fbbe67..1d045ade01 100644
> --- a/xen/arch/arm/pci/Makefile
> +++ b/xen/arch/arm/pci/Makefile
> @@ -3,3 +3,4 @@ obj-y += pci-access.o
> obj-y += pci-host-generic.o
> obj-y += pci-host-common.o
> obj-y += ecam.o
> +obj-y += pci-host-zynqmp.o
> diff --git a/xen/arch/arm/pci/pci-host-zynqmp.c b/xen/arch/arm/pci/pci-host-zynqmp.c
> new file mode 100644
> index 0000000000..fe103e3855
> --- /dev/null
> +++ b/xen/arch/arm/pci/pci-host-zynqmp.c
> @@ -0,0 +1,59 @@
> +/*
> + * Copyright (C) 2020-2021 EPAM Systems
> + *
> + * Based on Linux drivers/pci/controller/pci-host-common.c
> + * Based on Linux drivers/pci/controller/pci-host-generic.c
> + * Based on xen/arch/arm/pci/pci-host-generic.c
> + * Copyright (C) 2014 ARM Limited Will Deacon <will.deacon@arm.com>
Only one Copyright line per file is enough :-)
But actually all the Copyright lines with a name or a company name are
not really required or useful, as the copyright is noted in full details
in the commit messages (author and signed-off-by lines). I would remove
them all from the new files added by this series.
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program. If not, see <http://www.gnu.org/licenses/>.
> + */
> +
> +#include <asm/device.h>
> +#include <xen/pci.h>
> +#include <asm/pci.h>
> +
> +static const struct dt_device_match gen_pci_dt_match[] = {
> + { .compatible = "xlnx,nwl-pcie-2.11",
> + .data = &pci_generic_ecam_ops },
> + { },
> +};
> +
> +static int gen_pci_dt_init(struct dt_device_node *dev, const void *data)
> +{
> + const struct dt_device_match *of_id;
> + const struct pci_ecam_ops *ops;
> +
> + of_id = dt_match_node(gen_pci_dt_match, dev->dev.of_node);
This should be superfluous
> + ops = (struct pci_ecam_ops *) of_id->data;
> +
> + printk(XENLOG_INFO "Found PCI host bridge %s compatible:%s \n",
> + dt_node_full_name(dev), of_id->compatible);
> +
> + return pci_host_common_probe(dev, ops, 2);
> +}
> +
> +DT_DEVICE_START(pci_gen, "PCI HOST ZYNQMP", DEVICE_PCI)
> +.dt_match = gen_pci_dt_match,
> +.init = gen_pci_dt_init,
> +DT_DEVICE_END
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * tab-width: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
next prev parent reply other threads:[~2021-09-09 23:34 UTC|newest]
Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 12:02 [PATCH v1 00/14] PCI devices passthrough on Arm Rahul Singh
2021-08-19 12:02 ` [PATCH v1 01/14] xen/pci: Refactor MSI code that implements MSI functionality within XEN Rahul Singh
2021-08-19 12:18 ` Julien Grall
2021-08-19 14:16 ` Rahul Singh
2021-09-07 10:01 ` Julien Grall
2021-08-24 15:53 ` Jan Beulich
2021-08-31 12:31 ` Rahul Singh
2021-08-31 13:00 ` Jan Beulich
2021-08-26 13:23 ` Daniel P. Smith
2021-08-19 12:02 ` [PATCH v1 02/14] xen/pci: solve compilation error on ARM with HAS_PCI enabled Rahul Singh
2021-08-19 12:28 ` Julien Grall
2021-08-20 10:30 ` Rahul Singh
2021-08-20 11:37 ` Julien Grall
2021-08-20 11:55 ` Jan Beulich
2021-08-20 12:10 ` Julien Grall
2021-08-20 7:01 ` Jan Beulich
2021-08-20 11:21 ` Rahul Singh
2021-09-09 13:16 ` Julien Grall
2021-08-19 12:02 ` [PATCH v1 03/14] xen/pci: solve compilation error on ARM with ACPI && HAS_PCI Rahul Singh
2021-08-20 7:06 ` Jan Beulich
2021-08-20 11:41 ` Rahul Singh
2021-08-20 11:54 ` Jan Beulich
2021-09-09 1:11 ` Stefano Stabellini
2021-09-10 10:22 ` Rahul Singh
2021-08-19 12:02 ` [PATCH v1 04/14] xen/arm: Add support for PCI init to initialize the PCI driver Rahul Singh
2021-09-07 8:20 ` Julien Grall
2021-09-10 10:47 ` Rahul Singh
2021-09-09 1:16 ` Stefano Stabellini
2021-09-10 10:32 ` Rahul Singh
2021-08-19 12:02 ` [PATCH v1 05/14] xen/arm: PCI host bridge discovery within XEN on ARM Rahul Singh
2021-09-07 9:05 ` Julien Grall
2021-09-10 11:22 ` Rahul Singh
2021-09-10 11:53 ` Julien Grall
2021-09-09 22:54 ` Stefano Stabellini
2021-09-10 11:53 ` Rahul Singh
2021-09-13 14:52 ` Oleksandr Andrushchenko
2021-09-13 20:23 ` Stefano Stabellini
2021-09-14 4:35 ` Oleksandr Andrushchenko
2021-09-14 7:53 ` Oleksandr Andrushchenko
2021-08-19 12:02 ` [PATCH v1 06/14] xen/arm: Add support for PCI ecam operations Rahul Singh
2021-09-09 11:32 ` Julien Grall
2021-09-14 8:13 ` Rahul Singh
2021-09-09 23:21 ` Stefano Stabellini
2021-09-14 11:13 ` Rahul Singh
2021-09-14 23:06 ` Stefano Stabellini
2021-09-15 16:38 ` Rahul Singh
2021-09-15 20:45 ` Stefano Stabellini
2021-09-16 16:51 ` Rahul Singh
2021-08-19 12:02 ` [PATCH v1 07/14] xen/arm: Add support for Xilinx ZynqMP PCI host controller Rahul Singh
2021-09-09 23:34 ` Stefano Stabellini [this message]
2021-09-10 12:01 ` Rahul Singh
2021-09-13 14:46 ` Oleksandr Andrushchenko
2021-09-13 21:02 ` Stefano Stabellini
2021-09-14 4:31 ` Oleksandr Andrushchenko
2021-09-17 7:39 ` Rahul Singh
2021-08-19 12:02 ` [PATCH v1 08/14] xen:arm: Implement pci access functions Rahul Singh
2021-09-09 23:41 ` Stefano Stabellini
2021-09-14 16:05 ` Rahul Singh
2021-09-14 22:40 ` Stefano Stabellini
2021-09-15 7:54 ` Oleksandr Andrushchenko
2021-09-15 10:47 ` Rahul Singh
2021-08-19 12:02 ` [PATCH v1 09/14] xen/arm: Add cmdline boot option "pci=on" Rahul Singh
2021-08-19 12:09 ` Jan Beulich
2021-08-19 12:31 ` Julien Grall
2021-08-20 12:19 ` Rahul Singh
2021-08-20 14:34 ` Julien Grall
2021-08-20 14:37 ` Jan Beulich
2021-09-09 23:46 ` Stefano Stabellini
2021-09-09 23:48 ` Stefano Stabellini
2021-08-19 12:02 ` [PATCH v1 10/14] xen/arm: Discovering PCI devices and add the PCI devices in XEN Rahul Singh
2021-08-19 12:35 ` Julien Grall
2021-08-19 13:40 ` Jan Beulich
2021-08-20 13:05 ` Rahul Singh
2021-08-19 12:02 ` [PATCH v1 11/14] xen/arm: Enable the existing x86 virtual PCI support for ARM Rahul Singh
2021-08-24 16:09 ` Jan Beulich
2021-08-25 5:44 ` Oleksandr Andrushchenko
2021-08-25 6:35 ` Jan Beulich
2021-09-09 13:50 ` Julien Grall
2021-09-16 10:46 ` Rahul Singh
2021-09-10 0:26 ` Stefano Stabellini
2021-09-16 11:01 ` Rahul Singh
2021-09-16 20:26 ` Stefano Stabellini
2021-09-21 13:49 ` Rahul Singh
2021-09-21 21:38 ` Stefano Stabellini
2021-08-19 12:02 ` [PATCH v1 12/14] arm/libxl: Emulated PCI device tree node in libxl Rahul Singh
2021-08-19 13:00 ` Julien Grall
2021-08-20 16:03 ` Rahul Singh
2021-09-09 13:59 ` Julien Grall
2021-09-16 16:16 ` Rahul Singh
2021-09-10 0:51 ` Stefano Stabellini
2021-09-16 16:35 ` Rahul Singh
2021-08-19 12:02 ` [PATCH v1 13/14] xen/arm: Fixed error when PCI device is assigned to guest Rahul Singh
2021-08-19 12:12 ` Jan Beulich
2021-08-19 12:40 ` Julien Grall
2021-08-20 17:01 ` Rahul Singh
2021-08-19 12:02 ` [PATCH v1 14/14] xen/arm: Add linux,pci-domain property for hwdom if not available Rahul Singh
2021-09-10 1:00 ` Stefano Stabellini
2021-09-16 16:36 ` Rahul Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2109091629020.10523@sstabellini-ThinkPad-T480s \
--to=sstabellini@kernel.org \
--cc=Volodymyr_Babchuk@epam.com \
--cc=bertrand.marquis@arm.com \
--cc=julien@xen.org \
--cc=oleksandr_andrushchenko@epam.com \
--cc=rahul.singh@arm.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).