From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 916E1C433EF for ; Thu, 7 Oct 2021 19:55:21 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B40A610C7 for ; Thu, 7 Oct 2021 19:55:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4B40A610C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.203939.359095 (Exim 4.92) (envelope-from ) id 1mYZTt-0002Z8-HX; Thu, 07 Oct 2021 19:55:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 203939.359095; Thu, 07 Oct 2021 19:55:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mYZTt-0002Z1-Dk; Thu, 07 Oct 2021 19:55:05 +0000 Received: by outflank-mailman (input) for mailman id 203939; Thu, 07 Oct 2021 19:55:04 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mYZTs-0002Yp-1g for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 19:55:04 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1a2ba353-26fe-4286-8704-bcaaf39f6f0f; Thu, 07 Oct 2021 19:55:02 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 6323F60F6E; Thu, 7 Oct 2021 19:55:01 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1a2ba353-26fe-4286-8704-bcaaf39f6f0f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633636502; bh=PeomhYfkpEV6kG1rxMyasyBdCL+wFtjPQzws4Etuy+8=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=BitDmeMYE/PpAAVNnxhbHBMamEVL3dKe+YiXbnFDQvYSHrg3weVCeaMvvf2EIXSBr 4VeC6QZj73mvemfM0PKGOnI+9NtdELXmLjDGaFkBAREJlSOM8AQR2sb/5SqoNEY0mf IlfxSRtZr90rDg0Kc/WSFKcHibplIIi9CBuHnLbturyvTORc6EmDaddkTQO6R2WU3p cJb49jLw8XaZy6c5KgLGB0dhoWb866I2tSC1RjBcbB3CWtb7qWsxahXUOHK99p8tHr YqaCOqigr5DoyOqrbqtO8zMrqolMilYQcdY9XvnvCGcgPX2gFx+8b8r7QTah2h1qgD r8ey0mpk9Kq6Q== Date: Thu, 7 Oct 2021 12:54:53 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Rahul Singh cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, Andre.Przywara@arm.com, Ian Jackson , Wei Liu , Juergen Gross , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Christian Lindig , David Scott , Paul Durrant , Anthony PERARD Subject: Re: [PATCH v5 00/11] PCI devices passthrough on Arm In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII I committed patches 2-7. I made two small adjustments on commit: - patch #3: bool_t/bool - patch #7: drop _XEN_DOMCTL_CDF_vpci Cheers, Stefano On Wed, 6 Oct 2021, Rahul Singh wrote: > Hello All, > > The purpose of this patch series is to add PCI passthrough support to Xen on > Arm. PCI passthrough support on ARM is the collaboration work between EPAM and > ARM. ARM submitted the partial RFC [1][2] last year to get early feedback. We > tried to fix all the comments and added more features to this patch series. > > Working POC with all the features can be found at [3]. Working POC is tested > on x86 so that there will be no regression on x86. Design presentation can be > found at [4] > > PCI passthrough support is divided into different patches. This patch series > includes following features: > > Preparatory work to implement the PCI passthrough support for the ARM: > - Refactor MSI code. > - Fixed compilation error when HAS_PCI enabled for ARM. > > Discovering PCI Host Bridge in XEN: > - PCI init to initialize the PCI driver. > - PCI host bridge discovery in XEN and map the PCI ECAM configuration space to > the XEN memory. > - PCI access functions. > > Discovering PCI devices: > - To support the PCI passthrough, XEN should be aware of the PCI > devices. > - Hardware domain is in charge of doing the PCI enumeration and will discover > the PCI devices and then communicate to the XEN via a hypercall to add the > PCI devices in XEN. > > Enable the existing x86 virtual PCI support for ARM: > - Add VPCI trap handler for each of the PCI device added for config space > access. > - Register the trap handler in XEN for each of the host bridge PCI ECAM config > space access. > > Emulated PCI device tree node in libxl: > - Create a virtual PCI device tree node in libxl to enable the guest OS to > discover the virtual PCI during guest boot. > > This patch series does not inlcude the following features. Following features > will be send for review in the next version of the patch series once initial > patch series merged. > > - VPCI support for DOMU guests (Non-identity mappings guest view of the BARs) > - Virtual bus topology implementation > - IOMMU related changes (generic, SMMUv2, SMMUv3) > - MSI support for DOMU guests. > - Virual ITS support for DOMU guests > > [1] https://lists.xenproject.org/archives/html/xen-devel/2020-07/msg01184.html > [2] https://lists.xenproject.org/archives/html/xen-devel/2020-07/threads.html#01184 > [3] https://gitlab.com/rahsingh/xen-integration/-/tree/arm_pci_v4_integrate > [4] https://static.sched.com/hosted_files/xen2021/e4/PCI_Device_Passthrough_On_Arm.pdf > > Oleksandr Andrushchenko (1): > xen/arm: Add support for Xilinx ZynqMP PCI host controller > > Rahul Singh (10): > xen/arm: xc_domain_ioport_permission(..) not supported on ARM. > xen/arm: Add PHYSDEVOP_pci_device_(*add/remove) support for ARM > xen/arm: Add cmdline boot option "pci-passthrough = " > xen/arm: PCI host bridge discovery within XEN on ARM > xen/arm: Implement pci access functions > xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag > xen/arm: Enable the existing x86 virtual PCI support for ARM. > xen/arm: Transitional change to build HAS_VPCI on ARM. > arm/libxl: Emulated PCI device tree node in libxl > xen/arm: Add linux,pci-domain property for hwdom if not available. > > docs/misc/xen-command-line.pandoc | 7 + > tools/include/libxl.h | 6 + > tools/libs/ctrl/xc_domain.c | 9 + > tools/libs/light/libxl_arm.c | 111 +++++++++++ > tools/libs/light/libxl_types.idl | 1 + > tools/ocaml/libs/xc/xenctrl.ml | 1 + > tools/ocaml/libs/xc/xenctrl.mli | 1 + > xen/arch/arm/Makefile | 1 + > xen/arch/arm/domain.c | 8 +- > xen/arch/arm/domain_build.c | 19 ++ > xen/arch/arm/pci/Makefile | 5 + > xen/arch/arm/pci/ecam.c | 61 ++++++ > xen/arch/arm/pci/pci-access.c | 140 ++++++++++++++ > xen/arch/arm/pci/pci-host-common.c | 287 ++++++++++++++++++++++++++++ > xen/arch/arm/pci/pci-host-generic.c | 48 +++++ > xen/arch/arm/pci/pci-host-zynqmp.c | 65 +++++++ > xen/arch/arm/pci/pci.c | 12 ++ > xen/arch/arm/physdev.c | 6 +- > xen/arch/arm/vpci.c | 102 ++++++++++ > xen/arch/arm/vpci.h | 36 ++++ > xen/arch/x86/domain.c | 6 + > xen/arch/x86/physdev.c | 52 +---- > xen/arch/x86/x86_64/physdev.c | 2 +- > xen/common/domain.c | 2 +- > xen/drivers/passthrough/pci.c | 18 ++ > xen/drivers/pci/Makefile | 1 + > xen/drivers/pci/physdev.c | 86 +++++++++ > xen/drivers/vpci/Makefile | 3 +- > xen/drivers/vpci/header.c | 2 + > xen/include/asm-arm/domain.h | 7 +- > xen/include/asm-arm/pci.h | 85 ++++++++ > xen/include/asm-x86/pci.h | 8 +- > xen/include/public/arch-arm.h | 21 +- > xen/include/public/domctl.h | 4 +- > xen/include/xen/hypercall.h | 4 + > xen/include/xen/pci.h | 2 + > 36 files changed, 1168 insertions(+), 61 deletions(-) > create mode 100644 xen/arch/arm/pci/ecam.c > create mode 100644 xen/arch/arm/pci/pci-access.c > create mode 100644 xen/arch/arm/pci/pci-host-common.c > create mode 100644 xen/arch/arm/pci/pci-host-generic.c > create mode 100644 xen/arch/arm/pci/pci-host-zynqmp.c > create mode 100644 xen/arch/arm/vpci.c > create mode 100644 xen/arch/arm/vpci.h > create mode 100644 xen/drivers/pci/physdev.c > > -- > 2.25.1 >