From: M A Young <m.a.young@durham.ac.uk>
To: Jan Beulich <JBeulich@suse.com>
Cc: George Dunlap <dunlapg@umich.edu>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
Marcos Matsunaga <marcos.matsunaga@oracle.com>
Subject: Re: Build problems with xen 4.7
Date: Tue, 7 Jun 2016 11:52:28 +0100 (BST) [thread overview]
Message-ID: <alpine.LFD.2.20.1606071145571.31493@algedi.dur.ac.uk> (raw)
In-Reply-To: <5756C15B02000078000F2880@prv-mh.provo.novell.com>
On Tue, 7 Jun 2016, Jan Beulich wrote:
> >>> On 07.06.16 at 12:35, <dunlapg@umich.edu> wrote:
> > On Fri, May 13, 2016 at 4:23 PM, Konrad Rzeszutek Wilk
> > <konrad.wilk@oracle.com> wrote:
> >> --- xen-4.7.0/config/StdGNU.mk.orig 2016-04-15 22:56:52.191227591 +0100
> >> +++ xen-4.7.0/config/StdGNU.mk 2016-04-15 23:01:40.978829756 +0100
> >> @@ -37,6 +37,12 @@
> >>
> >> ifneq ($(debug),y)
> >> CFLAGS += -O2 -fomit-frame-pointer -fno-tree-coalesce-vars
> >> +ifeq ($(XEN_TARGET_ARCH),x86_64)
> >> +#might be cross-compiling so strip out possible x86_32 options
> >> +CFLAGS += $(shell echo $(CFLAGS_EXTRA) | sed -e 's/-m32//g' -e 's/-march=i686//g' -e 's/-mtune=atom//g')
> >> +else
> >> +CFLAGS += $(CFLAGS_EXTRA)
> >> +endif
> >
> > Why the if? Under what circumstances is it actually appropriate to
> > pass in those kinds of flags to the Xen build system?
>
> -m options in general are machine specific, so any of those three
> may have a meaning on e.g. ARM (I agree that at least for the
> latter two this is rather unlikely, but anyway). Otoh I can't really
> see the purpose of this stripping: If we're cross compiling, the
> extra flags should be set accordingly by the invoking environment.
>
> What I find odd is that this gets put inside a debug=n only section.
I happened to put it there because I was editing the same section to trace
a gcc bug (note the addition of -fno-tree-coalesce-vars in the line above
for that patch). It can go elsewhere, though note that the CFLAGS from the
OS may contain the -O2 option which might interfere with the debug
options.
Michael Young
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-07 10:52 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 23:37 Build problems with xen 4.7 M A Young
2015-12-01 13:19 ` Jan Beulich
2015-12-01 14:36 ` Konrad Rzeszutek Wilk
2015-12-01 14:50 ` Marcos E. Matsunaga
2015-12-01 15:56 ` Jan Beulich
2015-12-01 15:59 ` Konrad Rzeszutek Wilk
2015-12-01 16:09 ` Jan Beulich
2015-12-01 18:47 ` M A Young
2015-12-01 19:40 ` Olaf Hering
2015-12-01 19:53 ` Andrew Cooper
2015-12-02 10:05 ` Jan Beulich
2016-05-13 13:49 ` Konrad Rzeszutek Wilk
2016-05-13 14:01 ` Jan Beulich
2016-05-13 14:25 ` M A Young
2016-05-13 15:23 ` Konrad Rzeszutek Wilk
2016-05-31 18:27 ` George Dunlap
2016-05-31 20:57 ` Konrad Rzeszutek Wilk
2016-06-03 11:20 ` George Dunlap
2016-06-03 17:03 ` Konrad Rzeszutek Wilk
2016-06-07 10:35 ` George Dunlap
2016-06-07 10:42 ` M A Young
2016-06-07 10:50 ` George Dunlap
2016-06-07 11:33 ` Doug Goldstein
2016-06-07 13:48 ` George Dunlap
2016-06-07 14:00 ` Olaf Hering
2016-06-07 14:04 ` George Dunlap
2016-06-07 14:10 ` Olaf Hering
2016-06-08 10:20 ` George Dunlap
2016-06-07 10:43 ` Jan Beulich
2016-06-07 10:52 ` M A Young [this message]
2016-08-08 14:37 ` Peng Fan
2016-08-08 19:22 ` M A Young
2015-12-01 14:49 ` M A Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1606071145571.31493@algedi.dur.ac.uk \
--to=m.a.young@durham.ac.uk \
--cc=JBeulich@suse.com \
--cc=dunlapg@umich.edu \
--cc=marcos.matsunaga@oracle.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).