From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Subject: Re: [PATCH 03/10] libxl_pci: Return error code for more pci-* functions Date: Fri, 1 Apr 2016 16:20:03 +0200 Message-ID: References: <1459514413-18682-1-git-send-email-paulinaszubarczyk@gmail.com> <1459514413-18682-4-git-send-email-paulinaszubarczyk@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0-1173340046-1459520411=:9476" Return-path: Received: from mail6.bemta6.messagelabs.com ([85.158.143.247]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1alzw0-0006VZ-P6 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2016 14:20:24 +0000 In-Reply-To: <1459514413-18682-4-git-send-email-paulinaszubarczyk@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Paulina Szubarczyk Cc: wei.liu2@citrix.com, ian.campbell@citrix.com, George.Dunlap@eu.citrix.com, dario.faggioli@citrix.com, xen-devel@lists.xenproject.org, roger.pau@citrix.com List-Id: xen-devel@lists.xenproject.org --0-1173340046-1459520411=:9476 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT On Fri, 1 Apr 2016, Paulina Szubarczyk wrote: > Return rc value instead of allways 0. ^ extra "l" The subject on this patch is too vague, please use something more descriptive, like: libxl: fix return value of libxl__device_pci_destroy_all > Signed-off-by: Paulina Szubarczyk LGTM, so provided that you fix the subject and commit message: Acked-by: Roger Pau Monné --0-1173340046-1459520411=:9476 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --0-1173340046-1459520411=:9476--