From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wei.liu2@citrix.com>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH v2] libxl: replace the usage of uuid_t with a char array
Date: Fri, 8 Apr 2016 12:29:57 +0200 [thread overview]
Message-ID: <alpine.OSX.2.20.1604081146040.18723@mac> (raw)
In-Reply-To: <22278.39864.945526.61751@mariner.uk.xensource.com>
On Thu, 7 Apr 2016, Ian Jackson wrote:
> Wei Liu writes ("Re: [PATCH v2] libxl: replace the usage of uuid_t with a char array"):
> > A thought: maybe it is worth to have a #define LIBXL_HAVE_UNIFIED_UUID
> > in libxl.h?
>
> This is a good idea.
>
> > /* If this is defined, libxl_uuid is big endian 16-octet stream on all
> > * platform. The libxl_uuid API family will handle transformation
> > * between libxl_uuid format and OS specific format.
> > */
> > #define LBIXL_HAVE_UNIFIED_UUID 1
>
> But the wording here isn't, quite. The "transformation between
> libxl_uuid format and OS specific format" is entirely hidden within
> libxl and exists only to implement the functions provided by libxl.
What about:
/*
* LIBXL_HAVE_BYTEARRAY_UUID
*
* If this is defined, the internal member of libxl_uuid is defined
* as a 16 byte array that contains the UUID in big endian format.
* Also, the same structure layout is used across all OSes.
*/
#define LIBXL_HAVE_BYTEARRAY_UUID 1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-08 10:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 11:11 [PATCH v2] libxl: replace the usage of uuid_t with a char array Roger Pau Monne
2016-04-06 11:14 ` Wei Liu
2016-04-07 16:12 ` Wei Liu
2016-04-07 16:17 ` Wei Liu
2016-04-07 17:41 ` Ian Jackson
2016-04-08 10:29 ` Roger Pau Monné [this message]
2016-04-08 13:42 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.OSX.2.20.1604081146040.18723@mac \
--to=roger.pau@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).