From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15C13C4363A for ; Tue, 20 Oct 2020 17:14:01 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 414092222D for ; Tue, 20 Oct 2020 17:14:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=xen.org header.i=@xen.org header.b="BCkF5dCI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 414092222D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.9744.25676 (Exim 4.92) (envelope-from ) id 1kUvCl-0003xs-RL; Tue, 20 Oct 2020 17:13:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 9744.25676; Tue, 20 Oct 2020 17:13:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kUvCl-0003xl-LN; Tue, 20 Oct 2020 17:13:47 +0000 Received: by outflank-mailman (input) for mailman id 9744; Tue, 20 Oct 2020 17:13:46 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kUvCk-0003wl-I1 for xen-devel@lists.xenproject.org; Tue, 20 Oct 2020 17:13:46 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 221f105f-c56e-4973-a7af-79ab9fac0e24; Tue, 20 Oct 2020 17:13:45 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kUvCg-0000FM-0b; Tue, 20 Oct 2020 17:13:42 +0000 Received: from 54-240-197-236.amazon.com ([54.240.197.236] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kUvCf-0006zy-PL; Tue, 20 Oct 2020 17:13:41 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kUvCk-0003wl-I1 for xen-devel@lists.xenproject.org; Tue, 20 Oct 2020 17:13:46 +0000 X-Inumbo-ID: 221f105f-c56e-4973-a7af-79ab9fac0e24 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 221f105f-c56e-4973-a7af-79ab9fac0e24; Tue, 20 Oct 2020 17:13:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=gEH0W/5uBUfmjQEj5YwJ9g+vVR/8JcE27YLqQ/85Mcw=; b=BCkF5dCIBtzNZF/alEsHdoJfDO aRXOiLLa2DzG7zVy72KdmY1yOsJpbxdNVHc3A8YzuZ+fyc9a3XPCV14ul4zy7kI7xeOmNSxbpiisg o7L6XzVwprG92VBg5a72QB256NUbd6Vh9V8YftBDEv+RvOChPMZwEYH78Urjw+KX3Cyc=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kUvCg-0000FM-0b; Tue, 20 Oct 2020 17:13:42 +0000 Received: from 54-240-197-236.amazon.com ([54.240.197.236] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kUvCf-0006zy-PL; Tue, 20 Oct 2020 17:13:41 +0000 Subject: Re: Xen Coding style and clang-format To: Stefano Stabellini , Artem Mygaiev Cc: Anastasiia Lukianenko , "jbeulich@suse.com" , "George.Dunlap@citrix.com" , "vicooodin@gmail.com" , "xen-devel@lists.xenproject.org" , "committers@xenproject.org" , "viktor.mitin.19@gmail.com" , Volodymyr Babchuk References: <300923eb27aea4d19bff3c21bc51d749c315f8e3.camel@epam.com> <4238269c-3bf4-3acb-7464-3d753f377eef@suse.com> <3ff3f7d16cdab692178ce638da1a6b880817fb7e.camel@epam.com> <64FE5ADB-2359-4A31-B1A1-925750515D98@citrix.com> <4d4f351b152df2c50e18676ccd6ab6b4dc667801.camel@epam.com> <5bd7cc00-c4c9-0737-897d-e76f22e2fd5b@xen.org> From: Julien Grall Message-ID: Date: Tue, 20 Oct 2020 18:13:39 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.3.3 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Hi, On 19/10/2020 19:07, Stefano Stabellini wrote: > On Fri, 16 Oct 2020, Artem Mygaiev wrote: >> -----Original Message----- >> From: Julien Grall >> Sent: пятница, 16 октября 2020 г. 13:24 >> To: Anastasiia Lukianenko ; jbeulich@suse.com; George.Dunlap@citrix.com >> Cc: Artem Mygaiev ; vicooodin@gmail.com; xen-devel@lists.xenproject.org; committers@xenproject.org; viktor.mitin.19@gmail.com; Volodymyr Babchuk >> Subject: Re: Xen Coding style and clang-format >> >>> Hi, >>> >>> On 16/10/2020 10:42, Anastasiia Lukianenko wrote: >>>> Thanks for your advices, which helped me improve the checker. I >>>> understand that there are still some disagreements about the >>>> formatting, but as I said before, the checker cannot be very flexible >>>> and take into account all the author's ideas. >>> >>> I am not sure what you refer by "author's ideas" here. The checker >>> should follow a coding style (Xen or a modified version): >>> - Anything not following the coding style should be considered as >>> invalid. >>> - Anything not written in the coding style should be left >>> untouched/uncommented by the checker. >>> >> >> Agree >> >>>> I suggest using the >>>> checker not as a mandatory check, but as an indication to the author of >>>> possible formatting errors that he can correct or ignore. >>> >>> I can understand that short term we would want to make it optional so >>> either the coding style or the checker can be tuned. But I don't think >>> this is an ideal situation to be in long term. >>> >>> The goal of the checker is to automatically verify the coding style and >>> get it consistent across Xen. If we make it optional or it is >>> "unreliable", then we lose the two benefits and possibly increase the >>> contributor frustration as the checker would say A but we need B. >>> >>> Therefore, we need to make sure the checker and the coding style match. >>> I don't have any opinions on the approach to achieve that. >> >> Of the list of remaining issues from Anastasiia, looks like only items 5 >> and 6 are conform to official Xen coding style. As for remainning ones, >> I would like to suggest disabling those that are controversial (items 1, >> 2, 4, 8, 9, 10). Maybe we want to have further discussion on refining >> coding style, we can use these as starting point. If we are open to >> extending style now, I would suggest to add rules that seem to be >> meaningful (items 3, 7) and keep them in checker. > > Good approach. Yes, I would like to keep 3, 7 in the checker. > > I would also keep 8 and add a small note to the coding style to say that > comments should be aligned where possible. +1 for this. Although, I don't mind the coding style used as long as we have a checker and the code is consistent :). Cheers, -- Julien Grall