From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: jgross@suse.com, vlad.babchuk@gmail.com,
linux-kernel@vger.kernel.org, andrii.anisov@gmail.com,
olekstysh@gmail.com, al1img@gmail.com,
linux-input@vger.kernel.org, xen-devel@lists.xenproject.org,
boris.ostrovsky@oracle.com, joculator@gmail.com
Subject: Re: [PATCH 1/2] xen/input: use string constants from PV protocol
Date: Fri, 5 May 2017 07:43:54 +0300 [thread overview]
Message-ID: <b16fa500-0776-3544-b442-20239d4ffcb1__25836.7787967019$1493959508$gmane$org@gmail.com> (raw)
In-Reply-To: <696b4545-2fb9-4267-8561-55d3f67d83ad@gmail.com>
Hello, Dmitry!
On 04/21/2017 09:42 AM, Oleksandr Andrushchenko wrote:
> On 04/21/2017 05:11 AM, Dmitry Torokhov wrote:
>> On Thu, Apr 13, 2017 at 02:38:03PM +0300, Oleksandr Andrushchenko wrote:
>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>>
>>> Xen input para-virtual protocol defines string constants
>>> used by both back and frontend. Use those instead of
>>> explicit strings in the frontend driver.
>>>
>>> Signed-off-by: Oleksandr Andrushchenko
>>> <oleksandr_andrushchenko@epam.com>
>> I'll have to postpone it until I receive changes containing these new
>> string constants.
> fair enough
>> Otherwise it looks OK.
> thank you
As all the dependencies are now merged into the kernel,
can we please proceed with this patch?
>>> drivers/input/misc/xen-kbdfront.c | 22 +++++++++++++---------
>>> 1 file changed, 13 insertions(+), 9 deletions(-)
>>>
>>> diff --git a/drivers/input/misc/xen-kbdfront.c
>>> b/drivers/input/misc/xen-kbdfront.c
>>> index 2fc7895373ab..01c27b4c3288 100644
>>> --- a/drivers/input/misc/xen-kbdfront.c
>>> +++ b/drivers/input/misc/xen-kbdfront.c
>>> @@ -135,14 +135,17 @@ static int xenkbd_probe(struct xenbus_device
>>> *dev,
>>> goto error_nomem;
>>> /* Set input abs params to match backend screen res */
>>> - abs = xenbus_read_unsigned(dev->otherend,
>>> "feature-abs-pointer", 0);
>>> - ptr_size[KPARAM_X] = xenbus_read_unsigned(dev->otherend, "width",
>>> + abs = xenbus_read_unsigned(dev->otherend,
>>> + XENKBD_FIELD_FEAT_ABS_POINTER, 0);
>>> + ptr_size[KPARAM_X] = xenbus_read_unsigned(dev->otherend,
>>> + XENKBD_FIELD_WIDTH,
>>> ptr_size[KPARAM_X]);
>>> - ptr_size[KPARAM_Y] = xenbus_read_unsigned(dev->otherend, "height",
>>> + ptr_size[KPARAM_Y] = xenbus_read_unsigned(dev->otherend,
>>> + XENKBD_FIELD_HEIGHT,
>>> ptr_size[KPARAM_Y]);
>>> if (abs) {
>>> ret = xenbus_write(XBT_NIL, dev->nodename,
>>> - "request-abs-pointer", "1");
>>> + XENKBD_FIELD_REQ_ABS_POINTER, "1");
>>> if (ret) {
>>> pr_warning("xenkbd: can't request abs-pointer");
>>> abs = 0;
>>> @@ -271,14 +274,15 @@ static int xenkbd_connect_backend(struct
>>> xenbus_device *dev,
>>> xenbus_dev_fatal(dev, ret, "starting transaction");
>>> goto error_irqh;
>>> }
>>> - ret = xenbus_printf(xbt, dev->nodename, "page-ref", "%lu",
>>> + ret = xenbus_printf(xbt, dev->nodename, XENKBD_FIELD_RING_REF,
>>> "%lu",
>>> virt_to_gfn(info->page));
>>> if (ret)
>>> goto error_xenbus;
>>> - ret = xenbus_printf(xbt, dev->nodename, "page-gref", "%u",
>>> info->gref);
>>> + ret = xenbus_printf(xbt, dev->nodename, XENKBD_FIELD_RING_GREF,
>>> + "%u", info->gref);
>>> if (ret)
>>> goto error_xenbus;
>>> - ret = xenbus_printf(xbt, dev->nodename, "event-channel", "%u",
>>> + ret = xenbus_printf(xbt, dev->nodename,
>>> XENKBD_FIELD_EVT_CHANNEL, "%u",
>>> evtchn);
>>> if (ret)
>>> goto error_xenbus;
>>> @@ -353,7 +357,7 @@ static void xenkbd_backend_changed(struct
>>> xenbus_device *dev,
>>> }
>>> static const struct xenbus_device_id xenkbd_ids[] = {
>>> - { "vkbd" },
>>> + { XENKBD_DRIVER_NAME },
>>> { "" }
>>> };
>>> @@ -390,4 +394,4 @@ module_exit(xenkbd_cleanup);
>>> MODULE_DESCRIPTION("Xen virtual keyboard/pointer device frontend");
>>> MODULE_LICENSE("GPL");
>>> -MODULE_ALIAS("xen:vkbd");
>>> +MODULE_ALIAS("xen:" XENKBD_DRIVER_NAME);
>>> --
>>> 2.7.4
>>>
> Thank you,
> Oleksandr
Thank you,
Oleksandr
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-05-05 4:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1492083484-31786-1-git-send-email-andr2000@gmail.com>
2017-04-13 11:38 ` [PATCH 1/2] xen/input: use string constants from PV protocol Oleksandr Andrushchenko
2017-04-13 11:38 ` [PATCH 2/2] xen/input: add multi-touch support Oleksandr Andrushchenko
[not found] ` <1492083484-31786-3-git-send-email-andr2000@gmail.com>
2017-04-21 2:10 ` Dmitry Torokhov
[not found] ` <20170421021018.GB23279@dtor-ws>
2017-04-21 6:40 ` Oleksandr Andrushchenko
[not found] ` <bd6b6680-6023-765f-d80f-b00e2b6dd597@gmail.com>
2017-05-05 4:45 ` Oleksandr Andrushchenko
[not found] ` <8a43bbdf-f843-2c4d-e7b7-0cddb2e7fd7e@gmail.com>
2017-05-12 13:44 ` Oleksandr Andrushchenko
[not found] ` <8d522e12-8a1b-1eb4-981c-9bb1042e9703@gmail.com>
2017-05-22 13:25 ` Oleksandr Andrushchenko
2017-05-30 5:51 ` Dmitry Torokhov
[not found] ` <20170530055150.GA38163@dtor-ws>
2017-05-30 12:50 ` Oleksandr Andrushchenko
[not found] ` <8092dd49-20e0-3e8d-977d-2f570142a37d@gmail.com>
2017-05-30 16:37 ` Dmitry Torokhov
[not found] ` <20170530163708.GA12922@dtor-ws>
2017-05-31 9:06 ` Oleksandr Andrushchenko
[not found] ` <c355258d-f207-aa5e-a170-e52438102a37@gmail.com>
2017-06-07 7:15 ` Oleksandr Andrushchenko
2017-06-07 16:56 ` Dmitry Torokhov
[not found] ` <20170607165630.GA13116@dtor-ws>
2017-06-08 6:45 ` Oleksandr Andrushchenko
[not found] ` <222abecb-10b6-6196-9f44-6ec366377335@gmail.com>
2017-06-19 10:00 ` Oleksandr Andrushchenko
2017-06-21 7:24 ` Dmitry Torokhov
[not found] ` <20170621072425.GA36968@dtor-ws>
2017-06-21 8:54 ` Oleksandr Andrushchenko
[not found] ` <1492083484-31786-2-git-send-email-andr2000@gmail.com>
2017-04-21 2:11 ` [PATCH 1/2] xen/input: use string constants from PV protocol Dmitry Torokhov
[not found] ` <20170421021100.GC23279@dtor-ws>
2017-04-21 6:42 ` Oleksandr Andrushchenko
[not found] ` <696b4545-2fb9-4267-8561-55d3f67d83ad@gmail.com>
2017-05-05 4:43 ` Oleksandr Andrushchenko [this message]
[not found] ` <b16fa500-0776-3544-b442-20239d4ffcb1@gmail.com>
2017-05-12 13:43 ` Oleksandr Andrushchenko
[not found] ` <390ca032-8123-d9d6-734d-e424dce43708@gmail.com>
2017-05-22 13:24 ` Oleksandr Andrushchenko
2017-05-30 12:37 ` Oleksandr Andrushchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='b16fa500-0776-3544-b442-20239d4ffcb1__25836.7787967019$1493959508$gmane$org@gmail.com' \
--to=andr2000@gmail.com \
--cc=al1img@gmail.com \
--cc=andrii.anisov@gmail.com \
--cc=boris.ostrovsky@oracle.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jgross@suse.com \
--cc=joculator@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olekstysh@gmail.com \
--cc=vlad.babchuk@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).