From: Jan Beulich <jbeulich@suse.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH 1/2] x86/oprofile: fix oprofile for clang build
Date: Fri, 23 Apr 2021 11:45:33 +0200 [thread overview]
Message-ID: <b1bac4bc-f406-b111-a46a-fb407eabceb3@suse.com> (raw)
In-Reply-To: <20210423094343.5850-2-roger.pau@citrix.com>
On 23.04.2021 11:43, Roger Pau Monne wrote:
> Clang complains with:
>
> backtrace.c:46:19: error: unused function 'is_32bit_vcpu' [-Werror,-Wunused-function]
> static inline int is_32bit_vcpu(struct vcpu *vcpu)
> ^
>
> Fix this by guarding the function with CONFIG_COMPAT, as it's only
> caller is also doing so.
>
> Fixes: d23d792478d ('x86: avoid building COMPAT code when !HVM && !PV32')
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
See my "x86/oprof: fix !HVM && !PV32 build" from the 16th.
Jan
next prev parent reply other threads:[~2021-04-23 9:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 9:43 [PATCH 0/2] x86/clang: build fixes Roger Pau Monne
2021-04-23 9:43 ` [PATCH 1/2] x86/oprofile: fix oprofile for clang build Roger Pau Monne
2021-04-23 9:45 ` Jan Beulich [this message]
2021-04-23 9:43 ` [PATCH 2/2] x86/pv: fix clang build without CONFIG_PV32 Roger Pau Monne
2021-04-23 9:46 ` Roger Pau Monné
2021-04-23 9:48 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1bac4bc-f406-b111-a46a-fb407eabceb3@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).