From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 197CFC433ED for ; Fri, 23 Apr 2021 09:45:49 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B5E8C61463 for ; Fri, 23 Apr 2021 09:45:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5E8C61463 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.116018.221394 (Exim 4.92) (envelope-from ) id 1lZsNU-00030a-LY; Fri, 23 Apr 2021 09:45:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 116018.221394; Fri, 23 Apr 2021 09:45:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lZsNU-00030T-Hm; Fri, 23 Apr 2021 09:45:36 +0000 Received: by outflank-mailman (input) for mailman id 116018; Fri, 23 Apr 2021 09:45:35 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lZsNT-00030L-FA for xen-devel@lists.xenproject.org; Fri, 23 Apr 2021 09:45:35 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6fee097a-eeee-4c85-9fe6-997d0b23c85e; Fri, 23 Apr 2021 09:45:34 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 48E87AC7D; Fri, 23 Apr 2021 09:45:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6fee097a-eeee-4c85-9fe6-997d0b23c85e X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1619171133; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XLQV4kiqmFdESHxAW6tg9GDsZLiRz9sApRi0SZPZ9QM=; b=lDWCATq0IuJ7JjrQjmqWHk4bQX8Jl5PZZJO3iHzzBgk3vbGfamX19wAPLdwiBhfZbfwm+E Q+N3kh06dnUnWNMXaJbem7ROk/GelTHF0BZYJrFh/BuqC/CdEBOERTGyoB+/0omvGbP7nU uESo2YFrHq49XvzSpZW/9afBaXUCAFo= Subject: Re: [PATCH 1/2] x86/oprofile: fix oprofile for clang build To: Roger Pau Monne Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20210423094343.5850-1-roger.pau@citrix.com> <20210423094343.5850-2-roger.pau@citrix.com> From: Jan Beulich Message-ID: Date: Fri, 23 Apr 2021 11:45:33 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210423094343.5850-2-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 23.04.2021 11:43, Roger Pau Monne wrote: > Clang complains with: > > backtrace.c:46:19: error: unused function 'is_32bit_vcpu' [-Werror,-Wunused-function] > static inline int is_32bit_vcpu(struct vcpu *vcpu) > ^ > > Fix this by guarding the function with CONFIG_COMPAT, as it's only > caller is also doing so. > > Fixes: d23d792478d ('x86: avoid building COMPAT code when !HVM && !PV32') > Signed-off-by: Roger Pau Monné See my "x86/oprof: fix !HVM && !PV32 build" from the 16th. Jan