From: Jan Beulich <jbeulich@suse.com>
To: Penny Zheng <penny.zheng@arm.com>
Cc: Bertrand.Marquis@arm.com, Wei.Chen@arm.com, nd@arm.com,
xen-devel@lists.xenproject.org, sstabellini@kernel.org,
julien@xen.org
Subject: Re: [PATCH V3 05/10] xen/arm: static memory initialization
Date: Mon, 19 Jul 2021 10:25:18 +0200 [thread overview]
Message-ID: <b2ef39b8-4bdd-6d50-0c6b-a44fdf0608e3@suse.com> (raw)
In-Reply-To: <20210715051819.3073628-6-penny.zheng@arm.com>
On 15.07.2021 07:18, Penny Zheng wrote:
> --- a/xen/common/page_alloc.c
> +++ b/xen/common/page_alloc.c
> @@ -1519,6 +1519,26 @@ static void free_heap_pages(
> spin_unlock(&heap_lock);
> }
>
> +#ifdef CONFIG_STATIC_MEMORY
> +/* Equivalent of free_heap_pages to free nr_mfns pages of static memory. */
> +void __init free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns,
> + bool need_scrub)
> +{
> + mfn_t mfn = page_to_mfn(pg);
> + unsigned long i;
> +
> + for ( i = 0; i < nr_mfns; i++ )
> + {
> + mark_page_free(&pg[i], mfn_add(mfn, i));
> +
> + if ( need_scrub )
> + {
> + /* TODO: asynchronous scrubbing for pages of static memory. */
> + scrub_one_page(pg);
> + }
> + }
> +}
> +#endif
Btw, I think the lack of locking warrants extending the comment above
the function, to spell out what the implications are (in particular:
calls here need to happen early enough).
Jan
next prev parent reply other threads:[~2021-07-19 8:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 5:18 [PATCH V3 00/10] Domain on Static Allocation Penny Zheng
2021-07-15 5:18 ` [PATCH V3 01/10] xen/arm: introduce domain " Penny Zheng
2021-07-15 5:18 ` [PATCH V3 02/10] xen/arm: introduce new helper device_tree_get_meminfo Penny Zheng
2021-07-15 5:18 ` [PATCH V3 03/10] xen/arm: handle static memory in dt_unreserved_regions Penny Zheng
2021-07-15 5:18 ` [PATCH V3 04/10] xen: introduce mark_page_free Penny Zheng
2021-07-19 8:13 ` Jan Beulich
2021-07-15 5:18 ` [PATCH V3 05/10] xen/arm: static memory initialization Penny Zheng
2021-07-19 8:20 ` Jan Beulich
2021-07-21 3:07 ` Penny Zheng
2021-07-21 8:15 ` Jan Beulich
2021-07-19 8:25 ` Jan Beulich [this message]
2021-07-15 5:18 ` [PATCH V3 06/10] xen/arm: introduce PGC_reserved Penny Zheng
2021-07-15 5:18 ` [PATCH V3 07/10] xen: re-define assign_pages and introduce assign_page Penny Zheng
2021-07-19 8:41 ` Jan Beulich
2021-07-21 5:53 ` Penny Zheng
2021-07-15 5:18 ` [PATCH V3 08/10] xen/arm: introduce acquire_staticmem_pages and acquire_domstatic_pages Penny Zheng
2021-07-19 9:26 ` Jan Beulich
2021-07-19 10:00 ` Julien Grall
2021-07-21 7:52 ` Penny Zheng
2021-07-21 7:37 ` Penny Zheng
2021-07-15 5:18 ` [PATCH V3 09/10] xen/arm: check "xen,static-mem" property during domain construction Penny Zheng
2021-07-15 5:18 ` [PATCH V3 10/10] xen/arm: introduce allocate_static_memory Penny Zheng
2021-07-27 3:44 ` Penny Zheng
2021-07-27 6:18 ` Penny Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2ef39b8-4bdd-6d50-0c6b-a44fdf0608e3@suse.com \
--to=jbeulich@suse.com \
--cc=Bertrand.Marquis@arm.com \
--cc=Wei.Chen@arm.com \
--cc=julien@xen.org \
--cc=nd@arm.com \
--cc=penny.zheng@arm.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).