sorry for the bad format from web email, and later review (neo training in new company)..    patch 6 -- patch 12, rename * patch,  are good to me.  Quan   ------------------------------------------------------------------From:Emil Condrea Time:2016 Jul 19 (Tue) 00:54To:Eric Blake Cc:qemu-devel ; Daniel De Graaf ; xen-devel ; Stefano Stabellini ; Quan Xu ; wei.liu2 ; stefanb ; anthony.perard Subject:Re: [Xen-devel] [PATCH 01/19] xen: Create a new file xen_pvdev.c Eric, this is the link to the original patch which is well formatted: http://marc.info/?l=xen-devel&m=146815138831762&w=2I think that the formatting and s-o-b was broken in the reply from Quan.On Jul 18, 2016 17:57, "Eric Blake" wrote: On 07/17/2016 01:41 AM, Quan Xu wrote: > > [Quan:]: comment starts with [Quan:] > This line doesn't belong in a commit message; it's fine to put it after the --- separator though, if it aids mailing list reviewers. > > The purpose of the new file is to store generic functions shared by frontendand backends such as xenstore operations, xendevs. > s/frontendand/front end and/ Please wrap your commit message lines.  Since 'git log' displays logs with indentation, wrapping around 72 characters is ideal. > Signed-off-by: Quan Xu > Signed-off-by: Emil Condrea These are not valid S-o-b, therefore this patch cannot be applied as-is. > -int xenstore_read_int(const char *base, const char *node, int *ival) > -{ > -    char *val; > -    int rc = -1; > - > -    val = xenstore_read_str(base, node); > [Quan:]:  IMO, it is better to initialize val when declares.  the same comment for the other 'val' > -    if (val && 1 == sscanf(val, "%d", ival)) { This is not a valid patch.  Are you replying to a patch that someone else posted? If so, your quoting style is VERY difficult to read. Please consider using a leading > before every line that you are quoting (rather than pasting it verbatim as if you had written it), and include a blank line both before and after every line that you insert, to call visual attention to what is your reply vs. what you are quoting. -- Eric Blake   eblake redhat com    +1-919-301-3266 Libvirt virtualization library http://libvirt.org