xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] xen: sched: use default scheduler upon an invalid "sched="
@ 2016-06-17 10:31 Dario Faggioli
  2016-06-17 10:55 ` Andrew Cooper
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Dario Faggioli @ 2016-06-17 10:31 UTC (permalink / raw)
  To: xen-devel; +Cc: George Dunlap, Jonathan Creekmore, Doug Goldstein, Jan Beulich

instead of just the first scheduler we find in the array.

In fact, right now, if someone makes a typo when passing
the "sched=" command line option to Xen, we (with all
schedulers configured in) pick ARINC653, which is most
likely not what one would expect.

Go for the default scheduler instead.

Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
---
Cc: George Dunlap <george.dunlap@eu.citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Doug Goldstein <cardoe@cardoe.com>
Cc: Jonathan Creekmore <jonathan.creekmore@gmail.com>
---
I don't think I'm going to ask for this to be put in 4.7,
as I don't want to give Wei an heart attack... :-)

Considering it for backporting should be enough, IMO.
---
 xen/common/schedule.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/xen/common/schedule.c b/xen/common/schedule.c
index 5e35310..7ac12d3 100644
--- a/xen/common/schedule.c
+++ b/xen/common/schedule.c
@@ -1625,7 +1625,8 @@ void __init scheduler_init(void)
     {
         printk("Could not find scheduler: %s\n", opt_sched);
         for ( i = 0; i < NUM_SCHEDULERS; i++ )
-            if ( schedulers[i] )
+            if ( schedulers[i] &&
+                 !strcmp(schedulers[i]->opt_name, CONFIG_SCHED_DEFAULT) )
             {
                 ops = *schedulers[i];
                 break;


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-06-17 14:27 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-17 10:31 [PATCH] xen: sched: use default scheduler upon an invalid "sched=" Dario Faggioli
2016-06-17 10:55 ` Andrew Cooper
2016-06-17 13:42 ` Jonathan Creekmore
2016-06-17 14:06 ` George Dunlap
2016-06-17 14:07 ` Doug Goldstein
2016-06-17 14:27 ` Wei Liu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).