From: Jan Beulich <jbeulich@suse.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org,
Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
paul@xen.org
Subject: Re: [PATCH for-4.14 v2 1/2] x86/passthrough: do not assert edge triggered GSIs for PVH dom0
Date: Tue, 16 Jun 2020 08:11:12 +0200 [thread overview]
Message-ID: <b3bd8641-4cf9-d432-145a-d19bb852ffdc@suse.com> (raw)
In-Reply-To: <20200610142923.9074-2-roger.pau@citrix.com>
On 10.06.2020 16:29, Roger Pau Monne wrote:
> @@ -186,9 +187,10 @@ void hvm_gsi_assert(struct domain *d, unsigned int gsi)
> * to know if the GSI is pending or not.
> */
> spin_lock(&d->arch.hvm.irq_lock);
> - if ( !hvm_irq->gsi_assert_count[gsi] )
> + if ( trig == VIOAPIC_EDGE_TRIG || !hvm_irq->gsi_assert_count[gsi] )
> {
> - hvm_irq->gsi_assert_count[gsi] = 1;
> + if ( trig == VIOAPIC_LEVEL_TRIG )
> + hvm_irq->gsi_assert_count[gsi] = 1;
Btw, along the lines of how you do things here, I think ...
> @@ -196,11 +198,12 @@ void hvm_gsi_assert(struct domain *d, unsigned int gsi)
>
> void hvm_gsi_deassert(struct domain *d, unsigned int gsi)
> {
> + int trig = vioapic_get_trigger_mode(d, gsi);
> struct hvm_irq *hvm_irq = hvm_domain_irq(d);
>
> - if ( gsi >= hvm_irq->nr_gsis )
> + if ( trig <= VIOAPIC_EDGE_TRIG || gsi >= hvm_irq->nr_gsis )
... this would better have been "trig != VIOAPIC_LEVEL_TRIG", to
avoid the code being dependent upon the actual values of both
VIOAPIC_*_TRIG constants.
Jan
> - ASSERT_UNREACHABLE();
> + ASSERT(trig == VIOAPIC_EDGE_TRIG && gsi < hvm_irq->nr_gsis);
> return;
> }
>
>
next prev parent reply other threads:[~2020-06-16 6:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 14:29 [PATCH for-4.14 v2 0/2] x86/passthrough: fixes for PVH dom0 edge triggered interrupts Roger Pau Monne
2020-06-10 14:29 ` [PATCH for-4.14 v2 1/2] x86/passthrough: do not assert edge triggered GSIs for PVH dom0 Roger Pau Monne
2020-06-10 14:49 ` Paul Durrant
2020-06-16 6:11 ` Jan Beulich [this message]
2020-06-16 8:20 ` Roger Pau Monné
2020-06-10 14:29 ` [PATCH for-4.14 v2 2/2] x86/passthrough: introduce a flag for GSIs not requiring an EOI or unmask Roger Pau Monne
2020-06-11 16:26 ` Andrew Cooper
2020-06-11 17:11 ` Paul Durrant
2020-06-15 16:17 ` Jan Beulich
2020-06-15 17:07 ` Paul Durrant
2020-06-15 17:06 ` Paul Durrant
2020-06-16 6:27 ` Jan Beulich
2020-06-16 8:37 ` Roger Pau Monné
2020-06-16 8:45 ` Jan Beulich
2020-06-16 9:28 ` Roger Pau Monné
2020-06-26 10:44 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3bd8641-4cf9-d432-145a-d19bb852ffdc@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=paul@xen.org \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).