From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
Ian Jackson <iwj@xenproject.org>, Julien Grall <julien@xen.org>,
Wei Liu <wl@xen.org>, Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH 8/9] lib: move bsearch code
Date: Tue, 22 Sep 2020 20:34:38 +0100 [thread overview]
Message-ID: <b40bd4a7-b1fb-b2a0-44d1-398f533469a0@citrix.com> (raw)
In-Reply-To: <13e17bbd-4e58-d953-87c5-5fabafa21de2@suse.com>
On 14/09/2020 11:18, Jan Beulich wrote:
> Build this code into an archive, which results in not linking it into
> x86 final binaries. This saves a little bit of dead code.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
This wants to be an extern inline in the header file just like in stdlib.h.
The implementation is trivial, and much faster when the compiler can
inline the cmp() function pointer.
I doubt we actually need out-of-line implementation (except perhaps for
CONFIG_UBSAN builds or so).
~Andrew
next prev parent reply other threads:[~2020-09-22 19:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 10:12 [PATCH 0/9] xen: beginnings of moving library-like code into an archive Jan Beulich
2020-09-14 10:15 ` [PATCH 1/9] build: use if_changed more consistently (and correctly) for prelink*.o Jan Beulich
2020-09-15 11:56 ` Roger Pau Monné
2020-09-15 12:26 ` Jan Beulich
2020-09-15 13:46 ` Roger Pau Monné
2020-09-15 15:14 ` Jan Beulich
2020-09-21 10:17 ` Ping: " Jan Beulich
2020-09-21 11:39 ` Julien Grall
2020-09-22 8:28 ` Jan Beulich
2020-09-22 9:24 ` Julien Grall
2020-09-22 10:55 ` Jan Beulich
2020-09-22 11:47 ` Julien Grall
2020-09-22 17:40 ` Stefano Stabellini
2020-09-14 10:16 ` [PATCH 2/9] lib: split _ctype[] into its own object, under lib/ Jan Beulich
2020-09-14 10:16 ` [PATCH 3/9] lib: collect library files in an archive Jan Beulich
2020-09-14 10:16 ` [PATCH 4/9] lib: move list sorting code Jan Beulich
2020-09-14 10:17 ` [PATCH 5/9] lib: move parse_size_and_unit() Jan Beulich
2020-09-22 19:41 ` Andrew Cooper
2020-09-24 7:04 ` Jan Beulich
2020-09-14 10:17 ` [PATCH 6/9] lib: move init_constructors() Jan Beulich
2020-09-14 10:18 ` [PATCH 7/9] lib: move rbtree code Jan Beulich
2020-09-14 10:18 ` [PATCH 8/9] lib: move bsearch code Jan Beulich
2020-09-22 19:34 ` Andrew Cooper [this message]
2020-09-24 7:09 ` Jan Beulich
2020-09-14 10:18 ` [PATCH 9/9] lib: move sort code Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b40bd4a7-b1fb-b2a0-44d1-398f533469a0@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=iwj@xenproject.org \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).