From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E90F8C433B4 for ; Wed, 31 Mar 2021 16:03:19 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A116561005 for ; Wed, 31 Mar 2021 16:03:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A116561005 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.104007.198451 (Exim 4.92) (envelope-from ) id 1lRdJ2-0003Xj-1Q; Wed, 31 Mar 2021 16:02:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104007.198451; Wed, 31 Mar 2021 16:02:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRdJ1-0003Xc-UY; Wed, 31 Mar 2021 16:02:55 +0000 Received: by outflank-mailman (input) for mailman id 104007; Wed, 31 Mar 2021 16:02:54 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRdJ0-0003XX-Jn for xen-devel@lists.xenproject.org; Wed, 31 Mar 2021 16:02:54 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 278084ea-551e-40be-a0f3-adf6d70b4ae5; Wed, 31 Mar 2021 16:02:53 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 33513B308; Wed, 31 Mar 2021 16:02:52 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 278084ea-551e-40be-a0f3-adf6d70b4ae5 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617206572; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vNXTuZMlTjXJX8GnpQtGtCjAvrIWn1Bn/qb+aaARyYA=; b=J1rt22ZtQLuwbM/rLEqNS7HmtAI7d8sx4TjkzuI34KO9CQtB/c9KZGOUsnz/LsPe2Wolt/ FRJa8Gs7xkeJhhYmZic87lMD/PfUqo57ERERmTefuoA9s8o1wHe9EzrIPTVP0aPN8zXcCg a0daBWHeBkpe7ZMPXbBftwz/tGjzxRI= Subject: Re: [PATCH v3 01/11] x86/hvm: drop vcpu parameter from vlapic EOI callbacks To: Roger Pau Monne Cc: Andrew Cooper , Wei Liu , Paul Durrant , Paul Durrant , xen-devel@lists.xenproject.org References: <20210331103303.79705-1-roger.pau@citrix.com> <20210331103303.79705-2-roger.pau@citrix.com> From: Jan Beulich Message-ID: Date: Wed, 31 Mar 2021 18:02:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210331103303.79705-2-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 31.03.2021 12:32, Roger Pau Monne wrote: > EOIs are always executed in guest vCPU context, so there's no reason to > pass a vCPU parameter around as can be fetched from current. > > While there make the vector parameter of both callbacks unsigned int. > > No functional change intended. > > Suggested-by: Paul Durrant > Signed-off-by: Roger Pau Monné > Reviewed-by: Paul Durrant > --- > Changes since v1: > - New in this version. I'm afraid the situation with viridian_synic_wrmsr() hasn't changed since v2, and hence my previous comment still applies. Jan