From: Bob Eshleman <bobbyeshleman@gmail.com>
To: Jan Beulich <jbeulich@suse.com>,
Bobby Eshleman <bobby.eshleman@gmail.com>
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
"Julien Grall" <julien@xen.org>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"George Dunlap" <george.dunlap@citrix.com>,
"Ian Jackson" <iwj@xenproject.org>, "Wei Liu" <wl@xen.org>,
"Elena Ufimtseva" <elena.ufimtseva@oracle.com>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Jun Nakajima" <jun.nakajima@intel.com>,
"Kevin Tian" <kevin.tian@intel.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH 1/4] build: use common stubs for debugger_trap_* functions if !CONFIG_CRASH_DEBUG
Date: Wed, 14 Jul 2021 14:03:17 -0700 [thread overview]
Message-ID: <b6124fdd-b8da-b924-bf6f-1df6456f5926@gmail.com> (raw)
In-Reply-To: <7468d092-42c5-34a1-74ec-7500e1bc7bf1@suse.com>
On 7/14/21 2:34 AM, Jan Beulich wrote:
>
> ... we strive to have new insertions be sorted alphabetically. When
> the existing section to insert into isn't suitably sorted yet, what
> I normally do is try to find a place where at least the immediately
> adjacent neighbors then fit the sorting goal.
>
> Sorry, all just nits, but their scope is about the entire patch.
>
No worries at all, I welcome the corrections (I need to learn the
proper style somehow).
>> --- /dev/null
>> +++ b/xen/include/xen/debugger.h
...
>> +
>> +static inline bool debugger_trap_fatal(
>> + unsigned int vector, const struct cpu_user_regs *regs)
>
> I'm afraid the concept of a vector may not be arch-independent.
>
The only way I can imagine it not being arch-independent
is if it is thought of as a trap number or id, instead of
implying an entry in a vectored trap table. I don't
really understand this subsystem, so I'm probably missing
context.
Are you suggesting a rename or a different approach entirely?
>
> Jan
>
Thanks Jan, everything besides the vector thing are incorporated in
the v2 I've just sent out.
--
Bobby Eshleman
SE at Vates SAS
next prev parent reply other threads:[~2021-07-14 21:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1626136452.git.bobby.eshleman@gmail.com>
2021-07-13 1:59 ` [PATCH 1/4] build: use common stubs for debugger_trap_* functions if !CONFIG_CRASH_DEBUG Bobby Eshleman
2021-07-14 9:34 ` Jan Beulich
2021-07-14 21:03 ` Bob Eshleman [this message]
2021-07-15 6:45 ` Jan Beulich
2021-07-13 1:59 ` [PATCH 2/4] arm/traps: remove debugger_trap_fatal() calls Bobby Eshleman
2021-07-13 1:59 ` [PATCH 3/4] x86/debug: move debugger_trap_entry into debugger.c not inlined Bobby Eshleman
2021-07-14 9:52 ` Jan Beulich
2021-07-13 1:59 ` [PATCH 4/4] x86/debug: move domain_pause_for_debugger to debugger.c Bobby Eshleman
2021-07-14 9:55 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6124fdd-b8da-b924-bf6f-1df6456f5926@gmail.com \
--to=bobbyeshleman@gmail.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=bobby.eshleman@gmail.com \
--cc=elena.ufimtseva@oracle.com \
--cc=george.dunlap@citrix.com \
--cc=iwj@xenproject.org \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).