From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BBB4C433DB for ; Thu, 21 Jan 2021 11:13:58 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A57823877 for ; Thu, 21 Jan 2021 11:13:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A57823877 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.72007.129386 (Exim 4.92) (envelope-from ) id 1l2XuJ-0003WD-0Y; Thu, 21 Jan 2021 11:13:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 72007.129386; Thu, 21 Jan 2021 11:13:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l2XuI-0003W6-Tf; Thu, 21 Jan 2021 11:13:42 +0000 Received: by outflank-mailman (input) for mailman id 72007; Thu, 21 Jan 2021 11:13:41 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l2XuH-0003W1-1y for xen-devel@lists.xenproject.org; Thu, 21 Jan 2021 11:13:41 +0000 Received: from mail-lf1-x12a.google.com (unknown [2a00:1450:4864:20::12a]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e49d076f-af15-486f-966f-ffbd630dac3c; Thu, 21 Jan 2021 11:13:40 +0000 (UTC) Received: by mail-lf1-x12a.google.com with SMTP id v67so1989734lfa.0 for ; Thu, 21 Jan 2021 03:13:40 -0800 (PST) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id n13sm539583ljj.70.2021.01.21.03.13.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Jan 2021 03:13:36 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e49d076f-af15-486f-966f-ffbd630dac3c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=yd+jxwtgXAOrWcJ7l/4fkyQe22m6DudleYEINdkDtkA=; b=jbzIUeXrVLp49GcsbD7gY2fdkCx2Dll1XkvANInmhF/ebJZfcrM80DysguQsjpCz3N v83jjUVDLltDU7gK6q6i63xwdUhZsyYu2G4Li+t60AwjyiVqXbNrx89y60NRh77GFbBZ dfJhn1WFeVov5zTqs88zMz7WzXTGewZqwkQ13bssuvl6PXItj/JK9oqkA5ekkuDjQK5d jNOxSSQcOG7qbM3fbQT0SKfDpmBYiVVEIp9OimCUrsgS/JYA5ns2ezNGP9PMKMjlmUiR 79KO+hZsO9oZn/IVgqLNPr0nfP1LBDbmIhpf1KdO4M4lhrEnjqZx1fNJR5ThKB10L6gk 40zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=yd+jxwtgXAOrWcJ7l/4fkyQe22m6DudleYEINdkDtkA=; b=iflOMI+MBP/X0rRvx9CU4IsMafryZxAnmtfs0I/fBVllyVwSAA9gFRc2IFxSzm9Np9 yp7n5C6ucltDCBQ2xaqKkFtk5SkZd3dKcj2weahhcrXxEsCdYk0bH3TUdpEHeQA4Z162 t2MUC74GNZwF4h8xR3G7IBiXKFDxeA5j5aUqPyF8S6Sdd8tlgjHMQIe1VXN7m3U6183r CcssAH4eAyYGsiKfO8NG8Y3K5tRZRQQTpkY4DCCe8MDJWdFdWMACJuZvzsnQgrzlsBrJ 0SjxwASba7puJy1yAYW7niSFQR2QS1MY1bmQERx3eu8Wd6jpOfB7+9YlM59bIMV2ACqQ mZAg== X-Gm-Message-State: AOAM531uNNI9/OMcgo+j1tyAt9sr9fgziomVOBv4YIL+Y9BdEGkX/AwW yow5EdbFqiX2cJgwWLurXyuBrZhEvScNdg== X-Google-Smtp-Source: ABdhPJxgG95YHomEqovbZLxFvB3Xai648hCzudltxMwK7A3afLrYZrZjB366nxv43bigisJfea3/fw== X-Received: by 2002:ac2:420a:: with SMTP id y10mr6151492lfh.377.1611227618847; Thu, 21 Jan 2021 03:13:38 -0800 (PST) Subject: Re: [PATCH V4 09/24] xen/ioreq: Make x86's IOREQ related dm-op handling common To: Jan Beulich Cc: Julien Grall , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Paul Durrant , Daniel De Graaf , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org References: <1610488352-18494-1-git-send-email-olekstysh@gmail.com> <1610488352-18494-10-git-send-email-olekstysh@gmail.com> <016657f8-371f-eba6-60ce-29741f0823b7@suse.com> <832cbb2f-a3dd-c97d-b35a-951fed63ad2b@gmail.com> From: Oleksandr Message-ID: Date: Thu, 21 Jan 2021 13:13:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US On 21.01.21 12:27, Jan Beulich wrote: Hi Jan > On 21.01.2021 11:23, Oleksandr wrote: >> I would like to clarify regarding do_dm_op() which is identical for both >> arches and could *probably* be moved to the common code (we can return >> common dm.c back to put it there) and make dm_op() global. >> Would you/Paul be happy with that change? Or there are some reasons >> (which we are not aware of yet) for not doing it this way? > Probably reasonable to do; the only reason not to that I > could see is that then dm_op() has to become non-static. Thank you for the clarification. So I will make this change for V5 if no objections during these days. I am going to leave your ack, please let me know if you think otherwise. -- Regards, Oleksandr Tyshchenko