From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E85DC4338F for ; Mon, 23 Aug 2021 17:54:37 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 46BEF604DB for ; Mon, 23 Aug 2021 17:54:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 46BEF604DB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.170568.311394 (Exim 4.92) (envelope-from ) id 1mIE9T-000325-Cv; Mon, 23 Aug 2021 17:54:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 170568.311394; Mon, 23 Aug 2021 17:54:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mIE9T-00031y-9z; Mon, 23 Aug 2021 17:54:27 +0000 Received: by outflank-mailman (input) for mailman id 170568; Mon, 23 Aug 2021 17:54:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mIE9S-00031q-CW for xen-devel@lists.xenproject.org; Mon, 23 Aug 2021 17:54:26 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mIE9R-0008VD-HE; Mon, 23 Aug 2021 17:54:25 +0000 Received: from [54.239.6.188] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mIE9R-0000qX-B4; Mon, 23 Aug 2021 17:54:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=O06dRWBbO4b6yN+EtUVjNvTlsNpspPTofeRcxSNCFWE=; b=fc0Xe8ZPEmNLazj6z0c1VmlDDR PbpBVv5ig7umNK7LGelOAR5rTzr2XrrBO4hY/UsgU65s+94Np/o+CsmMWF41DNLrqgg8eqV50J7nE 3s37mUEZjmNHPJ5czhCibMyIOX88SXjWyNrCfLZ+6cUZrSazDjPy2qephQshDOPZTyy8=; Subject: Re: [XEN RFC PATCH 09/40] xen/x86: Move numa_add_cpu_node to common To: Wei Chen , xen-devel@lists.xenproject.org, sstabellini@kernel.org, jbeulich@suse.com Cc: Bertrand.Marquis@arm.com References: <20210811102423.28908-1-wei.chen@arm.com> <20210811102423.28908-10-wei.chen@arm.com> From: Julien Grall Message-ID: Date: Mon, 23 Aug 2021 18:54:23 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210811102423.28908-10-wei.chen@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Wei, On 11/08/2021 11:23, Wei Chen wrote: > This function will be reused by Arm later, so we move it > from arch/x86 to common. But we keep cpu_to_node and > node_to_cpumask to x86 header file. Because cpu_to_node and > node_to_cpumask have different implementation for x86 and Arm. > We will move them to common header file when we change the Arm > implementation in later patches. AFAICT, the Arm helpers are gated by !CONFIG_NUMA and the ones in common code will be gated by CONFIG_NUMA. So I am not quite too understand why they can't be moved now. Can you clarify it? Cheers, -- Julien Grall