From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2999C43603 for ; Wed, 4 Dec 2019 10:06:35 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C318320675 for ; Wed, 4 Dec 2019 10:06:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C318320675 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1icRXw-0006Q6-HP; Wed, 04 Dec 2019 10:06:12 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1icRXv-0006Q1-Jj for xen-devel@lists.xenproject.org; Wed, 04 Dec 2019 10:06:11 +0000 X-Inumbo-ID: b1812e88-167d-11ea-81ff-12813bfff9fa Received: from mx1.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b1812e88-167d-11ea-81ff-12813bfff9fa; Wed, 04 Dec 2019 10:06:09 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 8C9C1AD19; Wed, 4 Dec 2019 10:06:08 +0000 (UTC) To: Andrew Cooper References: <20191204094335.24603-1-andrew.cooper3@citrix.com> <20191204094335.24603-2-andrew.cooper3@citrix.com> From: Jan Beulich Message-ID: Date: Wed, 4 Dec 2019 11:06:21 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <20191204094335.24603-2-andrew.cooper3@citrix.com> Content-Language: en-US Subject: Re: [Xen-devel] [PATCH 1/4] x86/svm: Clean up construct_vmcb() X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Xen-devel , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" T24gMDQuMTIuMjAxOSAxMDo0MywgQW5kcmV3IENvb3BlciB3cm90ZToKPiBUaGUgdm1jYiBpcyB6 ZXJvZWQgb24gYWxsb2NhdGUgLSBkcm9wIGFsbCBleHBsaWNpdCB3cml0ZXMgb2YgMC4gIE1vdmUK PiBodm1fdXBkYXRlX2d1ZXN0X2VmZXIoKSB0byBjby1sb2NhdGUgaXQgd2l0aCB0aGUgb3RoZXIg Y29udHJvbCByZWdpc3Rlcgo+IHVwZGF0ZXMuCj4gCj4gTW92ZSB0aGUgQlVJTERfQlVHX09OKCkg aW50byBidWlsZF9hc3NlcnRpb25zKCksIGFuZCBhZGQgc29tZSBvZmZzZXQgY2hlY2tzCj4gZm9y IGZpZWxkcyBhZnRlciB0aGUgbGFyZ2UgYmxvY2tzIG9mIHJlc2VydmVkIGZpZWxkcyAoYXMgdGhl c2UgYXJlIHRoZSBtb3N0Cj4gbGlrZWx5IHRvIHRyaWdnZXIgZnJvbSBhIG1pcy1lZGl0KS4gIFRh a2UgdGhlIG9wcG9ydHVuaXR5IHRvIGZvbGQgNiBhZGphY2VudAo+IHJlcyogZmllbGRzIGludG8g b25lLgo+IAo+IEZpbmFsbHksIGRyb3AgYWxsIHRyYWlsaW5nIHdoaXRlc3BhY2UgaW4gdGhlIGZp bGUuCj4gCj4gU2lnbmVkLW9mZi1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0 cml4LmNvbT4KClJldmlld2VkLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+CmFs YmVpdCB3aXRoIHR3byAob3B0aW9uYWwpIHN1Z2dlc3Rpb25zOgoKPiBAQCAtMjk3LDE0ICsyNTgs MjYgQEAgdm9pZCBfX2luaXQgc2V0dXBfdm1jYl9kdW1wKHZvaWQpCj4gIAo+ICBzdGF0aWMgdm9p ZCBfX2luaXQgX19tYXliZV91bnVzZWQgYnVpbGRfYXNzZXJ0aW9ucyh2b2lkKQo+ICB7Cj4gLSAg ICBzdHJ1Y3Qgc2VnbWVudF9yZWdpc3RlciBzcmVnOwo+ICsgICAgc3RydWN0IHZtY2Jfc3RydWN0 IHZtY2I7Cj4gKwo+ICsgICAgLyogQnVpbGQtdGltZSBjaGVjayBvZiB0aGUgVk1DQiBsYXlvdXQu ICovCj4gKyAgICBCVUlMRF9CVUdfT04oc2l6ZW9mKHZtY2IpICE9IFBBR0VfU0laRSk7Cj4gKyAg ICBCVUlMRF9CVUdfT04ob2Zmc2V0b2Yoc3RydWN0IHZtY2Jfc3RydWN0LCBfcGF1c2VfZmlsdGVy X3RocmVzaCkgIT0gMHgwM2MpOwo+ICsgICAgQlVJTERfQlVHX09OKG9mZnNldG9mKHN0cnVjdCB2 bWNiX3N0cnVjdCwgX3ZpbnRyKSAgICAgICAgICAgICAgICE9IDB4MDYwKTsKPiArICAgIEJVSUxE X0JVR19PTihvZmZzZXRvZihzdHJ1Y3Qgdm1jYl9zdHJ1Y3QsIGV2ZW50aW5qKSAgICAgICAgICAg ICAhPSAweDBhOCk7Cj4gKyAgICBCVUlMRF9CVUdfT04ob2Zmc2V0b2Yoc3RydWN0IHZtY2Jfc3Ry dWN0LCBlcykgICAgICAgICAgICAgICAgICAgIT0gMHg0MDApOwo+ICsgICAgQlVJTERfQlVHX09O KG9mZnNldG9mKHN0cnVjdCB2bWNiX3N0cnVjdCwgX2NwbCkgICAgICAgICAgICAgICAgICE9IDB4 NGNiKTsKPiArICAgIEJVSUxEX0JVR19PTihvZmZzZXRvZihzdHJ1Y3Qgdm1jYl9zdHJ1Y3QsIF9j cjQpICAgICAgICAgICAgICAgICAhPSAweDU0OCk7Cj4gKyAgICBCVUlMRF9CVUdfT04ob2Zmc2V0 b2Yoc3RydWN0IHZtY2Jfc3RydWN0LCByc3ApICAgICAgICAgICAgICAgICAgIT0gMHg1ZDgpOwo+ ICsgICAgQlVJTERfQlVHX09OKG9mZnNldG9mKHN0cnVjdCB2bWNiX3N0cnVjdCwgcmF4KSAgICAg ICAgICAgICAgICAgICE9IDB4NWY4KTsKPiArICAgIEJVSUxEX0JVR19PTihvZmZzZXRvZihzdHJ1 Y3Qgdm1jYl9zdHJ1Y3QsIF9nX3BhdCkgICAgICAgICAgICAgICAhPSAweDY2OCk7Cj4gIAo+ICAg ICAgLyogQ2hlY2sgc3RydWN0IHNlZ21lbnRfcmVnaXN0ZXIgYWdhaW5zdCB0aGUgVk1DQiBzZWdt ZW50IGxheW91dC4gKi8KPiAtICAgIEJVSUxEX0JVR19PTihzaXplb2Yoc3JlZykgICAgICAgIT0g MTYpOwo+IC0gICAgQlVJTERfQlVHX09OKHNpemVvZihzcmVnLnNlbCkgICAhPSAyKTsKPiAtICAg IEJVSUxEX0JVR19PTihzaXplb2Yoc3JlZy5hdHRyKSAgIT0gMik7Cj4gLSAgICBCVUlMRF9CVUdf T04oc2l6ZW9mKHNyZWcubGltaXQpICE9IDQpOwo+IC0gICAgQlVJTERfQlVHX09OKHNpemVvZihz cmVnLmJhc2UpICAhPSA4KTsKPiArICAgIEJVSUxEX0JVR19PTihzaXplb2Yodm1jYi5lcykgICAg ICAgIT0gMTYpOwo+ICsgICAgQlVJTERfQlVHX09OKHNpemVvZih2bWNiLmVzLnNlbCkgICAhPSAy KTsKPiArICAgIEJVSUxEX0JVR19PTihzaXplb2Yodm1jYi5lcy5hdHRyKSAgIT0gMik7Cj4gKyAg ICBCVUlMRF9CVUdfT04oc2l6ZW9mKHZtY2IuZXMubGltaXQpICE9IDQpOwo+ICsgICAgQlVJTERf QlVHX09OKHNpemVvZih2bWNiLmVzLmJhc2UpICAhPSA4KTsKPiAgICAgIEJVSUxEX0JVR19PTihv ZmZzZXRvZihzdHJ1Y3Qgc2VnbWVudF9yZWdpc3Rlciwgc2VsKSAgICE9IDApOwo+ICAgICAgQlVJ TERfQlVHX09OKG9mZnNldG9mKHN0cnVjdCBzZWdtZW50X3JlZ2lzdGVyLCBhdHRyKSAgIT0gMik7 Cj4gICAgICBCVUlMRF9CVUdfT04ob2Zmc2V0b2Yoc3RydWN0IHNlZ21lbnRfcmVnaXN0ZXIsIGxp bWl0KSAhPSA0KTsKCkZvciB0aGUgb25lcyBvbmx5IHN1cHBseWluZyBjb250ZXh0IGhlcmUsIGhv dyBhYm91dCB1c2luZyB0aGUKc2hvcnRlciBvZmZzZXRvZih0eXBlb2Yodm1jYi5lcyksIC4uLiks IGFsc28gdHlpbmcgdGhpbmdzIGJldHRlcgp0byB0aGUgcHJpb3Igc2l6ZW9mKCkgY2hlY2tzPyBU aGUgc2FtZSwgYWxiZWl0IHRvIGEgbGVzc2VyIGRlZ3JlZSwKbWlnaHQgdGhlbiBnbyBmb3IgdGhl IGVhcmxpZXIgYmxvY2ssIHdoaWNoIGNvdWxkIHVzZSB0aGUgc2hvcnRlcgp0eXBlb2Yodm1jYiku Cgo+IC0tLSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvaHZtL3N2bS92bWNiLmgKPiArKysgYi94ZW4v aW5jbHVkZS9hc20teDg2L2h2bS9zdm0vdm1jYi5oCj4gQEAgLTQwNiwxMiArNDA2LDcgQEAgc3Ry dWN0IHZtY2Jfc3RydWN0IHsKPiAgICAgIHUzMiBfZXhjZXB0aW9uX2ludGVyY2VwdHM7ICAvKiBv ZmZzZXQgMHgwOCAtIGNsZWFuYml0IDAgKi8KPiAgICAgIHUzMiBfZ2VuZXJhbDFfaW50ZXJjZXB0 czsgICAvKiBvZmZzZXQgMHgwQyAtIGNsZWFuYml0IDAgKi8KPiAgICAgIHUzMiBfZ2VuZXJhbDJf aW50ZXJjZXB0czsgICAvKiBvZmZzZXQgMHgxMCAtIGNsZWFuYml0IDAgKi8KPiAtICAgIHUzMiBy ZXMwMTsgICAgICAgICAgICAgICAgICAvKiBvZmZzZXQgMHgxNCAqLwo+IC0gICAgdTY0IHJlczAy OyAgICAgICAgICAgICAgICAgIC8qIG9mZnNldCAweDE4ICovCj4gLSAgICB1NjQgcmVzMDM7ICAg ICAgICAgICAgICAgICAgLyogb2Zmc2V0IDB4MjAgKi8KPiAtICAgIHU2NCByZXMwNDsgICAgICAg ICAgICAgICAgICAvKiBvZmZzZXQgMHgyOCAqLwo+IC0gICAgdTY0IHJlczA1OyAgICAgICAgICAg ICAgICAgIC8qIG9mZnNldCAweDMwICovCj4gLSAgICB1MzIgcmVzMDY7ICAgICAgICAgICAgICAg ICAgLyogb2Zmc2V0IDB4MzggKi8KPiArICAgIHUzMiByZXMwMVsxMF07CgpXYXMgaXQgaW50ZW50 aW9uYWwgZm9yIHRoZSBjb21tZW50IHRvIGJlIGxvc3QgYWx0b2dldGhlcj8KCkphbgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxp bmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5w cm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==