From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4201C43331 for ; Fri, 27 Mar 2020 10:53:28 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 97AC420578 for ; Fri, 27 Mar 2020 10:53:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 97AC420578 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jHmbn-0006JR-81; Fri, 27 Mar 2020 10:53:03 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jHmbm-0006JM-3s for xen-devel@lists.xenproject.org; Fri, 27 Mar 2020 10:53:02 +0000 X-Inumbo-ID: 207870ae-7019-11ea-b34e-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 207870ae-7019-11ea-b34e-bc764e2007e4; Fri, 27 Mar 2020 10:53:01 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 74321AF55; Fri, 27 Mar 2020 10:53:00 +0000 (UTC) To: julien@xen.org References: <20200322161418.31606-1-julien@xen.org> <20200322161418.31606-10-julien@xen.org> From: Jan Beulich Message-ID: Date: Fri, 27 Mar 2020 11:52:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200322161418.31606-10-julien@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Xen-devel] [PATCH 09/17] xen/x86: Reduce the number of use of l*e_{from, get}_pfn() X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Andrew Cooper Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 22.03.2020 17:14, julien@xen.org wrote: > --- a/xen/arch/x86/mm.c > +++ b/xen/arch/x86/mm.c > @@ -1138,7 +1138,7 @@ static int > get_page_from_l2e( > l2_pgentry_t l2e, mfn_t l2mfn, struct domain *d, unsigned int flags) > { > - unsigned long mfn = l2e_get_pfn(l2e); > + mfn_t mfn = l2e_get_mfn(l2e); > int rc; > > if ( unlikely((l2e_get_flags(l2e) & L2_DISALLOW_MASK)) ) > @@ -1150,7 +1150,7 @@ get_page_from_l2e( > > ASSERT(!(flags & PTF_preemptible)); > > - rc = get_page_and_type_from_mfn(_mfn(mfn), PGT_l1_page_table, d, flags); > + rc = get_page_and_type_from_mfn(mfn, PGT_l1_page_table, d, flags); To bring this better in line with the L3 and L4 counterparts, could you please drop the local variable instead? Then Reviewed-by: Jan Beulich Jan