From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2459C433EF for ; Tue, 14 Dec 2021 17:06:08 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.246946.425906 (Exim 4.92) (envelope-from ) id 1mxBFQ-0005Hu-MJ; Tue, 14 Dec 2021 17:05:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 246946.425906; Tue, 14 Dec 2021 17:05:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mxBFQ-0005Hn-JR; Tue, 14 Dec 2021 17:05:52 +0000 Received: by outflank-mailman (input) for mailman id 246946; Tue, 14 Dec 2021 17:05:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mxBFO-0005HZ-Ko for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 17:05:50 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mxBFN-0004bo-Cd; Tue, 14 Dec 2021 17:05:49 +0000 Received: from [54.239.6.190] (helo=[192.168.26.72]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mxBFN-0004ZE-5z; Tue, 14 Dec 2021 17:05:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=+lIwA4ZRTVSYc1f5arQHlKa8htLLoqiCznblSSNKg6Y=; b=ndlW8Xqi0trp/BGMJWe+aNZOPh JhJs7FWe6jKCBuiPkmVMiCKCdiEO5x2fjK3OovqeTN7OiteNCtnqYF6JeOb/j0XVwFbgGBiz7tWO7 GZBCrq/zk1lNuichKUt7d23yB8e3QppAAZupcPXhqoObH2pOkT5sALHDgwMsLFX7jTlg=; Message-ID: Date: Tue, 14 Dec 2021 17:05:46 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [XEN PATCH v8 14/47] build: rename __LINKER__ to LINKER_SCRIPT To: Anthony PERARD , xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , Volodymyr Babchuk , Bertrand Marquis References: <20211125134006.1076646-1-anthony.perard@citrix.com> <20211125134006.1076646-15-anthony.perard@citrix.com> From: Julien Grall In-Reply-To: <20211125134006.1076646-15-anthony.perard@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Anthony, On 25/11/2021 13:39, Anthony PERARD wrote: > For two reasons: this macro is used to generate a "linker script" and > is not by the linker, and name starting with an underscore '_' are > supposed to be reserved, so better avoid them when not needed. If that's the case, then shouldn't we also rename __ASSEMBLY__? > > Signed-off-by: Anthony PERARD > Reviewed-by: Jan Beulich Acked-by: Julien Grall Cheers, > --- > xen/Rules.mk | 2 +- > xen/arch/arm/include/asm/config.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/xen/Rules.mk b/xen/Rules.mk > index 4624739ca7e2..d32fec0ae037 100644 > --- a/xen/Rules.mk > +++ b/xen/Rules.mk > @@ -256,7 +256,7 @@ $(obj)/%.s: $(src)/%.S FORCE > > # Linker scripts, .lds.S -> .lds > quiet_cmd_cpp_lds_S = LDS $@ > -cmd_cpp_lds_S = $(CPP) -P $(call cpp_flags,$(a_flags)) -D__LINKER__ -MQ $@ -o $@ $< > +cmd_cpp_lds_S = $(CPP) -P $(call cpp_flags,$(a_flags)) -DLINKER_SCRIPT -MQ $@ -o $@ $< > > targets := $(filter-out $(PHONY), $(targets)) > > diff --git a/xen/arch/arm/include/asm/config.h b/xen/arch/arm/include/asm/config.h > index c7b77912013e..2aced0bc3b8b 100644 > --- a/xen/arch/arm/include/asm/config.h > +++ b/xen/arch/arm/include/asm/config.h > @@ -191,7 +191,7 @@ extern unsigned long frametable_virt_end; > #define watchdog_disable() ((void)0) > #define watchdog_enable() ((void)0) > > -#if defined(__ASSEMBLY__) && !defined(__LINKER__) > +#if defined(__ASSEMBLY__) && !defined(LINKER_SCRIPT) > #include > #include > #endif -- Julien Grall