From: Oleksandr <olekstysh@gmail.com>
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: "Julien Grall" <jgrall@amazon.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Jan Beulich" <jbeulich@suse.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Wei Liu" <wl@xen.org>, "Roger Pau Monné" <roger.pau@citrix.com>,
"Oleksandr Tyshchenko" <oleksandr_tyshchenko@epam.com>
Subject: Re: [PATCH] xen: Introduce cmpxchg64() and guest_cmpxchg64()
Date: Sun, 16 Aug 2020 22:26:35 +0300 [thread overview]
Message-ID: <bd4449ad-46a2-4345-4682-cb068756ff6e@gmail.com> (raw)
In-Reply-To: <20200815172143.1327-1-julien@xen.org>
On 15.08.20 20:21, Julien Grall wrote:
Hi Julien
> From: Julien Grall <jgrall@amazon.com>
>
> The IOREQ code is using cmpxchg() with 64-bit value. At the moment, this
> is x86 code, but there is plan to make it common.
>
> To cater 32-bit arch, introduce two new helpers to deal with 64-bit
> cmpxchg.
>
> The Arm 32-bit implementation of cmpxchg64() is based on the __cmpxchg64
> in Linux v5.8 (arch/arm/include/asm/cmpxchg.h).
>
> Signed-off-by: Julien Grall <jgrall@amazon.com>
> Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> ---
> xen/include/asm-arm/arm32/cmpxchg.h | 68 +++++++++++++++++++++++++++++
> xen/include/asm-arm/arm64/cmpxchg.h | 5 +++
> xen/include/asm-arm/guest_atomics.h | 22 ++++++++++
> xen/include/asm-x86/guest_atomics.h | 2 +
> xen/include/asm-x86/x86_64/system.h | 2 +
> 5 files changed, 99 insertions(+)
Thank you for doing this. I have successfully build-tested your patch
with IOREQ series on Arm32/Arm64 (of course before that I had changed
cmpxchg to guest_cmpxchg64 in hvm_send_buffered_ioreq()).
--
Regards,
Oleksandr Tyshchenko
next prev parent reply other threads:[~2020-08-16 19:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-15 17:21 [PATCH] xen: Introduce cmpxchg64() and guest_cmpxchg64() Julien Grall
2020-08-16 19:26 ` Oleksandr [this message]
2020-08-17 9:24 ` Roger Pau Monné
2020-08-17 9:42 ` Julien Grall
2020-08-17 10:33 ` Roger Pau Monné
2020-08-17 11:05 ` Julien Grall
2020-08-17 11:50 ` Roger Pau Monné
2020-08-17 13:03 ` Julien Grall
2020-08-17 14:20 ` Roger Pau Monné
2020-08-19 9:22 ` Jan Beulich
2020-08-20 9:14 ` Julien Grall
2020-08-20 9:25 ` Jan Beulich
2020-08-20 9:34 ` Julien Grall
2020-08-19 9:18 ` Jan Beulich
2020-08-17 22:56 ` Stefano Stabellini
2020-08-18 10:30 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd4449ad-46a2-4345-4682-cb068756ff6e@gmail.com \
--to=olekstysh@gmail.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=jgrall@amazon.com \
--cc=julien@xen.org \
--cc=oleksandr_tyshchenko@epam.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).