From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64485C433E0 for ; Tue, 16 Jun 2020 12:25:49 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B8DF207C4 for ; Tue, 16 Jun 2020 12:25:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B8DF207C4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jlAee-0001p3-Td; Tue, 16 Jun 2020 12:25:28 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jlAed-0001oy-O9 for xen-devel@lists.xenproject.org; Tue, 16 Jun 2020 12:25:27 +0000 X-Inumbo-ID: 7548c19a-afcc-11ea-8496-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7548c19a-afcc-11ea-8496-bc764e2007e4; Tue, 16 Jun 2020 12:25:27 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id D620BAD41; Tue, 16 Jun 2020 12:25:29 +0000 (UTC) Subject: Re: [PATCH for-4.14 v2] tools/xen-ucode: fix error code propagation of microcode load operation To: Igor Druzhinin References: <1592307754-8844-1-git-send-email-igor.druzhinin@citrix.com> From: Jan Beulich Message-ID: Date: Tue, 16 Jun 2020 14:25:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <1592307754-8844-1-git-send-email-igor.druzhinin@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, ian.jackson@eu.citrix.com, wl@xen.org, xadimgnik@gmail.com Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 16.06.2020 13:42, Igor Druzhinin wrote: > @@ -62,8 +62,11 @@ int main(int argc, char *argv[]) > > ret = xc_microcode_update(xch, buf, len); > if ( ret ) > + { > fprintf(stderr, "Failed to update microcode. (err: %s)\n", > strerror(errno)); > + return errno; I think you need to latch errno, as fprintf() may in principle run into another error. Jan