From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B024C433EF for ; Sun, 7 Nov 2021 16:53:55 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F012261157 for ; Sun, 7 Nov 2021 16:53:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F012261157 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.222827.385207 (Exim 4.92) (envelope-from ) id 1mjlPp-0001ff-JP; Sun, 07 Nov 2021 16:53:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 222827.385207; Sun, 07 Nov 2021 16:53:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mjlPp-0001fY-GD; Sun, 07 Nov 2021 16:53:09 +0000 Received: by outflank-mailman (input) for mailman id 222827; Sun, 07 Nov 2021 16:53:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mjlPn-0001fS-Mb for xen-devel@lists.xenproject.org; Sun, 07 Nov 2021 16:53:07 +0000 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [2a00:1450:4864:20::134]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2c1d748b-3feb-11ec-a9d2-d9f7a1cc8784; Sun, 07 Nov 2021 17:53:06 +0100 (CET) Received: by mail-lf1-x134.google.com with SMTP id bi35so30724675lfb.9 for ; Sun, 07 Nov 2021 08:53:03 -0800 (PST) Received: from [192.168.2.145] (79-139-182-132.dynamic.spd-mgts.ru. [79.139.182.132]) by smtp.googlemail.com with ESMTPSA id c3sm860233lfb.122.2021.11.07.08.53.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Nov 2021 08:53:02 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2c1d748b-3feb-11ec-a9d2-d9f7a1cc8784 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=FuxjUSeidJvAMVHKU9E/d55P+zyTiwTeSCeqf/uVMDo=; b=Lwzfxq5uEYmwUHQaauy1zdfEe4xJydQ9b9Od8uYrwBczi5NJMIekKLJg7wlYTXl+4h aBwFrnzPjUuQZKv1Ia+S222jU8dJElyFhzTX7Y6Z3zgW5uo6fxyJ6Ub7QZuJOpIcD/5G Z5zvDqw9CupdRxfoeBn7XfS8iSTjIzecdpz5R8YfLYHN44fPq2Sj3DZqQfYaE9SGw4KM 9QVgWsVoZpReO+np7PVvhGoeoi2Muq2En7xd12JC02FvD5KUvlS8dKa1pfLtqGdyB8C3 Q31AQZyOLu3Y3rBXma7EsV9dMapOWW+H7dfnyyasqa2gU34jVZGgiKgGYKDrTdyFanCB 8Grw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FuxjUSeidJvAMVHKU9E/d55P+zyTiwTeSCeqf/uVMDo=; b=SLwDr5wpW2pKQ9kx/lm5riompaXHxmaeA2vLjTopSnpltK4yQCIBdDz+BRIjmrSqsc 2ziL5T7JFOx4K2iYhkDZC1lm5R/FL2soUYEQadLKqVsZLKMOSoT/mgEVyL7fxFxOksSr 4DRVKgbZ09sge/Kb7qUBWQnhcvqMFNEBVEnwMoGOqrF9kYCpnJxjacN0hqj+qhEANI7q a3iIMa5MzsTrgGNI83SC5ujAzJXJ/DF+R6LJgP6gjISZDNjAnAEo81PO0iOjTe94S2Yx DwMJrSGDP6Rxc2m2rCO0fU7YQK9qjTyfkQ+rvGUYEgunaCfITMx1RRDuf0lL1OQVKqOT YnTg== X-Gm-Message-State: AOAM531x42WVD5/GkULjInY5vTQwln3Hctr9eRPPV94QLtvSzt0hNU+7 GVqNKxEs9VJTlvUCG+AcE3E= X-Google-Smtp-Source: ABdhPJyYdIEr6ONtuDBexIQwg75AwiW2LoF8DEUBqYkEbum61pW0vPuGJTsEH8z54RKtLjaAI2MWow== X-Received: by 2002:a05:6512:1082:: with SMTP id j2mr64106958lfg.568.1636303982698; Sun, 07 Nov 2021 08:53:02 -0800 (PST) Subject: Re: [PATCH v2 27/45] mfd: ntxec: Use devm_register_power_handler() To: =?UTF-8?Q?Jonathan_Neusch=c3=a4fer?= Cc: Thierry Reding , Jonathan Hunter , Lee Jones , "Rafael J . Wysocki" , Mark Brown , Andrew Morton , Guenter Roeck , Russell King , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Nick Hu , Greentime Hu , Vincent Chen , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Linus Walleij , Chen-Yu Tsai , Tony Lindgren , Liam Girdwood , Philipp Zabel , Vladimir Zapolskiy , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Pavel Machek , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, linux-omap@vger.kernel.org, openbmc@lists.ozlabs.org, linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org References: <20211027211715.12671-1-digetx@gmail.com> <20211027211715.12671-28-digetx@gmail.com> From: Dmitry Osipenko Message-ID: Date: Sun, 7 Nov 2021 19:53:00 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit 06.11.2021 23:54, Jonathan Neuschäfer пишет: > Hi, > > On Thu, Oct 28, 2021 at 12:16:57AM +0300, Dmitry Osipenko wrote: >> Use devm_register_power_handler() that replaces global pm_power_off >> variable and allows to register multiple power-off handlers. It also >> provides restart-handler support, i.e. all in one API. >> >> Signed-off-by: Dmitry Osipenko >> --- > > When I boot with (most of) this patchset applied, I get the warning at > kernel/reboot.c:187: > > /* > * Handler must have unique priority. Otherwise call order is > * determined by registration order, which is unreliable. > */ > WARN_ON(!atomic_notifier_has_unique_priority(&restart_handler_list, nb)); > > As the NTXEC driver doesn't specify a priority, I think this is an issue > to be fixed elsewhere. > > Other than that, it works and looks good, as far as I can tell. > > > For this patch: > > Reviewed-by: Jonathan Neuschäfer > Tested-by: Jonathan Neuschäfer Thank you. You have conflicting restart handlers, apparently NTXEC driver should have higher priority than the watchdog driver. It should be a common problem for the watchdog drivers, I will lower watchdog's default priority to fix it.