Xen-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: "Jürgen Groß" <jgross@suse.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
	Oleksandr Andrushchenko <andr2000@gmail.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"ian.jackson@eu.citrix.com" <ian.jackson@eu.citrix.com>,
	"wl@xen.org" <wl@xen.org>
Subject: Re: [PATCH v2] xen/displif: Protocol version 2
Date: Thu, 2 Jul 2020 10:42:11 +0200
Message-ID: <be21be56-ea1b-e558-6905-a6cb3e5e4849@suse.com> (raw)
In-Reply-To: <f50ec904-8cb2-2bd6-c3ba-35e8c44bd607@epam.com>

On 02.07.20 09:59, Oleksandr Andrushchenko wrote:
> On 7/2/20 10:20 AM, Jürgen Groß wrote:
>> On 01.07.20 14:07, Oleksandr Andrushchenko wrote:
>>> On 7/1/20 1:46 PM, Jürgen Groß wrote:
>>>> On 01.07.20 09:19, Oleksandr Andrushchenko wrote:
>>>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>>>> 1. Add protocol version as an integer
>>>>> Version string, which is in fact an integer, is hard to handle in the
>>>>> code that supports different protocol versions. To simplify that
>>>>> also add the version as an integer.
>>>>> 2. Pass buffer offset with XENDISPL_OP_DBUF_CREATE
>>>>> There are cases when display data buffer is created with non-zero
>>>>> offset to the data start. Handle such cases and provide that offset
>>>>> while creating a display buffer.
>>>>> 3. Add XENDISPL_OP_GET_EDID command
>>>>> Add an optional request for reading Extended Display Identification
>>>>> Data (EDID) structure which allows better configuration of the
>>>>> display connectors over the configuration set in XenStore.
>>>>> With this change connectors may have multiple resolutions defined
>>>>> with respect to detailed timing definitions and additional properties
>>>>> normally provided by displays.
>>>>> If this request is not supported by the backend then visible area
>>>>> is defined by the relevant XenStore's "resolution" property.
>>>>> If backend provides extended display identification data (EDID) with
>>>>> XENDISPL_OP_GET_EDID request then EDID values must take precedence
>>>>> over the resolutions defined in XenStore.
>>>>> 4. Bump protocol version to 2.
>>>>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>>> Reviewed-by: Juergen Gross <jgross@suse.com>
>>> Thank you, do you want me to prepare the same for the kernel so
>>> you have it at hand when the time comes?
>> It should be added to the kernel only when really needed (i.e. a user of
>> the new functionality is showing up).
> We have a patch for that which adds EDID to the existing PV DRM frontend,
> so while upstreaming those changes I will also include changes to the protocol
> in the kernel series: for that we need the header in Xen tree first, right?



  reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-01  7:19 Oleksandr Andrushchenko
2020-07-01 10:46 ` Jürgen Groß
2020-07-01 12:07   ` Oleksandr Andrushchenko
2020-07-02  7:20     ` Jürgen Groß
2020-07-02  7:59       ` Oleksandr Andrushchenko
2020-07-02  8:42         ` Jürgen Groß [this message]
2020-07-08  5:59           ` Oleksandr Andrushchenko
2020-07-27  6:50 ` Oleksandr Andrushchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be21be56-ea1b-e558-6905-a6cb3e5e4849@suse.com \
    --to=jgross@suse.com \
    --cc=Oleksandr_Andrushchenko@epam.com \
    --cc=andr2000@gmail.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Xen-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/xen-devel/0 xen-devel/git/0.git
	git clone --mirror https://lore.kernel.org/xen-devel/1 xen-devel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 xen-devel xen-devel/ https://lore.kernel.org/xen-devel \
		xen-devel@lists.xenproject.org xen-devel@lists.xen.org
	public-inbox-index xen-devel

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git