From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6801DC4361B for ; Thu, 17 Dec 2020 11:01:26 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F3B9F2389E for ; Thu, 17 Dec 2020 11:01:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F3B9F2389E Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.55861.97436 (Exim 4.92) (envelope-from ) id 1kpr21-000113-8E; Thu, 17 Dec 2020 11:01:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 55861.97436; Thu, 17 Dec 2020 11:01:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kpr21-00010w-4O; Thu, 17 Dec 2020 11:01:13 +0000 Received: by outflank-mailman (input) for mailman id 55861; Thu, 17 Dec 2020 11:01:12 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kpr20-00010r-J8 for xen-devel@lists.xenproject.org; Thu, 17 Dec 2020 11:01:12 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7d20381c-d3ca-41a2-b072-9fb940ed0d13; Thu, 17 Dec 2020 11:01:10 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 616A8AD5C; Thu, 17 Dec 2020 11:01:09 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7d20381c-d3ca-41a2-b072-9fb940ed0d13 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1608202869; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6evqPzX3Evbi4aJ9HknSky1CGCSRblI/dM7uDwmX9Pw=; b=QaP61E+Jc0h/TECVh1XLvojjSNfnmglqtYg+HnBrW1eRnx6yXLmQzRYyZTQwNc3sQnvAfz n4fhM7vLKfSbhWzkcwpzsCUdZn8OEB8T6ijI8oYFiGCag92bu3LCe3aK8PXaYK3f3OpVSs Ta3ODPnsryaKLgL8aixuyVnc6fbpMsw= Subject: Re: [PATCH v3 4/8] xen/hypfs: support dynamic hypfs nodes To: Juergen Gross Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20201209160956.32456-1-jgross@suse.com> <20201209160956.32456-5-jgross@suse.com> From: Jan Beulich Message-ID: Date: Thu, 17 Dec 2020 12:01:09 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <20201209160956.32456-5-jgross@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 09.12.2020 17:09, Juergen Gross wrote: > @@ -158,6 +159,30 @@ static void node_exit_all(void) > node_exit(*last); > } > > +void *hypfs_alloc_dyndata_size(unsigned long size) > +{ > + unsigned int cpu = smp_processor_id(); > + > + ASSERT(per_cpu(hypfs_locked, cpu) != hypfs_unlocked); > + ASSERT(per_cpu(hypfs_dyndata, cpu) == NULL); > + > + per_cpu(hypfs_dyndata, cpu) = xzalloc_bytes(size); > + > + return per_cpu(hypfs_dyndata, cpu); > +} > + > +void *hypfs_get_dyndata(void) > +{ > + ASSERT(this_cpu(hypfs_dyndata)); > + > + return this_cpu(hypfs_dyndata); > +} > + > +void hypfs_free_dyndata(void) > +{ > + XFREE(this_cpu(hypfs_dyndata)); > +} In all three cases, would an intermediate local variable perhaps yield better generated code? (In hypfs_get_dyndata() this may be less important because the 2nd use is only an ASSERT().) > @@ -219,6 +244,12 @@ int hypfs_add_dir(struct hypfs_entry_dir *parent, > return ret; > } > > +void hypfs_add_dyndir(struct hypfs_entry_dir *parent, > + struct hypfs_entry_dir *template) > +{ > + template->e.parent = &parent->e; > +} I'm struggling with the direction here: This makes the template point at the parent, but the parent will still have no "knowledge" of its new templated children. I suppose that's how it is meant to be, but maybe this could do with a comment, since it's the opposite way of hypfs_add_dir()? Also - does this mean parent may not also have further children, templated or "normal"? > @@ -177,6 +182,10 @@ struct hypfs_entry *hypfs_leaf_findentry(const struct hypfs_entry_dir *dir, > struct hypfs_entry *hypfs_dir_findentry(const struct hypfs_entry_dir *dir, > const char *name, > unsigned int name_len); > +void *hypfs_alloc_dyndata_size(unsigned long size); > +#define hypfs_alloc_dyndata(type) (type *)hypfs_alloc_dyndata_size(sizeof(type)) This wants an extra pair of parentheses. As a minor point, I also wonder whether you really want the type unsafe version to be easily usable. It would be possible to largely "hide" it by having void *hypfs_alloc_dyndata(unsigned long size); #define hypfs_alloc_dyndata(type) ((type *)hypfs_alloc_dyndata(sizeof(type))) Jan