From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ABCCFC7EE2E for ; Fri, 9 Jun 2023 17:56:48 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.546262.852991 (Exim 4.92) (envelope-from ) id 1q7gLl-0001Mr-Sh; Fri, 09 Jun 2023 17:56:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 546262.852991; Fri, 09 Jun 2023 17:56:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q7gLl-0001Mk-Ph; Fri, 09 Jun 2023 17:56:37 +0000 Received: by outflank-mailman (input) for mailman id 546262; Fri, 09 Jun 2023 17:56:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q7gLl-0001Me-15 for xen-devel@lists.xenproject.org; Fri, 09 Jun 2023 17:56:37 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q7gLk-0002sK-9H; Fri, 09 Jun 2023 17:56:36 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.17.204]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1q7gLk-0001fi-3v; Fri, 09 Jun 2023 17:56:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=I/XAB7XbzKAPGLD1rbBRO0QeAiPswmqeLhHJ7ZZ8eiU=; b=cnpG3GsSQ+9Sng4vzAYL2SjlYb D7KtE1tW5wGPgtg4i1UqZYc9QJORAG4lYuDdcZJvQadQaGTWyOtIC5x/Iw96RzsCWzp1RyGuCat7s YFwo/EorQ4Fyxj7Ehc4NG4OXQghnyGgvaJd6IcCgua7vvzmd3RHzvkfIPumVC2k0difI=; Message-ID: Date: Fri, 9 Jun 2023 18:56:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v3 04/16] tools/xenstore: rename hashtable_insert() and let it return 0 on success Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230530085418.5417-1-jgross@suse.com> <20230530085418.5417-5-jgross@suse.com> From: Julien Grall In-Reply-To: <20230530085418.5417-5-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 30/05/2023 09:54, Juergen Gross wrote: > Today hashtable_insert() returns 0 in case of an error. Change that to > let it return an errno value in the error case and 0 in case of success. > In order to avoid any missed return value checks or related future > backport errors, rename hashtable_insert() to hashtable_add(). > > Even if not used today, do the same switch for the return value of > hashtable_expand(). > > Signed-off-by: Juergen Gross Reviewed-by: Julien Grall Cheers, -- Julien Grall