From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Juergen Gross <jgross@suse.com>,
Konrad Wilk <konrad.wilk@oracle.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 2/3] xen-pciback: reconfigure also from backend watch handler
Date: Mon, 12 Apr 2021 11:55:41 -0400 [thread overview]
Message-ID: <c0e94f59-e91a-1f54-4692-59bb72b01f43@oracle.com> (raw)
In-Reply-To: <529f18d5-89ae-596e-29a7-d773e5a3c6b2@suse.com>
On 4/12/21 5:44 AM, Jan Beulich wrote:
>
>> It also looks a bit odd that adding a device is now viewed as a reconfiguration. It seems to me that xen_pcibk_setup_backend() and xen_pcibk_reconfigure() really should be merged --- initialization code for both looks pretty much the same.
> I thought the same, but didn't want to make more of a change than is
> needed to address the problem at hand. Plus of course there's still
> the possibility that someone may fix libxl, at which point the change
> here (and hence the merging) would become unnecessary.
Merging them would be a good thing regardless of fixing libxl. But I agree that it is separate from fixing the issue at hand.
Maybe rename the function? (I myself can't think of a good name).
-boris
next prev parent reply other threads:[~2021-04-12 15:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 14:35 [PATCH 0/3] xen-pciback: a fix, a workaround, and some simplification Jan Beulich
2021-04-07 14:37 ` [PATCH 1/3] xen-pciback: redo VF placement in the virtual topology Jan Beulich
2021-04-08 22:28 ` Boris Ostrovsky
2021-04-09 8:16 ` Jan Beulich
2021-04-07 14:37 ` [PATCH 2/3] xen-pciback: reconfigure also from backend watch handler Jan Beulich
2021-04-09 21:43 ` Boris Ostrovsky
2021-04-12 9:44 ` Jan Beulich
2021-04-12 15:55 ` Boris Ostrovsky [this message]
2021-04-07 14:37 ` [PATCH 3/3] xen-pciback: simplify vpci's find hook Jan Beulich
2021-04-09 21:45 ` Boris Ostrovsky
2021-04-12 9:50 ` Jan Beulich
2021-04-12 16:05 ` Boris Ostrovsky
2021-04-13 8:09 ` Jan Beulich
2021-04-13 12:54 ` Boris Ostrovsky
2021-04-23 8:05 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0e94f59-e91a-1f54-4692-59bb72b01f43@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).