From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Roger Pau Monne <roger.pau@citrix.com>, xen-devel@lists.xenproject.org
Cc: Ian.Jackson@eu.citrix.com, wei.liu2@citrix.com
Subject: Re: [PATCH v2] xl: add option to leave domain paused after migration
Date: Tue, 19 Jul 2016 16:43:21 -0400 [thread overview]
Message-ID: <c2ce2bf4-e63a-0104-c96c-6cd9fb9effeb@oracle.com> (raw)
In-Reply-To: <1468918695-2633-1-git-send-email-roger.pau@citrix.com>
On 07/19/2016 04:58 AM, Roger Pau Monne wrote:
> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> index d8530f0..fd80442 100644
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -4742,7 +4742,7 @@ static void migrate_domain(uint32_t domid, const char *rune, int debug,
> exit(EXIT_FAILURE);
> }
>
> -static void migrate_receive(int debug, int daemonize, int monitor,
> +static void migrate_receive(int debug, int daemonize, int monitor, int pause,
This causes a name shadowing error on an old compiler:
cc1: warnings being treated as errors
xl_cmdimpl.c: In function ‘migrate_receive’:
xl_cmdimpl.c:4781: error: declaration of ‘pause’ shadows a global
declaration
/usr/include/unistd.h:466: error: shadowed declaration is here
xl_cmdimpl.c: In function ‘main_migrate_receive’:
xl_cmdimpl.c:5008: error: declaration of ‘pause’ shadows a global
declaration
/usr/include/unistd.h:466: error: shadowed declaration is here
xl_cmdimpl.c: In function ‘main_migrate’:
xl_cmdimpl.c:5094: error: declaration of ‘pause’ shadows a global
declaration
/usr/include/unistd.h:466: error: shadowed declaration is here
make: *** [xl_cmdimpl.o] Error 1
FC-64 <build@build-mk2:~/xtt-x86_64/bootstrap/xen/tools/libxl> gcc
--version | head -1
gcc (GCC) 4.4.4 20100503 (Red Hat 4.4.4-2)
FC-64 <build@build-mk2:~/xtt-x86_64/bootstrap/xen/tools/libxl> grep
pause /usr/include/unistd.h
extern int pause (void);
FC-64 <build@build-mk2:~/xtt-x86_64/bootstrap/xen/tools/libxl>
-boris
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-07-19 20:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 8:58 [PATCH v2] xl: add option to leave domain paused after migration Roger Pau Monne
2016-07-19 9:00 ` Wei Liu
2016-07-19 13:15 ` Wei Liu
2016-07-19 15:50 ` Roger Pau Monne
2016-07-19 15:51 ` Wei Liu
2016-07-19 20:43 ` Boris Ostrovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2ce2bf4-e63a-0104-c96c-6cd9fb9effeb@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).