From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
"Julien Grall" <julien@xen.org>, "Wei Liu" <wl@xen.org>,
Xen-devel <xen-devel@lists.xenproject.org>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH] xen/vcpu: Improve sanity checks in vcpu_create()
Date: Thu, 16 Jan 2020 10:55:14 +0100 [thread overview]
Message-ID: <c42a1292-d7e9-fe23-1a44-866c2c7c5c9e@suse.com> (raw)
In-Reply-To: <20200115184418.21365-1-andrew.cooper3@citrix.com>
On 15.01.2020 19:44, Andrew Cooper wrote:
> The BUG_ON() is confusing to follow. The (!is_idle_domain(d) || vcpu_id) part
> is a vestigial remnant of architectures poisioning idle_vcpu[0] with non-NULL
> pointers.
>
> Now that idle_vcpu[0] is NULL on all architectures, and d->max_vcpus specified
> before vcpu_create() is called, we can properly range check the requested
> vcpu_id.
I guess this is meant to be true on top of your Arm side change
which hasn't been committed yet? And perhaps better "... starts
out as NULL on all ..."?
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-01-16 9:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 18:44 [Xen-devel] [PATCH] xen/vcpu: Improve sanity checks in vcpu_create() Andrew Cooper
2020-01-16 9:55 ` Jan Beulich [this message]
2020-01-16 10:04 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c42a1292-d7e9-fe23-1a44-866c2c7c5c9e@suse.com \
--to=jbeulich@suse.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=julien@xen.org \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).