From: Juergen Gross <jgross@suse.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
stable@vger.kernel.org,
"Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
Subject: Re: [PATCH v3] xen/balloon: add late_initcall_sync() for initial ballooning done
Date: Mon, 1 Nov 2021 08:15:24 +0100 [thread overview]
Message-ID: <c5da2698-b160-c09e-3182-49b398238a3c@suse.com> (raw)
In-Reply-To: <11956c14-f1f7-70f0-40a6-aad31a264af6@oracle.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 1950 bytes --]
On 29.10.21 23:46, Boris Ostrovsky wrote:
>
> On 10/29/21 10:20 AM, Juergen Gross wrote:
>> --- a/Documentation/ABI/stable/sysfs-devices-system-xen_memory
>> +++ b/Documentation/ABI/stable/sysfs-devices-system-xen_memory
>> @@ -84,3 +84,13 @@ Description:
>> Control scrubbing pages before returning them to Xen for
>> others domains
>> use. Can be set with xen_scrub_pages cmdline
>> parameter. Default value controlled with
>> CONFIG_XEN_SCRUB_PAGES_DEFAULT.
>> +
>> +What: /sys/devices/system/xen_memory/xen_memory0/boot_timeout
>> +Date: November 2021
>> +KernelVersion: 5.16
>> +Contact: xen-devel@lists.xenproject.org
>> +Description:
>> + The time (in seconds) to wait before giving up to boot in case
>> + initial ballooning fails to free enough memory. Applies only
>> + when running as HVM or PVH guest and started with less memory
>> + configured than allowed at max.
>
>
> How is this going to be used? We only need this during boot.
Of course. Will switch to module_param().
>> - state = update_schedule(state);
>> + balloon_state = update_schedule(balloon_state);
>
>
> Now that balloon_state has whole file scope it can probably be updated
> inside update_schedule().
I can do that.
>> + while ((credit = current_credit()) < 0) {
>> + if (credit != last_credit) {
>> + last_changed = jiffies;
>> + last_credit = credit;
>> + }
>> + if (balloon_state == BP_ECANCELED) {
>
>
> What about other states? We are really waiting for BP_DONE, aren't we?
Nearly. We are waiting for credit not being negative.
And in case of cancelled we know this won't happen without Xen admin
intervention.
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3135 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
prev parent reply other threads:[~2021-11-01 7:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 14:20 [PATCH v3] xen/balloon: add late_initcall_sync() for initial ballooning done Juergen Gross
2021-10-29 21:46 ` Boris Ostrovsky
2021-10-29 22:18 ` Marek Marczykowski-Górecki
2021-10-29 23:44 ` Boris Ostrovsky
2021-11-01 7:21 ` Juergen Gross
2021-11-01 7:15 ` Juergen Gross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5da2698-b160-c09e-3182-49b398238a3c@suse.com \
--to=jgross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marmarek@invisiblethingslab.com \
--cc=sstabellini@kernel.org \
--cc=stable@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).