From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BD30C6377B for ; Thu, 22 Jul 2021 02:38:29 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08CEC61264 for ; Thu, 22 Jul 2021 02:38:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 08CEC61264 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.159611.293545 (Exim 4.92) (envelope-from ) id 1m6ObJ-00083P-17; Thu, 22 Jul 2021 02:38:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 159611.293545; Thu, 22 Jul 2021 02:38:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6ObI-00083I-Tv; Thu, 22 Jul 2021 02:38:16 +0000 Received: by outflank-mailman (input) for mailman id 159611; Thu, 22 Jul 2021 02:38:16 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6ObI-00083C-Ad for xen-devel@lists.xenproject.org; Thu, 22 Jul 2021 02:38:16 +0000 Received: from mga04.intel.com (unknown [192.55.52.120]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6f0fd50f-14b8-40d4-a7c6-a32910c1c8d7; Thu, 22 Jul 2021 02:38:10 +0000 (UTC) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2021 19:38:09 -0700 Received: from lingshan-mobl5.ccr.corp.intel.com (HELO [10.255.29.38]) ([10.255.29.38]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2021 19:38:02 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f0fd50f-14b8-40d4-a7c6-a32910c1c8d7 X-IronPort-AV: E=McAfee;i="6200,9189,10052"; a="209653908" X-IronPort-AV: E=Sophos;i="5.84,259,1620716400"; d="scan'208";a="209653908" X-IronPort-AV: E=Sophos;i="5.84,259,1620716400"; d="scan'208";a="512014134" Subject: Re: [PATCH V8 01/18] perf/core: Use static_call to optimize perf_guest_info_callbacks To: Like Xu Cc: bp@alien8.de, seanjc@google.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, kan.liang@linux.intel.com, ak@linux.intel.com, wei.w.wang@intel.com, eranian@google.com, liuxiangdong5@huawei.com, linux-kernel@vger.kernel.org, x86@kernel.org, kvm@vger.kernel.org, boris.ostrvsky@oracle.com, Like Xu , Will Deacon , Marc Zyngier , Guo Ren , Nick Hu , Paul Walmsley , Boris Ostrovsky , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org, xen-devel@lists.xenproject.org, Peter Zijlstra , Paolo Bonzini References: <20210716085325.10300-1-lingshan.zhu@intel.com> <20210716085325.10300-2-lingshan.zhu@intel.com> From: "Zhu, Lingshan" Message-ID: Date: Thu, 22 Jul 2021 10:38:00 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US On 7/21/2021 7:57 PM, Like Xu wrote: > On 16/7/2021 4:53 pm, Zhu Lingshan wrote: >> +    } else if (xenpmu_data->pmu.r.regs.cpl & 3) oh, my typo, will fix in V9 Thanks > > Lingshan, serious for this version ? > > arch/x86/xen/pmu.c:438:9: error: expected identifier or ‘(’ before > ‘return’ >   438 |         return state; >       |         ^~~~~~ > arch/x86/xen/pmu.c:439:1: error: expected identifier or ‘(’ before ‘}’ > token >   439 | } >       | ^ > arch/x86/xen/pmu.c: In function ‘xen_guest_state’: > arch/x86/xen/pmu.c:436:9: error: control reaches end of non-void > function [-Werror=return-type] >   436 |         } >       |         ^ > cc1: some warnings being treated as errors > >> +            state |= PERF_GUEST_USER; >>       }